Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136879 --- Ship it! Ship It! - Chris Pettitt On June 9, 2016, 12:33 a.m

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

> On June 9, 2016, 12:28 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala, > > line 90 > > > > > > This is a test that Xinyu por

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

> On June 6, 2016, 8:36 p.m., Navina Ramesh wrote: > > samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala, > > line 90 > > > > > > I don't understand the point of this test. If

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

> On June 6, 2016, 6:22 p.m., Chris Pettitt wrote: > > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala, > > line 528 > > > > > > How about actually capturing the test failure and ret

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/ --- (Updated June 9, 2016, 12:33 a.m.) Review request for samza, Chris Pettitt, Nav

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136735 --- Ship it! samza-kv-rocksdb/src/test/scala/org/apache/samza/stor

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review135984 --- Fix it, then Ship it! some nits.. otherwise, +1 ! samza-kv-ro

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136335 --- Fix it, then Ship it! samza-test/src/test/scala/org/apache/sam

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

> On June 3, 2016, 5:49 p.m., Chris Pettitt wrote: > > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala, > > lines 409-410 > > > > > > I'm not totally sure what you're trying to do with

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/ --- (Updated June 3, 2016, 9:30 p.m.) Review request for samza, Chris Pettitt, Navi

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136075 --- Fix it, then Ship it! samza-kv-rocksdb/src/test/scala/org/apac