Re: Review Request 44604: split deployment logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44604/#review126604 --- Ship it! LGTM! +1 - Yi Pan (Data Infrastructure) On March 31

Re: Review Request 44604: split deployment logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44604/ --- (Updated March 31, 2016, 9:21 p.m.) Review request for samza and Yi Pan (Data I

Re: Review Request 44604: split deployment logic

> On March 25, 2016, 5:15 p.m., Yi Pan (Data Infrastructure) wrote: > > One more comment: we need open source documentation for the split > > deployment as well. Please add the online documentation for this feature. I will do it as a separate JIRA, cause it will take little bit longer. - Bori

Re: Review Request 44604: split deployment logic

> On March 25, 2016, 5:14 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala, > > line 17 > > > > > > One question on this: how about ThreadJobF

Re: Review Request 44604: split deployment logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44604/#review125433 --- One more comment: we need open source documentation for the split

Re: Review Request 44604: split deployment logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44604/#review125429 --- Overall lgtm. I have a few comments below. Thanks a lot! samza-c

Re: Review Request 44604: split deployment logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44604/ --- (Updated March 15, 2016, 5:33 p.m.) Review request for samza and Yi Pan (Data I