Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

Thanks, Yi! On Wed, Jul 29, 2015 at 12:16 PM, Yi Pan wrote: > Hi, Roger, > > I am testing the patch now. Will update the JIRA soon. > > Thanks! > > -Yi > > On Wed, Jul 29, 2015 at 12:11 PM, Roger Hoover > wrote: > > > Thank you, Dan. I think we're ready to merge. Can one of the Samza > > comm

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

Hi, Roger, I am testing the patch now. Will update the JIRA soon. Thanks! -Yi On Wed, Jul 29, 2015 at 12:11 PM, Roger Hoover wrote: > Thank you, Dan. I think we're ready to merge. Can one of the Samza > committers please take a look? > > On Wed, Jul 29, 2015 at 11:31 AM, Dan Harvey > wrote

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

Thank you, Dan. I think we're ready to merge. Can one of the Samza committers please take a look? On Wed, Jul 29, 2015 at 11:31 AM, Dan Harvey wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36815/ > > On July 29th, 2015, 8:42 a.m. UTC, *D

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

> On July 29, 2015, 8:42 a.m., Dan Harvey wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 116 > > > > > > Should we add a Samza specifc m

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/#review93493 --- Ship it! LGTM. Thanks a lot! - Yi Pan (Data Infrastructure) On J

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

> On July 29, 2015, 8:42 a.m., Dan Harvey wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 116 > > > > > > Should we add a Samza specifc m

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 29, 2015, 6:24 p.m.) Review request for samza and Dan Harvey. C

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

> On July 29, 2015, 8:42 a.m., Dan Harvey wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 116 > > > > > > Should we add a Samza specifc m

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/#review93413 --- samza-elasticsearch/src/main/java/org/apache/samza/system/elasticse

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 29, 2015, 6:22 a.m.) Review request for samza and Dan Harvey. C

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

> On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 149 > > > > > > Quick questio

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 29, 2015, 6:18 a.m.) Review request for samza and Dan Harvey. C

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

> On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 149 > > > > > > Quick questio

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

> On July 29, 2015, 5:47 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 149 > > > > > > Quick questio

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/#review93395 --- LGTM except a nit comment. Thanks! samza-elasticsearch/src/main/ja

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 29, 2015, 5:17 a.m.) Review request for samza and Dan Harvey. C

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

> On July 28, 2015, 7:36 a.m., Dan Harvey wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 115 > > > > > > could switch these around so yo

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/#review93249 --- samza-elasticsearch/src/main/java/org/apache/samza/system/elasticse

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 28, 2015, 6:13 a.m.) Review request for samza. Changes ---

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36815/ --- (Updated July 25, 2015, 4:48 p.m.) Review request for samza. Repository: samz