Re: Review Request 34009: WIP: SAMZA-650 window store implementation

> On May 12, 2015, 3:07 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java, > > line 83 > > > > > > Don't we need to make this final because we are

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

> On May 12, 2015, 2:39 p.m., Milinda Pathirage wrote: > > Hi, Yi, > > > > Patch looks good overall. I think we should get this into samza-sql branch > > first and change the SAMZA-561 patch to work with latest API changes. Thanks a lot! I am addressing the comments/issues from you and from my

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

> On May 12, 2015, 2:36 p.m., Milinda Pathirage wrote: > > samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.java, line > > 62 > > > > > > I assume this is the system time. If yes, may be having a brief

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/#review83405 --- samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/St

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/#review83396 --- Hi, Yi, Patch looks good overall. I think we should get this into s

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/#review83395 --- samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Tuple.ja

Re: Review Request 34009: WIP: SAMZA-650 window store implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34009/ --- (Updated May 9, 2015, 1:52 a.m.) Review request for samza, Chris Riccomini, Guo