Re: Java 11 Checkin again

2022-09-19 Thread Yi Pan
Hi, James, Sorry that I was busy during the day and couldn't check your email. I have joined the slack channel you created. Let's discuss there. Best, -Yi On Mon, Sep 19, 2022 at 9:23 AM James DeMichele wrote: > Hey, Yi! Thanks. > > I started a slack channel that maybe would make it easier to

Re: Java 11 Checkin again

2022-09-19 Thread James DeMichele
Hey, Yi! Thanks. I started a slack channel that maybe would make it easier to communicate if I have questions. I do have one issue that I am hitting between the 2 different Yarn versions I think and that I am not entirely sure what to do about. I made a change to a Test class that was needed for a

Re: Java 11 Checkin again

2022-09-19 Thread Yi Pan
Hi, James, Thanks a lot for reporting this. I will take a look this week. Best! -Yi On Mon, Sep 19, 2022 at 8:20 AM James DeMichele wrote: > Hey Yi. I can take a look at this. I do want to point out that your current > "master" branch is actually broken for using Scala 2.11. > > You can repro

Re: Java 11 Checkin again

2022-09-19 Thread James DeMichele
Hey Yi. I can take a look at this. I do want to point out that your current "master" branch is actually broken for using Scala 2.11. You can repro by just going into the master branch using Java 8 and compiling like this $ java -version openjdk version "1.8.0_332" OpenJDK Runtime Environment (Tem

Re: Java 11 Checkin again

2022-09-14 Thread Yi Pan
Hey, James, In order to merge your PR without breaking the jdk8 older modules, we will need the changes proposed here. Can you try to add those build script changes in the same PR? We will definitely help review and merge it. Best! -Yi On Wed, Sep 14, 2022 at 8:00 AM James DeMichele wrote: >

Re: Java 11 Checkin again

2022-09-14 Thread James DeMichele
Also, do you have a timeline for when this could be completed? Thanks. On Wed, Sep 14, 2022 at 7:16 AM James DeMichele wrote: > That sounds like a great solution to me if that works for y'all! > > Note too, the Java 11 and yarn 3 module need to only use the Scala 2.12 > version of the build. > >

Re: Java 11 Checkin again

2022-09-14 Thread James DeMichele
That sounds like a great solution to me if that works for y'all! Note too, the Java 11 and yarn 3 module need to only use the Scala 2.12 version of the build. Jamie On Wed, Sep 14, 2022, 2:38 AM Yi Pan wrote: > Hi, James, > > Sorry to reply late. I just came back from a trip and had a discuss

Re: Java 11 Checkin again

2022-09-14 Thread Yi Pan
Hi, James, Sorry to reply late. I just came back from a trip and had a discussion with our internal team as well. So, there is one proposal other than creating a branch. Let me elaborate it below: a) creating a new module samza-yarn3 that depends on YARN 3.3.0 and be the hosting module for most of

Re: Java 11 Checkin again

2022-09-13 Thread James DeMichele
Hey Yi, I wanted to follow up here and figure what a path forward is here. We need to move to Java 11, and Samza currently is our only blocking issue. In order to move to Java 11, the Yarn Cluster would need to run on Java 11 correct? If that's the case, then it would need to be 3.3+. I don't know

Re: Java 11 Checkin again

2022-09-06 Thread James DeMichele
Yeah I mean if Samza works fine with the hadoop-yarn library running against a 3.3.x YARN cluster, then I don't mind keeping that library of 2.10.x in Samza's code. But it is still a moot point in terms of upgrading your YARN cluster, since it must be upgraded to 3.3.x+ in order to be able to run t

Re: Java 11 Checkin again

2022-09-02 Thread Malcolm McFarland
Hi all, I've been doing a little bit of testing with Samza and Hadoop 3.3.4; afaict, in light testing, Samza seems to work fine using the 2.10.x hadoop-yarn library against a YARN cluster running 3.3.x. As Jamie pointed out, YARN didn't incorporate Java 11 compatibility until v3.3.0 ( https://hado

Re: Java 11 Checkin again

2022-09-02 Thread James DeMichele
Hey Yi, Thanks for getting back to me. I have not tried the older yarn cluster version yet in the Samza app running against 3.3.4 but I am wary it would work. Yarn itself is not compatible at 2.10.1 with Java 11 so you would have to update yarn even if the Java library here wasn't updated. Could

Re: Java 11 Checkin again

2022-09-02 Thread Yi Pan
Hey, James, Thanks for the ping. @prateek, can we have someone to review this change? One question: have you tested the change w/ the older YARN cluster version (running 2.10.1)? If this change requires YARN cluster upgrade to 3.3.4 as well, that may be a breaking change to existing Samza users (

Java 11 Checkin again

2022-09-02 Thread James DeMichele
Hey y'all. I just am not sure how to get some traction on these Java 11 PRs. https://github.com/apache/samza/pull/1628 https://github.com/apache/samza-hello-samza/pull/87 Would someone that is a maintainer for Samza just let us know that y'all are looking at them? I can stop pestering you :) I r