Re: [DISCUSS] SEP 25: PR Title and Description Guidelines

2019-12-18 Thread Prateek Maheshwari
Thanks for the feedback folks. Since the feedback is positive, I'll start a VOTE for the SEP. @Jagadish Venkatraman , will add a link to this SEP to the contributor's corner in the appropriate place. Thanks, Prateek On Mon, Dec 16, 2019 at 12:09 PM Yi Pan wrote: > +1 (binding). lgtm. Thanks! >

Re: [DISCUSS] SEP 25: PR Title and Description Guidelines

2019-12-16 Thread Yi Pan
+1 (binding). lgtm. Thanks! -Yi On Mon, Dec 16, 2019 at 8:08 AM Daniel Nishimura wrote: > +1. Thank Prateek for standardizing the PR process better. > > On Sun, Dec 15, 2019 at 10:55 PM Bharath Kumara Subramanian < > codin.mart...@gmail.com> wrote: > > > +1. Template looks good to me. > > It w

Re: [DISCUSS] SEP 25: PR Title and Description Guidelines

2019-12-16 Thread Daniel Nishimura
+1. Thank Prateek for standardizing the PR process better. On Sun, Dec 15, 2019 at 10:55 PM Bharath Kumara Subramanian < codin.mart...@gmail.com> wrote: > +1. Template looks good to me. > It will be really helpful to sift through, categorize and prepare release > notes from notable PRs during re

Re: [DISCUSS] SEP 25: PR Title and Description Guidelines

2019-12-15 Thread Bharath Kumara Subramanian
+1. Template looks good to me. It will be really helpful to sift through, categorize and prepare release notes from notable PRs during releases. Thanks, Bharath On Fri, Dec 13, 2019 at 11:24 PM Jagadish Venkatraman < jagadish1...@gmail.com> wrote: > +1, thanks for the write-up Prateek. > > Let

[DISCUSS] SEP 25: PR Title and Description Guidelines

2019-12-13 Thread Jagadish Venkatraman
+1, thanks for the write-up Prateek. Let's also update the contributor's guidelines at: https://samza.apache.org/contribute/contributors-corner.html On Friday, December 13, 2019, Prateek Maheshwari wrote: > Hi folks, > > In order to make Samza PR descriptions and commit messages more consisten

[DISCUSS] SEP 25: PR Title and Description Guidelines

2019-12-13 Thread Prateek Maheshwari
Hi folks, In order to make Samza PR descriptions and commit messages more consistent, informative and discoverable, we propose the following requirements for new PRs submitted to the Samza project https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines Con