Review Request 46296: SAMZA-932: JMX port collisions in JmxServer

Thanks, Tao Feng

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

. ./gradlew checkstyleMain checkstyleTest 3. manual test open source hello samza and verify that by giving yarn.container.count or job.container.count with value greater than 1 for ProcessJobFactory, the test will throw the desired exception. Thanks, Tao Feng

Review Request 44420: SAMZA-888: SamzaContainer initializes ExponentialSleepStrategy with randInt that is inclusive of 0

clean build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng

Re: Review Request 44418: SAMZA-887: Use cached JobModel everywhere in the Samza AM container

0c6329ede9b3df4dc05125729b5b44ba2c98803a Diff: https://reviews.apache.org/r/44418/diff/ Testing --- ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng

Review Request 44418: SAMZA-877: Use cached JobModel everywhere in the Samza AM container

/gradlew checkstyleMain checkstyleTest Thanks, Tao Feng

Re: key value store restore time

Hi Leo, At linkedin when we switched to using RocksDB for Samza last year, we did some tests to see how well RocksDB performs. We used the rocksdb microbenchmark( https://github.com/facebook/rocksdb/blob/master/java/benchmark/src/main/java/org/rocksdb/benchmark/DbBenchmark.java) to conduct serval

Re: Review Request 43550: SAMZA-836: fix unit test failure w/ FlushOptions() in rocksdbjni-3.13.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43550/#review119113 --- Ship it! Ship It! - Tao Feng On Feb. 13, 2016, 12:13 a.m

Re: ChangeLog Question for TTL rocksDB stores

Hi David, My understanding is that Samza changelog could still be logging those entries deleted by RocksDB TTL. You could refer to SAMZA-677 for more information. Thanks, -Tao On Wed, Feb 3, 2016 at 5:46 PM, David Garcia wrote: > Boris, thank you for the clarification. But just to make sure I

Re: samza gc tuning, what about serial + serial old?

Hi Bo, I think application usually would not want to use Serial GC which is designed only for uniprocessor. If you have 8G~10G memory, the STW time with serial GC could be quite large. Even Samza is designed for one core as you mentioned, if the message rate of upstream data is huge, you would st

Review Request 43011: SAMZA-807: Need a configuration variable to ignore SystemStreamPartitionGrouperFactory changes in checkpoint topic

&& ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng

Review Request 43010: SAMZA-807: Need a configuration variable to ignore SystemStreamPartitionGrouperFactory changes in checkpoint topic

build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng

Review Request 42485: SAMZA-857: Missing break in RocksDbOptionsHelper#options()

: Missing break in RocksDbOptionsHelper#options() Diffs - samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/RocksDbOptionsHelper.java e474231f48c2d9ba0c9a73291afcc19b52ce8da1 Diff: https://reviews.apache.org/r/42485/diff/ Testing --- Thanks, Tao Feng

Re: Configuring RocksDB SST file size

Hi Kishore, I am not sure what do you mean by ulimit issues, could you help to explain a little bit? And I am not sure if user could control the size of SST files as each SST file corresponds with one sorted run. My understanding is that the SST file size could depends on how many memtables get f

Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

adlew clean build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng

Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41365/#review110553 ------- On Dec. 14, 2015, 9:04 p.m., Tao Feng wrote: > > -

Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not handled correctly

: https://reviews.apache.org/r/41365/diff/ Testing --- ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

build 2. ./gradlew checkstyleMain checkstyleTest 3. manual test open source hello samza and verify that by giving yarn.container.count or job.container.count with value greater than 1 for ProcessJobFactory, the test will throw the desired exception. Thanks, Tao Feng

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109571 ------- On Dec. 9, 2015, 6:41 a.m., Tao Feng wrote: > > --- &g

Re: [VOTE] Samza 0.10.0 Release Candidate 2

+1 from my side(non-binding). I download the package and successfully run all the unit tests without failure. On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan wrote: > Hey all, > > > This is a call for a vote on a release of Apache Samza 0.10.0. Thanks to > everyone who has contributed to this release. We

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

amza.config.JobConfig.Config2Job Update rb per comment - Tao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109428 ------- On Dec. 9, 2015, 6:41 a.m., Tao Feng wrote: > > ---

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

eater than 1 for ProcessJobFactory, the test will throw the desired exception. Thanks, Tao Feng

Review Request 41106: SAMZA-833: ProcessJob mishandling containers

/ Testing --- 1. ./gradlew clean build 2. ./gradlew checkstyleMain checkstyleTest 3. manual test open source hello samza and verify that by giving yarn.container.count or job.container.count with value greater than 1 for ProcessJobFactory, the test will throw the desired exception. Thanks, Tao

Re: Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented

--------- On Nov. 20, 2015, 8:20 a.m., tao feng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40525/ > ---

Re: Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented

samza/storage/kv/TestRocksDbKeyValueStore.scala a428a16bc1e9ab4980a6f17db4fd810057d31136 Diff: https://reviews.apache.org/r/40525/diff/ Testing --- 1. ./gradlew clean build 2. ./gradlew checkstyleMain checkstyleTest Thanks, tao feng

Review Request 40525: SAMZA-819: RocksDbKeyValueStore.flush() should be implemented

. ./gradlew clean build 2. ./gradlew checkstyleMain checkstyleTest Thanks, tao feng

Re: Use one producer for both coordinator stream and users system?

nce.) > > Thanks, > > Fang, Yan > yanfang...@gmail.com > > On Mon, Aug 17, 2015 at 9:49 PM, Tao Feng wrote: > > > Hi Yan, > > > > Naive question: what do we need producer thread of coordinator stream > for? > > > > Thanks, > > -Tao

Re: Use one producer for both coordinator stream and users system?

Hi Yan, Naive question: what do we need producer thread of coordinator stream for? Thanks, -Tao On Mon, Aug 17, 2015 at 2:09 PM, Yan Fang wrote: > Hi guys, > > I have this question because Kafka's doc > < > http://kafka.apache.org/082/javadoc/org/apache/kafka/clients/producer/KafkaProducer.htm

Re: Measuring Samza Job Throughput

; on how to set up the perf tests. > > Best! > > -Yi > > On Wed, Jun 17, 2015 at 11:25 AM, Milinda Pathirage > > wrote: > > > Thank you all for the ideas. I'll have a look at KafkaSystem metrics and > > SamzaContainerMetrics. > > > > Milinda

Re: Measuring Samza Job Throughput

Hi, One metric I could think of related to Samza job throughput is the "process-envelop" metric listed in SamzaContainerMetrics. This counter get incremented whenever the container process meaningful message( https://github.com/apache/samza/blob/master/samza-core/src/main/scala/org/apache/samza/co