Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

68/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

ans here. > > > > Use @code instead of @param here. Fixed. - Shanthoosh ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164786 --

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164765 ------- On Feb. 8, 2017, 9:37 p.m., Shanthoosh Venkataraman wrote: > > --- >

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

/scala/org/apache/samza/config/KafkaConfig.scala 9320cf744ff90d647a198b51cb06d2a526fe68fa Diff: https://reviews.apache.org/r/52476/diff/ Testing --- Unit testing and manual testing has been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

/scala/org/apache/samza/config/KafkaConfig.scala 9320cf744ff90d647a198b51cb06d2a526fe68fa Diff: https://reviews.apache.org/r/52476/diff/ Testing --- Unit testing and manual testing has been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

DAYS.toMillis(1) Fixed. - Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164701 --- On Feb. 8, 2017, 7

Re: Review Request 52476: SAMZA-1083 : Do not load task store which are older than delete tombstones.

been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

ne32> > > > > s/CHANGE_LOG/CHANGELOG Fixed. - Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153741 -------

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review163035 --- On Oct. 22, 2016, 10:06 p.m., Shanthoosh Venkataraman wrote: > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

, Shanthoosh Venkataraman

Re: Review Request 53297: Initial version of adding metrics into samza rest.

/samza/job/yarn/SamzaAppMasterMetrics.scala 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca Diff: https://reviews.apache.org/r/53297/diff/ Testing --- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 53297: Initial version of adding metrics into samza rest.

/TestSamzaRestService.java PRE-CREATION samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca Diff: https://reviews.apache.org/r/53297/diff/ Testing --- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh

Re: Review Request 53297: Initial version of adding metrics into samza rest.

he MetricsConfig constructure takes a subset. > > > > I think it takes the root and expects to find the "metrics" prefix > > Jake Maes wrote: > s/constructure/constructor > > phonetic brain fail > > Shanthoosh Venkataraman wrote: > Ye

Re: Review Request 53297: Initial version of adding metrics into samza rest.

10, 2016, 6:57 p.m., Prateek Maheshwari wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line > > 91 > > <https://reviews.apache.org/r/53297/diff/5/?file=1560180#file1560180line91> > > > > See previous comment abo

Re: Review Request 53297: Initial version of adding metrics into samza rest.

re? The samza-rest server? The monitor? The > > container being monitored? > > Shanthoosh Venkataraman wrote: > I think `execution unit` is a misnomer. By execution unit, I meant the > origin of the metrics (physical hostname in which the samza rest process is > run

Re: Review Request 53297: Initial version of adding metrics into samza rest.

is used when metrics are reported? > > > > Is there a reason for this to be configurable / adding a new config > > key? > > > > If it's configurable, we should document it somewhere? > > Shanthoosh Venkataraman wrote: > Container name here re

Re: Review Request 53297: Initial version of adding metrics into samza rest.

/53297/diff/ Testing --- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 53297: Initial version of adding metrics into samza rest.

/SamzaAppMasterMetrics.scala 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca Diff: https://reviews.apache.org/r/53297/diff/ Testing --- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 53297: Initial version of adding metrics into samza rest.

amzaRestResource literal etc) - Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155511 ------- On Nov. 9, 201

Re: Review Request 53297: Initial version of adding metrics into samza rest.

is used when metrics are reported? > > > > Is there a reason for this to be configurable / adding a new config > > key? > > > > If it's configurable, we should document it somewhere? > > Shanthoosh Venkataraman wrote: > Container name here re

Re: Review Request 53297: Initial version of adding metrics into samza rest.

is undefined, it's defaulted to hostName on which SamzaRest is running. Resources will report metrics alongside monitors. Added relevent documentation for it. - Shanthoosh --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 53297: Initial version of adding metrics into samza rest.

/SamzaAppMasterMetrics.scala 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca Diff: https://reviews.apache.org/r/53297/diff/ Testing --- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 53297: Initial version of adding metrics into samza rest.

xtracting utils(and other common functionalities) shared between samza-core & samza-rest into samza-common is a longer term goal which is required to remove dependencies. However, for the scope of this patch, doing this will be a overkill. Punted for now. - Shanthoosh ----

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> <https://reviews.apache.org/r/52168/diff/8/?file=1552723#file1552723line99> > > > > Not required for the other place they're used? > > Shanthoosh Venkataraman wrote: > Yes. > > Prateek Maheshwari wrote: > "Yes, it's required&q

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

/rest/resources/tasks.md, line 22 > > <https://reviews.apache.org/r/52168/diff/10/?file=1553937#file1553937line22> > > > > I don't think the line that `Additional operations will be added later` > > is meaningful. You can maybe remove it? Done. - Shantho

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 53297: Initial version of adding metrics into samza rest.

/apache/samza/rest/TestSamzaRestService.java > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala > 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca > > Diff: https://reviews.apache.org/r/53297/diff/ > > > Testing > --- > > Unit tests are done to verify the intended functionality. > > > Thanks, > > Shanthoosh Venkataraman > >

Re: Review Request 53297: Initial version of adding metrics into samza rest.

/53297/diff/ Testing --- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 53297: Initial version of adding metrics into samza rest.

. Not sure of the implications of using a proper name here. For instance, in SamzaContainerMetrics source string is assigned to value "unknown". I'm most certain that this string is a placeholder to register MetricsRegistry instances with MetricsReporter and not used when r

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala, > > line 340 > > <https://reviews.apache.org/r/52168/diff/8/?file=1552723#file1552723line340> > > > > Previous line. Done. > On Nov. 3, 2016, 6:32 a.m., Prateek Maheshwari wrote: &g

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

/MockTaskProxy.java PRE-CREATION samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

/MockTaskProxy.java PRE-CREATION samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

ps://reviews.apache.org/r/52168/#review153819 ------- On Nov. 3, 2016, 12:58 a.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

/MockTaskProxy.java PRE-CREATION samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Review Request 53297: Initial version of adding metrics into samza rest.

8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca Diff: https://reviews.apache.org/r/53297/diff/ Testing --- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

il. To reply, visit: https://reviews.apache.org/r/52492/#review153772 ------- On Oct. 26, 2016, 12:41 a.m., Shanthoosh Venkataraman wrote: > > --- > This is an automat

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

/MockTaskProxyFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

factory. - Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152928 --- On Oct. 13, 2016, 11:57 p.m., Shanthoosh

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

> > > > getChangeLogDeleteRetentionsInMs Done. - Shanthoosh ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153478

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

/scala/org/apache/samza/config/KafkaConfig.scala 973ab8cfb3d248bec7efe5e338f5e667f097556d Diff: https://reviews.apache.org/r/52476/diff/ Testing --- Unit testing and manual testing has been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

ps://reviews.apache.org/r/52476/#review153468 ------- On Oct. 22, 2016, 10:06 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

------ On Oct. 20, 2016, 9:52 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52492/ > ---

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

ine 122 > > <https://reviews.apache.org/r/52476/diff/3/?file=1539990#file1539990line122> > > > > Mention somewhere in the message that this means that the store is > > stale. Done. - Shanthoosh --- This is

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

/scala/org/apache/samza/config/KafkaConfig.scala 973ab8cfb3d248bec7efe5e338f5e667f097556d Diff: https://reviews.apache.org/r/52476/diff/ Testing --- Unit testing and manual testing has been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

--- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

------ On Oct. 19, 2016, 1:11 a.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53002/ > ---

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

, Shanthoosh Venkataraman

Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

/mock/MockMonitorFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/53002/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

/scala/org/apache/samza/config/KafkaConfig.scala 973ab8cfb3d248bec7efe5e338f5e667f097556d Diff: https://reviews.apache.org/r/52476/diff/ Testing --- Unit testing and manual testing has been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

e for delete.retention.ms > > 2. Rename the property so it's one of the "topic-level-property" so it gets > > automatically passed to kafka. This is convenient but wouldn't apply to > > other systems, which could be useful if those other systems have a delete

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

> On Oct. 13, 2016, 12:55 a.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55 > > <https://reviews.apache.org/r/52168/diff/5/?file=1533539#file1533539line55> > > > > What is the value of the container name? &

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

- Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review151439 --- On Oct. 4, 2016, 11:33 p.m., Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

skProxy.java > PRE-CREATION > > samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52168/diff/ > > > Testing > --- > > Manual and unit testing has been done to verify the apis. > > > Thanks, > > Shanthoosh Venkataraman > >

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

.apache.org/r/52168/#review152418 --- On Oct. 13, 2016, 11:57 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

tor.java PRE-CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

ewrites configuration specific to it. - Shanthoosh Venkataraman On Oct. 10, 2016, 11:10 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

fetch info from the samza rest API at > > those urls Moved all the url constants to query into ResourceConstants class. - Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/#review

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

esources/ResourceConstants.java PRE-CREATION samza-rest/src/test/java/org/apache/samza/monitor/TestYarnLocalStoreMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Sh

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

ion. Here we have jobId, jobName passed on as the api params, we could use it to populate the config. By pluggablity you mean plugging in (jobId, jobName) or the rewriters. - Shanthoosh --- This is an automatically generated e-mail

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

est/java/org/apache/samza/monitor/TestLocalStoreMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

://reviews.apache.org/r/52476/diff/ Testing --- Unit testing and manual testing has been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

ew151273 ------- On Oct. 3, 2016, 5 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52476/

Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

/monitor/TestLocalStoreMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing --- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman

Review Request 52476: Do not load task store which are older than delete tombstones.

--- Unit testing and manual testing has been done to verify the functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

://reviews.apache.org/r/51703/diff/ Testing --- Unit tests are used to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

Diff: https://reviews.apache.org/r/51703/diff/ Testing --- Unit tests are used to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

://reviews.apache.org/r/51703/#review150435 --- On Sept. 24, 2016, 12:34 a.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

are used to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

are used to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

c4f3f735f78d56f8bb3ef203a05e2bec92489767 samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/51703/diff/ Testing --- Unit tests are used to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

separate class. Whole functionality of parsing the configs are migrated to MonitorLoader class. - Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150196 ---

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

/SamzaMonitorService.java (lines 74 - 75) <https://reviews.apache.org/r/51703/#comment218128> Instantiation of monitors through reflection using monitorFactoryClassName can possibly throw InstantiationException. This catch block handles that. - Shanthoosh Venkataraman On Sept. 14, 2016, 8:

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

te the monitor instances from factory, can throw InstantiationException. This catch block handles that. - Shanthoosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150206 -

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

/samza/rest/resources/mock/MockTaskProxyFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/52168/diff/ Testing --- Manual and unit testing has been done to verify the apis. Thanks, Shanthoosh Venkataraman

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review148730 --- On Sept. 14, 2016, 8:37 p.m., Shanthoosh Venkataraman wrote: > > -

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

ity in allowing many custom MonitorFactory implementations. - Shanthoosh Venkataraman On Sept. 14, 2016, 8:37 p.m., Shanthoosh Venkataraman wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767 Diff: https://reviews.apache.org/r/51703/diff/ Testing --- Unit tests are used to verify the intended functionality. Thanks, Shanthoosh Venkataraman

Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

-CREATION Diff: https://reviews.apache.org/r/51703/diff/ Testing --- Unit tests are used to verify the intended functionality. Thanks, Shanthoosh Venkataraman