Review Request 36274: SAMZA-401: getCpuTime to truly calculate duty cycle of the event loop

2015-07-07 Thread Luis De Pombo
samza-core/src/main/scala/org/apache/samza/util/Util.scala 2feb65b729b45fbc3b83a75c4072527e3c4e60be samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 64a5844bdb343a3c509cba059b9f3b9a19dc9eff Diff: https://reviews.apache.org/r/36274/diff/ Testing --- Thanks, Luis De

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-06-11 Thread Luis De Pombo
--- Thanks, Luis De Pombo

Review Request 35053: SAMZA-683: add meter and histogram support in the metrics reporter

2015-06-04 Thread Luis De Pombo
09f4dc32a4b18aeb3accb856c360ea2f95c82673 Diff: https://reviews.apache.org/r/35053/diff/ Testing --- Thanks, Luis De Pombo

Re: Review Request 34564: SAMZA-401: add utilization metrics for the event loop

2015-06-03 Thread Luis De Pombo
://reviews.apache.org/r/34564/diff/ Testing --- Thanks, Luis De Pombo

Re: Review Request 34564: SAMZA-401: add utilization metrics for the event loop

2015-06-03 Thread Luis De Pombo
ide the method. Agreed, a similar method that returns the elapsed time seems cleanest. - Luis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34564/#review84886 -----

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-06-02 Thread Luis De Pombo
--- Thanks, Luis De Pombo

Review Request 34585: SAMZA-681: create a unit test harness to easily test samza tasks

2015-05-21 Thread Luis De Pombo
/java/org/apache/samza/test/harness/TestProcessTask.java PRE-CREATION samza-test/src/test/java/org/apache/samza/test/harness/TestWindowTask.java PRE-CREATION Diff: https://reviews.apache.org/r/34585/diff/ Testing --- Thanks, Luis De Pombo

Review Request 34564: SAMZA-401: add utilization metrics for the event loop

2015-05-21 Thread Luis De Pombo
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 73ec2b5a7c1ca17fbb80604355881bff51f7e41e Diff: https://reviews.apache.org/r/34564/diff/ Testing --- Thanks, Luis De Pombo

Review Request 34539: SAMZA-401: add utilization metrics for the event loop

2015-05-21 Thread Luis De Pombo
Diff: https://reviews.apache.org/r/34539/diff/ Testing --- Thanks, Luis De Pombo

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-21 Thread Luis De Pombo
--- Thanks, Luis De Pombo

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-14 Thread Luis De Pombo
bb07a3b84b14dcef94da1bb166eab6aa3d0026bb Diff: https://reviews.apache.org/r/34011/diff/ Testing --- Thanks, Luis De Pombo

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-14 Thread Luis De Pombo
> On May 14, 2015, 7:09 a.m., Luis De Pombo wrote: > > Thanks for the comments Yan! I will address them and will follow up on the > > issue around org.apache.samza.metrics.Snapshot.getMax() I will also add to the document

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-14 Thread Luis De Pombo
er which is was registered - Luis De Pombo On May 11, 2015, 10:10 a.m., Luis De Pombo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-11 Thread Luis De Pombo
PRE-CREATION settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb Diff: https://reviews.apache.org/r/34011/diff/ Testing --- Thanks, Luis De Pombo

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-11 Thread Luis De Pombo
/metrics/reporter/SamzaGraphiteReporterTest.java PRE-CREATION settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb Diff: https://reviews.apache.org/r/34011/diff/ Testing --- Thanks, Luis De Pombo

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-11 Thread Luis De Pombo
: https://reviews.apache.org/r/34011/#review83169 ------- On May 9, 2015, 6:31 a.m., Luis De Pombo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34011/ > ---

Re: Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-11 Thread Luis De Pombo
bounds. Use it and file a bug to take a look at that? samza-core/src/main/java/org/apache/samza/metrics/reporter/GraphiteSnapshot.java <https://reviews.apache.org/r/34011/#comment134111> I'm implenting an interface so I can't throw an exception. I will implement it. - Lu

Review Request 34011: Add support for a Graphite Metrics Reporter

2015-05-08 Thread Luis De Pombo
/samza/metrics/reporter/GraphiteTimerTest.java PRE-CREATION samza-core/src/test/java/org/apache/samza/metrics/reporter/SamzaGraphiteReporterTest.java PRE-CREATION Diff: https://reviews.apache.org/r/34011/diff/ Testing --- Thanks, Luis De Pombo