Hey Tim,
I have an initial patch that is waiting on one patch for the new consumer
that is about to be committed and then just needs minor cleanup to
integrate with Kafka's build. There are other things that will still need
cleanup (e.g., I prototyped using Confluent's serializers + schema
registr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32052/#review76444
---
Ship it!
Ship It!
- Ewen Cheslack-Postava
On March 13, 2015, 9
wise
we'll refresh that topic's metadata unnecessarily? Might make sense to also
provide KafkaUtil.isBadErrorCode(code: Short) that takes care of this and use
that instead of ever using ErrorMapping directly unless you need to check
specific error codes.
- Ewen Cheslack-Postava
/TestRunLoop.scala
ea48853
Diff: https://reviews.apache.org/r/31881/diff/
Testing
---
Passes unit and zopkio tests.
Thanks,
Ewen Cheslack-Postava
>
> Description
> ---
>
> Shutdown RunLoop on SIGTERM.
>
>
> Diffs
> -
>
> samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 499f5c6
> samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala
> ea48853
>
> Diff: https://reviews.apache.org/r/31881/diff/
>
>
> Testing
> ---
>
> Passes unit and zopkio tests.
>
>
> Thanks,
>
> Ewen Cheslack-Postava
>
>
/TestRunLoop.scala
ea48853
Diff: https://reviews.apache.org/r/31881/diff/
Testing
---
Passes unit and zopkio tests.
Thanks,
Ewen Cheslack-Postava
Cheslack-Postava
