Re: Why do I always receive waring email?

2015-08-26 Thread Dan
I also get this too now and again. I think it must be an apache e-mail issue, can we get someone from their infrastructure team to have a look? - Dan On 26 August 2015 at 06:02, Yan Fang wrote: > I actually do not know... I receive it frequently as well... But since I > still can get

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Dan Harvey
> On July 29, 2015, 8:42 a.m., Dan Harvey wrote: > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java, > > line 116 > > <https://reviews.apache.org/r/36815/diff/6/?file=1024157#file1024157line116> > > >

Re: Review Request 36905: SAMZA-745 elasticsearch module has Javadoc warning

2015-07-29 Thread Dan Harvey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36905/#review93416 --- Lokks good. - Dan Harvey On July 29, 2015, 9:10 a.m., Aleksandar

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-29 Thread Dan Harvey
iled to index message in ElasticSearch.", e);` This would also be true for other log lines added. One comment on the logging but I think this looks great otherwise. - Dan Harvey On July 29, 2015, 6:22 a.m., Roger Hoover wrote: > >

Re: [DISCUSS] Release 0.10.0

2015-07-29 Thread Dan
I agree SAMZA-741 for the ElasticSearch producer should be in too so we've got a better API as part of that release. - Dan On 29 July 2015 at 07:51, Yan Fang wrote: > Actually, I also want to include a few patch-available features, > especially: > > 1. broadcast

Re: Review Request 36815: SAMZA-741 Support for versioning with Elasticsearch Producer

2015-07-28 Thread Dan Harvey
search/indexrequest/DefaultIndexRequestFactory.java (line 92) <https://reviews.apache.org/r/36815/#comment147604> I know I set this line before but reading the elasticsearch docs they recommend using `Requests.indexRequest(index).type(type)` - Dan

Re: Can I get an example of using the ElasticSearch producer?

2015-07-25 Thread Dan
Also if you have any questions once you've had a look over those feel free to post here and we can try and help. It's great to see plenty of interest in using the ElasticSearch producer! Thanks, Dan On 24 July 2015 at 21:29, Yan Fang wrote: > Hi guys, > > Thank you for

Re: getting started

2015-07-14 Thread Dan
, offsets, etc... The tutorial Tim gave should help with the kafka consuming side. - Dan On 14 July 2015 at 16:30, Tim Williams wrote: > On Tue, Jul 14, 2015 at 3:20 PM, Woessner, Leo > wrote: > > Hello all, > > > > I work for Pearson and am want to test using Samza. I wan

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-07-10 Thread Dan Harvey
--- Thanks, Dan Harvey

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-06-09 Thread Dan Harvey
--- Thanks, Dan Harvey

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-06-09 Thread Dan Harvey
ne 33 > > <https://reviews.apache.org/r/33297/diff/5/?file=947318#file947318line33> > > > > this only test the factory gets the config, does not test the GetClient > > method works correctly, right? Yes, with the config update I've fixed this. > On May 4, 2

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-06-05 Thread Dan Harvey
> Can we catch for invalid casts here and throw with a more verbose > > exception, to aid in future debugging? I now check the type and thrown an exception if it's not supported currently. - Dan --- This is an auto

Re: Errors and hung job on broker shutdown

2015-05-12 Thread Dan
roducer is failing to discover the broker changes. - Dan On Tue, 12 May 2015 at 17:04 Guozhang Wang wrote: > Hmm, that is a little wired since if the ip addresses are not changed then > the producer should be able to re-connect. I checked your logs again, and > only saw two ip a

Re: Errors and hung job on broker shutdown

2015-05-11 Thread Dan
The three ip addresses were the same as before, but in a different mapping to id's. Does what you said still hold true in that case? We are fixing the ip and id mappings so that they will be fixed so this problem won't happen for us again. I know this scenario is not a expected case.

Re: Errors and hung job on broker shutdown

2015-05-08 Thread Dan
amza Kafka consumer and that coped fine with the restart. We are using Kafka 0.8.2.1 and Samza 0.9.0. Thanks, Dan On Mon, 4 May 2015 at 14:37 Garry Turkington < g.turking...@improvedigital.com> wrote: > Hi Guozhang, > > Honestly snappy is so hugely more performant for me that I

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-05-01 Thread Dan Harvey
/DefaultIndexRequestFactoryTest.java PRE-CREATION settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb Diff: https://reviews.apache.org/r/33297/diff/ Testing --- Thanks, Dan Harvey

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-05-01 Thread Dan Harvey
te[] and possible pass more though to the client. But I think what I've now done is good for basic use. - Dan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33297/#review81430

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-23 Thread Dan Harvey
--- Thanks, Dan Harvey

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-23 Thread Dan Harvey
> > > If the previous send has failed, i.e., sendFailed is true here, > > shouldn't we throw an exception here ? Otherwise it might result in message > > develivered out of order. > > Navina Ramesh wrote: > I think the messages are only buffered and

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-23 Thread Dan Harvey
> > Is this flush a blocking call in elasticsearch? This will be block if concurrent requests is set to 0 in the BulkProcessor, so we should enforce that in the setup. - Dan --- This is an automatically generated e-mail. To rep

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-23 Thread Dan Harvey
> > > If the previous send has failed, i.e., sendFailed is true here, > > shouldn't we throw an exception here ? Otherwise it might result in message > > develivered out of order. > > Navina Ramesh wrote: > I think the messages are only buffered and not se

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-22 Thread Dan Harvey
-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/IndexRequestFactory.java PRE-CREATION settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb Diff: https://reviews.apache.org/r/33297/diff/ Testing --- Thanks, Dan Harvey

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-22 Thread Dan Harvey
: https://reviews.apache.org/r/33297/diff/ Testing --- Thanks, Dan Harvey

Re: Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-22 Thread Dan Harvey
e/samza/system/elasticsearch/ElasticsearchSystemFactory.java, > > line 26 > > <https://reviews.apache.org/r/33297/diff/1/?file=933091#file933091line26> > > > > Since the admin is doing nothing, should we just have a single instance > > of it to return?

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
> On April 20, 2015, 9:55 p.m., Navina Ramesh wrote: > > Can you update the Samza [configuration > > docs](http://samza.apache.org/learn/documentation/latest/jobs/configuration-table.html) > > with info about this re-writer ? Sure, I've added to the configurati

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
PRE-CREATION samza-core/src/test/java/org/apache/samza/config/EnvironmentConfigRewriterTest.java PRE-CREATION Diff: https://reviews.apache.org/r/33305/diff/ Testing --- Thanks, Dan Harvey

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
iews.apache.org/r/33305/diff/1/?file=933124#file933124line49> > > > > Can we warn if we are overriding a previously defined key? I can see > > the potential for difficult-to-debug issues if keys are silently overridden. Yes, I've added this to the logging too. - Dan

Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-22 Thread Dan Harvey
-CREATION Diff: https://reviews.apache.org/r/33305/diff/ Testing --- Thanks, Dan Harvey

Re: Extra Systems and other extensions.

2015-04-17 Thread Dan
https://issues.apache.org/jira/browse/SAMZA-655 - Env variable rewriter Again any comments on the format of the variables names welcome! - Dan On 15 April 2015 at 17:38, Chinmay Soman wrote: > +1 ! I was going to do this for my use case as well. Would love to have > this ! > > On Wed, Apr 15

Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api.

2015-04-17 Thread Dan Harvey
/diff/ Testing --- Thanks, Dan Harvey

Review Request 33297: [SAMZA-654] Added ElasticsearchSystemProducer and Factory to output messages into Elasticseach indexes.

2015-04-17 Thread Dan Harvey
-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java PRE-CREATION settings.gradle bb07a3b84b14dcef94da1bb166eab6aa3d0026bb Diff: https://reviews.apache.org/r/33297/diff/ Testing --- Thanks, Dan Harvey

Re: Extra Systems and other extensions.

2015-04-14 Thread Dan
Thanks Jakob, I agree they'll be more maintained and tested if they're in the main repo so that's great. I'll sort out Jira's and get some patches of what we've got working now out for review. - Dan On 14 April 2015 at 19:56, Jakob Homan wrote: > Hey Dan-

Extra Systems and other extensions.

2015-04-14 Thread Dan
#x27;s the best way for us to add things like this? Do you want more modules in the main project or should we just create some separate projects on github? It would be good to get core extensions like these shared to be tested and used by more people Thanks, Dan

Re: Store changelog

2015-04-02 Thread Dan
given changelog stream (each instance of a job and each store needs its own changelog stream)." - Dan On Thu, 2 Apr 2015 at 18:46 Chinmay Soman wrote: > Also documented here: > http://samza.apache.org/learn/documentation/0.9/container/ > state-management.html > > Check

Store changelog

2015-04-02 Thread Dan
file then generate a topic name for each task it would simplify using that. Maybe there's something I'm missing from this? Thanks, Dan