Re: Review Request 53163: SAMZA-901: SamzaAppState re-design for thread safety

2016-10-27 Thread Branislav Cogic
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53163/#review153840 --- On Oct. 25, 2016, 8:25 a.m., Branislav Cogic wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 53163: SAMZA-901: SamzaAppState re-design for thread safety

2016-10-27 Thread Branislav Cogic
Checked that app state is shown correctly on web servlet index page. Thanks, Branislav Cogic

Review Request 53163: SAMZA-901: SamzaAppState re-design for thread safety

2016-10-25 Thread Branislav Cogic
shown correctly on web servlet index page. Thanks, Branislav Cogic

Review Request 52213: SAMZA-952: Add validation for broadcast inputs configured for partitions that don't exist

2016-09-23 Thread Branislav Cogic
scala ba38b5cfa4e61b5513ce38dd2be32438b62cd7ce Diff: https://reviews.apache.org/r/52213/diff/ Testing --- Ran ./gradlew clean build ./gradlew checkstyleMain checkstyleTest and tested manually with kafka Thanks, Branislav Cogic

Review Request 51726: SAMZA-1005: Refactor class instantiation code to a helper class.

2016-09-08 Thread Branislav Cogic
://reviews.apache.org/r/51726/diff/ Testing --- Ran those commands successfully on Linux: ./gradlew clean build ./gradlew checkstyleMain checkstyleTest ./bin/check-all.sh And ran hello-samza jobs successfully. Thanks, Branislav Cogic

Re: Review Request 51516: SAMZA-702: Document the significance of all the different metrics emitted by Samza out of the box

2016-09-02 Thread Branislav Cogic
.apache.org/r/51516/#review147523 --- On Sept. 2, 2016, 9:10 a.m., Branislav Cogic wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 51516: SAMZA-702: Document the significance of all the different metrics emitted by Samza out of the box

2016-09-02 Thread Branislav Cogic
e74 Diff: https://reviews.apache.org/r/51516/diff/ Testing (updated) --- Site ran locally using local-site-test.sh ./gradlew clean build ./gradlew checkstyleMain checkstyleTest Thanks, Branislav Cogic

Re: Review Request 51516: SAMZA-702: Document the significance of all the different metrics emitted by Samza out of the box

2016-09-02 Thread Branislav Cogic
ucer.scala fab998a37ad1f9c08693684ddf6354aeea43de74 Diff: https://reviews.apache.org/r/51516/diff/ Testing --- Site ran locally using local-site-test.sh Thanks, Branislav Cogic

Review Request 51516: SAMZA-702: Document the significance of all the different metrics emitted by Samza out of the box

2016-08-30 Thread Branislav Cogic
f/ Testing --- Site ran locally using local-site-test.sh Thanks, Branislav Cogic

Review Request 48621: SAMZA-949: KafkaCheckpointManager should not try forever for non-recoverable checkpoint deserialization failures

2016-06-13 Thread Branislav Cogic
/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 Diff: https://reviews.apache.org/r/48621/diff/ Testing --- ./gradlew clean build and manual testing Thanks, Branislav Cogic

Review Request 47761: SAMZA-856: Optionally automatically commit based on number of processed messages

2016-05-24 Thread Branislav Cogic
checkstyleTest" Tested on modified hello-samza with supported checkpointing and partitioned streams. Thanks, Branislav Cogic

Review Request 45108: SAMZA-854 Upgraded zookeeper dependency to version 3.4.8

2016-03-21 Thread Branislav Cogic
--- Upgraded zookeeper dependency to version 3.4.8 Diffs - bin/grid 042cabe355ec3a8fff06f193252fec494d01a864 Diff: https://reviews.apache.org/r/45108/diff/ Testing --- Launched hello samza on grid with zookeeper 3.4.8 version successfully. Thanks, Branislav Cogic

Review Request 44952: SAMZA-854: Zookeeper dependency upgraded to version 3.4.8

2016-03-21 Thread Branislav Cogic
27621978b0c24a3d4d264e834c16c267d8fb2f5b Diff: https://reviews.apache.org/r/44952/diff/ Testing --- Launched integration test and ran these commands successfully ./gradlew clean test --refresh-dependencies ./bin/check-all.sh Thanks, Branislav Cogic

Review Request 44452: SAMZA-879: SystemConsumer mock object editet. SystemConsumers tests are passing.

2016-03-07 Thread Branislav Cogic
fbaa8eeb98857640a36a0c4f62c7b276b59390aa Diff: https://reviews.apache.org/r/44452/diff/ Testing --- Thanks, Branislav Cogic

Review Request 43766: SAMZA-872: little change in Logging docs

2016-02-19 Thread Branislav Cogic
/diff/ Testing --- Thanks, Branislav Cogic

Re: Review Request 43648: SAMZA-872: removed unsafe log4j DaillyRollingFileAppender from hello-samza

2016-02-17 Thread Branislav Cogic
f0de7658c76fe1b3925b0d73dd3236ff8a297590 Diff: https://reviews.apache.org/r/43648/diff/ Testing --- Thanks, Branislav Cogic

Review Request 43648: SAMZA-872: removed unsafe log4j DaillyRollingFileAppender from hello-samza

2016-02-17 Thread Branislav Cogic
--- Changed log4j configuration in hello-samza project to reference RolingFileAppender instead of DailyRollingFileAppender Diffs - src/main/resources/log4j.xml f0de7658c76fe1b3925b0d73dd3236ff8a297590 Diff: https://reviews.apache.org/r/43648/diff/ Testing --- Thanks, Branislav