Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-03-08 Thread Amit Yadav
sufficient. Agreed. The latest diff has this change. - Amit --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41068/#review122271 ------

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-03-08 Thread Amit Yadav
samza/storage/kv/MockKeyValueStore.scala 595dd0df6fde50f91ab5a046a193559326f2a1d5 Diff: https://reviews.apache.org/r/41068/diff/ Testing --- Thanks, Amit Yadav

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-02-26 Thread Amit Yadav
Last()? It does not seem to be useful. Do you have any > > specific use case for it? It would also appears more natural if we just add > > APIs like: first(), last(), instead of seekToLast(). > > > > Thanks! > > Amit Yadav wrote: > @Yi, I will share my

Re: Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2016-02-26 Thread Amit Yadav
/src/test/scala/org/apache/samza/storage/kv/MockKeyValueStore.scala 595dd0df6fde50f91ab5a046a193559326f2a1d5 Diff: https://reviews.apache.org/r/41068/diff/ Testing --- Thanks, Amit Yadav

Review Request 41068: SAMZA-813: Add Seek functionality to KeyValueStoreIterator

2015-12-07 Thread Amit Yadav
https://reviews.apache.org/r/41068/diff/ Testing --- Thanks, Amit Yadav