Samza App and Job Config Refacor

2019-02-14 Thread Sanil Jain
Hi All, I am proposing an App & Job Config refactor for Samza. Details can be found here: https://docs.google.com/document/d/1Q8tNF6zlXSyefOO6koXWgiDuyV6eLngKoU-5KLvq3I4/edit Tracking Ticket: https://issues.apache.org/jira/browse/SAMZA-2106 Please have a look and let me know your thoughts. Th

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257073732 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] Sanil15 opened a new pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-14 Thread GitBox
Sanil15 opened a new pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920 Proposal doc: https://docs.google.com/document/d/1Q8tNF6zlXSyefOO6koXWgiDuyV6eLngKoU-5KLvq3I4/edit --

[GitHub] Sanil15 commented on issue #920: SAMZA-2106: Samza app and job config refactor

2019-02-14 Thread GitBox
Sanil15 commented on issue #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#issuecomment-463866182 @vjagadish1989 please have a look. This is an automated message from the Apach

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257063620 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSyst

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257061763 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257062873 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257063162 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSyst

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257062107 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257058746 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257061221 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257063321 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSyst

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257058381 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257060720 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] vjagadish1989 commented on a change in pull request #899: SAMZA-2091: Update ZkClient in samza-standalone to use string serializer

2019-02-14 Thread GitBox
vjagadish1989 commented on a change in pull request #899: SAMZA-2091: Update ZkClient in samza-standalone to use string serializer URL: https://github.com/apache/samza/pull/899#discussion_r256973855 ## File path: samza-core/src/main/java/org/apache/samza/zk/ZkBarrierForVersionUpgr

[GitHub] jmakes merged pull request #919: Make config immutable again

2019-02-14 Thread GitBox
jmakes merged pull request #919: Make config immutable again URL: https://github.com/apache/samza/pull/919 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] strkkk opened a new pull request #919: Make config immutable again

2019-02-14 Thread GitBox
strkkk opened a new pull request #919: Make config immutable again URL: https://github.com/apache/samza/pull/919 Config is supposed to be immutable, but method Map#replaceAll in its default implementation mutates the config. Code to check: ``` Map m = new HashMap() { { pu