Re: [VOTE] Apache Samza 1.0.0 RC2

2018-10-24 Thread Yi Pan
Ran check-all and deployed locally with the test jobs. All tests passed. +1 (binding) from my end. Thanks for push the release! -Yi On Wed, Oct 24, 2018 at 8:53 AM Prateek Maheshwari wrote: > Hi Jagadish, > > PR 755 is mis-titled. Its only adding back the tests for the old > consumer. The old

[GitHub] samza pull request #761: Clean up the deployment options section.

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/761 ---

[GitHub] samza pull request #761: Clean up the deployment options section.

2018-10-24 Thread vjagadish1989
GitHub user vjagadish1989 opened a pull request: https://github.com/apache/samza/pull/761 Clean up the deployment options section. - Reword for consistency, style, tone You can merge this pull request into a Git repository by running: $ git pull https://github.com/vjagadish1989

[GitHub] samza pull request #760: Javadoc cleanup for new Application, Descriptor, Co...

2018-10-24 Thread prateekm
GitHub user prateekm opened a pull request: https://github.com/apache/samza/pull/760 Javadoc cleanup for new Application, Descriptor, Context and Table APIs - Part 2 Currently, we don't allow imports for use only in javadocs. This requires using FQNs in link tags, which is not very

Re: [VOTE] Apache Samza 1.0.0 RC2

2018-10-24 Thread Prateek Maheshwari
Hi Jagadish, PR 755 is mis-titled. Its only adding back the tests for the old consumer. The old consumer was already added back in https://github.com/apache/samza/pull/740. Thanks, Prateek On Wed, Oct 24, 2018 at 12:02 AM Jagadish Venkatraman wrote: > > Boris, > > Do users have the option to swi

Re: [VOTE] Apache Samza 1.0.0 RC2

2018-10-24 Thread Jagadish Venkatraman
Boris, Do users have the option to switch to use the "old" Kafka consumer if they encounter any issue with the "new" consumer?. If not, should we pull in https://github.com/apache/samza/pull/755? It is my understanding that PR-755 adds support for this. Thanks, Jagadish On Tue, Oct 23, 2018 at 2