Re: [DISCUSS] SEP-2: ApplicationRunner Design

2017-06-20 Thread Prateek Maheshwari
1. +1 for not requiring explicit type information unless its unavoidable. This one seems easy to fix, but there are other places we should address too (OutputStream, Window operator). We should probably discuss the Window API separately from this discussion, but to Chris' point: 2. Re: 2 lambdas,

Re: [VOTE] SEP-5: Enable partition expansion of input streams

2017-06-20 Thread xinyu liu
+1 (non-binding) on this design. To me the task-count based groupers should work well in practice for partition expansion of system using hash for partitions, e.g. Kafka. It will not cause any state transfer between hosts so the runtime cost will be minimal. In the future when we support dynamical

Re: [DISCUSS] SEP-2: ApplicationRunner Design

2017-06-20 Thread Chris Pettitt
Feedback for PageViewCounterStreamSpecExample: https://github.com/nickpan47/samza/blob/new-api-v2/samza-core/src/test/java/org/apache/samza/example/PageViewCounterStreamSpecExample.java#L65: When we set up the input we had the message type, but it looks like we are not propagating it via StreamIO

Re: [DISCUSS] SEP-2: ApplicationRunner Design

2017-06-20 Thread Chris Pettitt
Yi, What examples should we be looking at for new-api-v2? 1. samza/samza-core/src/test/java/org/apache/samza/example/PageViewCounterStreamSpecExample.java others? - Chris On Mon, Jun 19, 2017 at 5:29 PM, Yi Pan wrote: > Hi, all, > > Here is the promised code examples for the revised API, and

[GitHub] samza pull request #228: SAMZA-1334: fix pre-condition for ContainerAllocato...

2017-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl