Re: Review Request 53163: SAMZA-901: SamzaAppState re-design for thread safety

2016-10-25 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53163/#review153840 --- samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApp

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-25 Thread Shanthoosh Venkataraman
> On Oct. 25, 2016, 9:31 p.m., Jagadish Venkatraman wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java, > > line 166 > > > > > > JobsClient seems to be a generic class and not really

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-25 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/ --- (Updated Oct. 26, 2016, 12:41 a.m.) Review request for samza. Repository: sam

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-25 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/#review153772 --- samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonit

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-25 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review153770 --- docs/learn/documentation/versioned/rest/resources/tasks.md (line

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-25 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/#review153824 --- Fix it, then Ship it! samza-rest/src/main/java/org/apache/samz

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-25 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review153819 --- I haven't read the previous comments. Hence, I may be repeating th

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-25 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/ --- (Updated Oct. 25, 2016, 8:14 p.m.) Review request for samza. Repository: samz

[DISCUSS] Offset checkpoint notification to the System Consumer

2016-10-25 Thread Boris Shkolnik
Currently we keep track of the progress of each consumer using checkpointing mechanism. These checkpoints are controlled by Samza, and the system consumer is not aware of it. But some systems may require knowledge of the current checkpointed position in the stream. For this purpose we propose an op

Review Request 53163: SAMZA-901: SamzaAppState re-design for thread safety

2016-10-25 Thread Branislav Cogic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53163/ --- Review request for samza and Jagadish Venkatraman. Bugs: SAMZA-901 https://