Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-12 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152418 --- docs/learn/documentation/versioned/rest/resources/tasks.md (line

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-12 Thread Maxim Logvinenko
> On Oct. 12, 2016, 6 p.m., Jagadish Venkatraman wrote: > > Ship It! > > Jagadish Venkatraman wrote: > We'll have to test and validate this feature at LinkedIn (and in the open > source) before we do the Samza release. Sure! Thanks! I also going to test it in our company, but unfortunately

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-12 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Oct. 12, 2016, 10:54 p.m.) Review request for samza. Repository: sam

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-12 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/#review152412 --- samza-rest/src/main/java/org/apache/samza/rest/proxy/task/SamzaTa

Re: [VOTE] Apache Samza 0.11.0 RC2

2016-10-12 Thread Navina Ramesh
Validated MD5 and build. Ran check-all and integration test on Mac. +1 (binding) Thanks! Navina On Tue, Oct 11, 2016 at 1:16 PM, Yi Pan wrote: > Build, validated MD5, test w/ integration tests and passed. Thanks! > > +1 (binding) > > On Mon, Oct 10, 2016 at 4:07 PM, xinyu liu wrote: > > > Hey

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-12 Thread Jagadish Venkatraman
> On Oct. 12, 2016, 6 p.m., Jagadish Venkatraman wrote: > > Ship It! We'll have to test and validate this feature at LinkedIn (and in the open source) before we do the Samza release. - Jagadish --- This is an automatically generated e-

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-12 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51633/#review152360 --- Ship it! Ship It! - Jagadish Venkatraman On Oct. 7, 2016, 12

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-12 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/#review152330 --- More thorough review this time. Feedback below. Also, we should a

Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-12 Thread Jake Maes
> On Oct. 10, 2016, 7:27 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java, > > line 84 > > > > > > Shouldn't this be checked only once in the constructor? > > Shant