[GitHub] samza pull request #17: SAMZA-1033: Remove import-control from checkstyle

2016-10-05 Thread navina
GitHub user navina opened a pull request: https://github.com/apache/samza/pull/17 SAMZA-1033: Remove import-control from checkstyle You can merge this pull request into a Git repository by running: $ git pull https://github.com/navina/samza SAMZA-1033 Alternatively you can re

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-05 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47994/#review151592 --- Ship it! Overall, looks very good. Just a subjective nit on the

Review Request 52570: SAMZA-1025: documentation for hdfs system consumer

2016-10-05 Thread Hai Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/ --- Review request for samza. Bugs: SAMZA-1025 https://issues.apache.org/jira/b

Unit and Integration Testing Samza Tasks

2016-10-05 Thread Jeremiah Adams
Can you guys point me to any resources you have or have come across regarding unit and integration testing Samza jobs? I'm not finding a lot on this topic. Specifically the biggest issue I have is standing up all the dependencies in a CI environment for automated builds. I could do this with do

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-05 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51633/#review151519 --- Overall, the patch looks great! This is exciting given that Samza

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-10-05 Thread Hai Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/ --- (Updated Oct. 5, 2016, 6:16 p.m.) Review request for samza, Yi Pan (Data Infras

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

2016-10-05 Thread Yi Pan
Hi, guys, I found a few issues w/ the current release candidate: - integration test (./bin/integration-tests.sh) is broken due to reference to "0.11.0-SNAPSHOT" version of tgz files in the build directory. samza-test/src/main/python/configs/tests.json needs to be updated w/ official 0.11.0 version

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-05 Thread Yi Pan (Data Infrastructure)
> On Oct. 5, 2016, 12:06 a.m., Jagadish Venkatraman wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java, > > line 29 > > > > > > nit: Probably an IDE thing. We can be more s

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-05 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47994/ --- (Updated Oct. 5, 2016, 7:50 a.m.) Review request for samza, Boris Shkolnik, Chr

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-05 Thread Yi Pan (Data Infrastructure)
> On Oct. 5, 2016, 3:18 a.m., Jagadish Venkatraman wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java, > > line 57 > > > > > > Can't this map be made final? Good point. Fi