[GitHub] samza pull request #11: Fixed typo in run-in-multi-node-yarn.md

2016-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/#review150648 --- Fix it, then Ship it! lgtm +1 .. I think you were planning to a

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Navina Ramesh
> On Sept. 13, 2016, 1:37 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/reader/AvroFileHdfsReader.java, > > line 24 > > > > > > One concern I had w/ this HdfsAvro

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Navina Ramesh
> On Sept. 13, 2016, 12:33 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/HdfsSystemConsumer.java, > > line 101 > > > > > > Better, to avoid the wasteful remote I

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Navina Ramesh
> On Sept. 14, 2016, 6:19 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/reader/MultiFileHdfsReader.java, > > line 59 > > > > > > Not sure what are we doing here?

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/#review150637 --- samza-hdfs/src/main/java/org/apache/samza/system/hdfs/HdfsSystemC

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Hai Lu
> On Sept. 13, 2016, 1:37 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/reader/AvroFileHdfsReader.java, > > line 24 > > > > > > One concern I had w/ this HdfsAvro

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Hai Lu
> On Sept. 13, 2016, 12:33 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/HdfsSystemConsumer.java, > > line 101 > > > > > > Better, to avoid the wasteful remote I

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Navina Ramesh
> On Sept. 13, 2016, 12:33 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/HdfsSystemConsumer.java, > > line 101 > > > > > > Better, to avoid the wasteful remote I

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-09-27 Thread Navina Ramesh
> On Sept. 13, 2016, 1:37 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/java/org/apache/samza/system/hdfs/reader/AvroFileHdfsReader.java, > > line 24 > > > > > > One concern I had w/ this HdfsAvro

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-27 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150600 --- Ship it! Ship It! - Jake Maes On Sept. 27, 2016, 6:57 p.m.,

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-27 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/ --- (Updated Sept. 27, 2016, 6:57 p.m.) Review request for samza, Boris Shkolnik, J

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-27 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150574 --- samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorServ

Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.

2016-09-27 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51703/#review150571 --- samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.j