Re: Review Request 51126: SAMZA 998: Documentation updates for refactored Job Coordinator

2016-09-16 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51126/ --- (Updated Sept. 16, 2016, 9:45 p.m.) Review request for samza, Jake Maes, Yi Pan

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

2016-09-16 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51962/#review149278 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On Sept. 16

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

2016-09-16 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51962/#review149276 --- Ship it! Finally found time to understand what you were changin

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-16 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review149262 --- Thanks for the detailed write-up! Really helpful document. Please

Re: Issue with consuming non-existent topics in 0.10.1

2016-09-16 Thread Navina Ramesh
Hey Tommy, Yeah. That totally makes sense. Thanks for explaining it. :) Thanks! Navina On Fri, Sep 16, 2016 at 12:12 PM, Tommy Becker wrote: > Hey Navina, > > This was consistently reproducible both locally and in our integration > test environment. We have auto.create.topics.enable on our bro

Re: Issue with consuming non-existent topics in 0.10.1

2016-09-16 Thread Tommy Becker
Hey Navina, This was consistently reproducible both locally and in our integration test environment. We have auto.create.topics.enable on our brokers (or more accurately, we do not have it disabled; it's the default). I did not mean to imply there is a problem with the logic of the change in S

Re: Question about Samza Metrics

2016-09-16 Thread Navina Ramesh
Hi Shuqi, It depends on the type of metric you are looking for. Most counters and gauges are cumulative. Timer is the only metrics that works within a sliding window (if I am not mistaken). What usecase are you trying to solve? Thanks! Navina On Mon, Sep 12, 2016 at 11:50 PM, 舒琦 wrote: > Hi, >

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

2016-09-16 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51962/ --- (Updated Sept. 16, 2016, 5:54 p.m.) Review request for samza, Boris Shkolnik, J

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

2016-09-16 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51962/ --- (Updated Sept. 16, 2016, 5:56 p.m.) Review request for samza, Boris Shkolnik, J

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

2016-09-16 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51962/ --- (Updated Sept. 16, 2016, 5:54 p.m.) Review request for samza, Boris Shkolnik, J

Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

2016-09-16 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51962/ --- Review request for samza, Boris Shkolnik, Jake Maes, and Yi Pan (Data Infrastruc

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-16 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 16, 2016, 5:37 p.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-16 Thread Xinyu Liu
> On Sept. 14, 2016, 12:43 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/api/overview.md, line 44 > > > > > > We need a more concrete example of how to use callback functionality > > here. It is n

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-16 Thread Xinyu Liu
> On Sept. 14, 2016, 12:37 a.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/documentation/versioned/container/event-loop.md, line 28 > > > > > > What about thread-safety among multiple process() operations?

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-16 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 16, 2016, 5:33 p.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-09-16 Thread Yi Pan (Data Infrastructure)
> On Sept. 14, 2016, 7:03 p.m., Chris Pettitt wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java, > > line 53 > > > > > > Minor: you have inline other transform functions below