Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-08-26 Thread Yi Pan (Data Infrastructure)
> On Aug. 26, 2016, 7:34 p.m., Chris Pettitt wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/window/Trigger.java, > > line 28 > > > > > > Definitely not digging the mutable state here. > >

Re: Question on changelog partition mapping

2016-08-26 Thread Yi Pan
Hi, Tommy, It is perfectly fine. Would you please open a JIRA to include this improvement? Thanks! -Yi On Fri, Aug 26, 2016 at 6:11 AM, Tommy Becker wrote: > Hey Yi, > > Apologies for the lateness of my reply. Yeah that makes sense, and we can > certainly implement. Would you consider accepti

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-08-26 Thread Yi Pan (Data Infrastructure)
> On Aug. 26, 2016, 4:01 p.m., Chris Pettitt wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java, > > lines 152-154 > > > > > > It's not obvious why a sink function would produ

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-08-26 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/ --- (Updated Aug. 26, 2016, 8:43 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

2016-08-26 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147015 --- Fix it, then Ship it! samza-api/src/main/java/org/apache/samza

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-08-26 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/#review147014 --- Only skimmed test cases. Let's review the items captured so far an

Re: [DISCUSS] Samza 0.11.0 release

2016-08-26 Thread Yi Pan
Hi, Nicholas, Thank your so much for pointing out the perf degradation. I synced up w/ Jiangjie Qin from our Kafka team and confirmed that we are running 0.10 Kafka brokers w/o the timestamp message format in 0.10. I also took a look at SAMZA-855 patch and it is far from a working state yet. Given

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-08-26 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/#review146983 --- Next meeting. Pick this up from Trigger (watching too much Winnie

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

2016-08-26 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review146982 --- samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-08-26 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/#review146969 --- Breaking for lunch, but don't want to risk losing my comments. Wil

[GitHub] samza pull request #14: Removed setting log4j-console.xml as default

2016-08-26 Thread rvadai
GitHub user rvadai opened a pull request: https://github.com/apache/samza/pull/14 Removed setting log4j-console.xml as default According to the documentation (https://samza.apache.org/learn/documentation/0.10/jobs/logging.html) the `run-class.sh` script should set the default loggi

Re: Question on changelog partition mapping

2016-08-26 Thread Tommy Becker
Hey Yi, Apologies for the lateness of my reply. Yeah that makes sense, and we can certainly implement. Would you consider accepting a PR that makes this change to the standard groupers? It's just strange that the generated partition mappings can vary like this, even for identical inputs. -Tom