Re: Review Request 50527: SAMZA-970: fix integration tests

2016-07-29 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50527/#review144228 --- Ship it! Ship It! - Fred Ji On July 29, 2016, 5:22 p.m., Xin

Re: Review Request 50590: Update jackson version in hello-samza to match samza

2016-07-29 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50590/#review144226 --- Ship it! Ship It! - Fred Ji On July 29, 2016, 12:34 a.m., Xi

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/#review144225 --- docs/_config.yml (line 26)

Re: Review Request 50619: SAMZA-963: add KV storage engine timers to help identify the issues on kv stores and also add unit test

2016-07-29 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50619/#review144219 --- Ship it! LGTM - Jake Maes On July 29, 2016, 10:24 p.m., Fred

Review Request 50619: SAMZA-963: add KV storage engine timers to help identify the issues on kv stores and also add unit test

2016-07-29 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50619/ --- Review request for samza, Chris Pettitt, Jake Maes, and Yi Pan (Data Infrastruct

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Navina Ramesh
> On July 29, 2016, 9:58 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/startup/hello-samza/versioned/index.md, line 30 > > > > > > Before we push out the online doc and after the official 0.10.1 > > released art

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/#review144208 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On July 29,

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/#review144207 --- docs/startup/hello-samza/versioned/index.md

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/ --- (Updated July 29, 2016, 9:37 p.m.) Review request for samza, Jake Maes, Xinyu L

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Yi Pan (Data Infrastructure)
> On July 29, 2016, 9:30 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/_config.yml, line 26 > > > > > > Single quotation marks are mandatory here. Otherwise, the tool we use > > will parse this as a float number

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/#review144204 --- Fix it, then Ship it! lgtm, except the online doc versioning.

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Navina Ramesh
> On July 29, 2016, 9:20 p.m., Jake Maes wrote: > > docs/_config.yml, line 26 > > > > > > This is the only change I'm unclear on. > > > > Does this affect the ".../latest/..." URL in the documentation site?

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Yi Pan (Data Infrastructure)
> On July 29, 2016, 9:20 p.m., Jake Maes wrote: > > docs/_config.yml, line 26 > > > > > > This is the only change I'm unclear on. > > > > Does this affect the ".../latest/..." URL in the documentation site?

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/#review144200 --- docs/_config.yml (line 26)

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Navina Ramesh
> On July 29, 2016, 9:20 p.m., Jake Maes wrote: > > docs/_config.yml, line 26 > > > > > > This is the only change I'm unclear on. > > > > Does this affect the ".../latest/..." URL in the documentation site?

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/#review144198 --- Fix it, then Ship it! docs/_config.yml (line 26)

Re: Review Request 50614: SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release

2016-07-29 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/ --- (Updated July 29, 2016, 9:04 p.m.) Review request for samza, Jake Maes, Xinyu L

Review Request 50614: SAMZA-970 - Problems with integration tests

2016-07-29 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/ --- Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure)

Re: Review Request 50590: Update jackson version in hello-samza to match samza

2016-07-29 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50590/#review144169 --- Ship it! Ship It! - Navina Ramesh On July 29, 2016, 12:34 a.

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated July 29, 2016, 6:58 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
> On July 27, 2016, 9:36 p.m., Navina Ramesh wrote: > > I think it will be simpler if we can just provide architectural overview in > > the website and add a separate tutorial to run it with samza-hello-samza. > > Thanks! > > Jake Maes wrote: > So, do you suggest moving the deployment step

Re: Review Request 50154: SAMZA-976 Samza REST Documentation

2016-07-29 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/ --- (Updated July 29, 2016, 6:53 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50527: SAMZA-970: fix integration tests

2016-07-29 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50527/ --- (Updated July 29, 2016, 5:22 p.m.) Review request for samza and Navina Ramesh.

Re: Samza retries on kafka exception

2016-07-29 Thread Gaurav Agarwal
Thanks Jagdish. I realized that Samza-911 attempted to fix this but was unclear on the reasons for attempting 30 retries from Samza send() method when kafka had already retried enough times. In any case that is much better than 0.9 or 0.10 ! Although, in current master, it appears that the retry l

Re: Samza retries on kafka exception

2016-07-29 Thread Jagadish Venkatraman
Heya Gaurav, Thanks for the diligent observation and walk through. We ran into a similar issue at LinkedIn and addressed it in SAMZA-911. I think the 0.10.1 release had this fix. Thanks Jagdish On Friday, July 29, 2016, Gaurav Agarwal wrote: > More debugging notes and questions: > > In Samza

Re: Samza retries on kafka exception

2016-07-29 Thread Gaurav Agarwal
More debugging notes and questions: In Samza 0.10, the `retries` parameter is honoured and passed to kafka; however, Samza itself retries sending failed the message in case the exception is an instance of RetriableException: ``` class KafkaSystemProducer (exception, loop) => { if(exception != n

Re: Samza retries on kafka exception

2016-07-29 Thread Gaurav Agarwal
(correction: we are using samza 0.9.0) On Fri, Jul 29, 2016 at 12:09 PM, Gaurav Agarwal wrote: > Hi All, > > We are using Samza (0.10.0) in our system and recently ran into a problem > where due to Kafka broker being unstable for few moments, our samza tasks > while trying to write message to ka