Samza retries on kafka exception

2016-07-28 Thread Gaurav Agarwal
Hi All, We are using Samza (0.10.0) in our system and recently ran into a problem where due to Kafka broker being unstable for few moments, our samza tasks while trying to write message to kafka got exceptions. After that moment, they went into a very long retry loop (Integer.MAX times). The repe

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Navina Ramesh
> On July 28, 2016, 8:37 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/util/Logging.scala, line 30 > > > > > > what happens if a logger by name "startupLoggerName" is not defined? > > Jake

Re: Review Request 50588: SAMZA-982: Add null check for offset update in OffsetManager

2016-07-28 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50588/#review144045 --- Ship it! Ship It! - Jake Maes On July 29, 2016, 12:13 a.m.,

Review Request 50590: Update jackson version in hello-samza to match samza

2016-07-28 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50590/ --- Review request for samza, Jake Maes, Navina Ramesh, and Yi Pan (Data Infrastruct

Review Request 50588: SAMZA-982: Add null check for offset update in OffsetManager

2016-07-28 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50588/ --- Review request for samza. Repository: samza Description --- During the p

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

2016-07-28 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50451/#review144018 --- Ship it! +1. I would recommend to add the reason for this chang

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

2016-07-28 Thread Yi Pan (Data Infrastructure)
> On July 26, 2016, 10:39 p.m., Boris Shkolnik wrote: > > Are we sure that noone will try to upgraded from a version before migration > > to version 11 directly? We never test upgrading a version from 0.9 to 0.11 for all the changes. Even we keep this code around, the confidence of upgrading d

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
> On July 28, 2016, 8:37 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/util/Logging.scala, line 30 > > > > > > what happens if a logger by name "startupLoggerName" is not defined? It still

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
> On July 28, 2016, 8:42 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/util/Logging.scala, line 32 > > > > > > Nit: this method does info log which is not very straghtforward from > > the name

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review144003 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On July 28,

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review143998 --- Ship it! One minor suggestion below. samza-core/src/main/scal

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/ --- (Updated July 28, 2016, 8:41 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/#review143994 --- samza-core/src/main/scala/org/apache/samza/util/Logging.scala (li

Review Request 50583: SAMZA-954 Improve logging for Samza

2016-07-28 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50583/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Nav

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-07-28 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review143972 --- Ship it! Looks like this covers my comments. However, the docum