Review Request 50056: Multithreading changes

2016-07-14 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50056/ --- Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrast

Re: Review Request 48356: RFC: Samza as a library

2016-07-14 Thread Yi Pan (Data Infrastructure)
> On June 27, 2016, 6:53 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/standalone/StandaloneJobCoordinator.java, > > lines 92-94 > > > > > > How is this used? It seems to be write only? >

Re: Review Request 48356: RFC: Samza as a library

2016-07-14 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48356/#review142183 --- Thanks for pulling it off! I did the first round of review. If the

Re: Review Request 48356: RFC: Samza as a library

2016-07-14 Thread Yi Pan (Data Infrastructure)
> On June 27, 2016, 6:53 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/standalone/StandaloneJobCoordinator.java, > > line 44 > > > > > > If this is write-once I would move this to the const