Re: Review Request 48109: SAMZA-957 Avoid unnecessary KV Store flushes (part 3)

2016-06-02 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48109/#review136036 --- Ship it! lgtm. Thanks! - Yi Pan (Data Infrastructure) On Jun

Re: Review Request 48080: SAMZA-956: Disk Quotas: Add throttler and disk quota enforcement

2016-06-02 Thread Chris Pettitt
> On June 2, 2016, 6:24 p.m., Jake Maes wrote: > > The code is super clean and well tested! > > > > Mostly conceptual questions below. > > > > Also, I think we need an entry in the config table for the new configs: > > docs/learn/documentation/versioned/jobs/configuration-table.html Thanks J

Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-02 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/ --- Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrast

Re: Review Request 48080: SAMZA-956: Disk Quotas: Add throttler and disk quota enforcement

2016-06-02 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48080/#review135892 --- The code is super clean and well tested! Mostly conceptual quest