Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

> On April 19, 2016, 12:37 a.m., Vishal Kuo wrote: > > Ship It! This was accidental - Vishal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129458 --

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129603 --- Ship it! Lgtm! Thanks! - Boris Shkolnik On April 19, 2016, 7

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

> On April 19, 2016, 6:23 p.m., Boris Shkolnik wrote: > > bin/grid, line 165 > > > > > > just wondering - why -w 2? -w 1 should work as well? If the port is not > > open it will return right away, will it? Sorry ab

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/ --- (Updated April 19, 2016, 7:39 p.m.) Review request for samza. Changes ---

Re: Review Request 44920: SAMZA-680 Refactor the Samza AppMaster to support other cluster managers

On April 19, 2016, 1:20 a.m., Jagadish Venkatraman wrote: > > Mostly cosmetic comments. I couldn't look into it exhaustively as this is a > > lot of files. I would expect that these will eventually be fixed before > > merging into master. There were hundreds of instances where variable names/c

Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46303/#review129584 --- bin/grid (line 41)

Re: Review Request 46296: SAMZA-932: JMX port collisions in JmxServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46296/#review129582 --- samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scal