Re: Review Request 45144: SAMZA-906 Host Affinity - Minimize task reassignment when container count changes

2016-03-24 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45144/ --- (Updated March 25, 2016, 2:47 a.m.) Review request for samza, Navina Ramesh, Ja

Re: Review Request 45144: SAMZA-906 Host Affinity - Minimize task reassignment when container count changes

2016-03-24 Thread Jake Maes
> On March 24, 2016, 11:13 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/container/grouper/task/GroupByContainerCount.java, > > line 227 > > > > > > What if taskNamesToAssig

Re: Review Request 45144: SAMZA-906 Host Affinity - Minimize task reassignment when container count changes

2016-03-24 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45144/ --- (Updated March 25, 2016, 2:36 a.m.) Review request for samza, Navina Ramesh, Ja

Re: Review Request 45144: SAMZA-906 Host Affinity - Minimize task reassignment when container count changes

2016-03-24 Thread Jake Maes
> On March 24, 2016, 11:13 p.m., Yi Pan (Data Infrastructure) wrote: > > Thanks for catching these. Patch coming as soon as the unit tests are done. > On March 24, 2016, 11:13 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/Se

Re: Review Request 45324: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-03-24 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45324/ --- (Updated March 24, 2016, 11:14 p.m.) Review request for samza. Bugs: SAMZA-91

Review Request 45324: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-03-24 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45324/ --- Review request for samza. Repository: samza Description --- SAMZA-914: I

Re: Review Request 45144: SAMZA-906 Host Affinity - Minimize task reassignment when container count changes

2016-03-24 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45144/#review125157 --- samza-core/src/main/java/org/apache/samza/container/grouper/task/

Re: Review Request 44920: SAMZA-881

2016-03-24 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44920/ --- (Updated March 24, 2016, 9:41 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 45144: SAMZA-906 Host Affinity - Minimize task reassignment when container count changes

2016-03-24 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45144/ --- (Updated March 24, 2016, 9:33 p.m.) Review request for samza, Navina Ramesh, Ja

Re: Review Request 44920: Remove tight coupling of Samza with Yarn. Define APIs for resource manager integration

2016-03-24 Thread Jagadish Venkatraman
> On March 16, 2016, 11:10 p.m., Chris Pettitt wrote: > > Some more comments > > Chris Pettitt wrote: > Sorry, did not mean to create issues for all of the below. I think #1 and > #2 are the most interesting to look at of the group. I did not want to loose comments, So, I'm publishing them

Re: Review Request 44920: Remove tight coupling of Samza with Yarn. Define APIs for resource manager integration

2016-03-24 Thread Jagadish Venkatraman
> On March 16, 2016, 8:48 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java, > > line 78 > > > > > > final :). > > > > Given that you're

Re: Review Request 44920: Remove tight coupling of Samza with Yarn. Define APIs for resource manager integration

2016-03-24 Thread Jagadish Venkatraman
> On March 16, 2016, 7:27 p.m., Jake Maes wrote: > > I had a few minutes, so here's some low-hanging fruit. I've standardized names in most cases to refer to "resource" instead of "container". However, I've kept some class names like ContainerAllocator, ContainerRequestState. The reason for th

Re: Review Request 45136: SAMZA-905 Host Affinity - State restore doesn't work if the previous shutdown was uncontrolled

2016-03-24 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45136/#review125332 --- Ship it! Sorry for the late review. Changes look good. +1 - Na

Re: Review Request 45144: SAMZA-906 Host Affinity - Minimize task reassignment when container count changes

2016-03-24 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45144/ --- (Updated March 24, 2016, 3:58 p.m.) Review request for samza, Navina Ramesh, Ja