Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-08-20 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/#review96013 --- Ship it! I am fine if we are not adding the isBroadcast flag. We ca

Re: Review Request 37536: SAMZA-710 Update WebServlet and RestServlet to read coordinatorStream information

2015-08-20 Thread Navina Ramesh
> On Aug. 20, 2015, 5:36 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/container/ConfigManager.java, > > line 29 > > > > > > How about renaming to LatestConfigManager? Then it is more specific a

Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME

2015-08-20 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37528/#review96004 --- LGTM. Just one nit. Thanks! samza-kafka/src/test/scala/org/apache/

Re: [Discuss/Vote] upgrade to Yarn 2.6.0

2015-08-20 Thread Yi Pan
Hi, Selina, Samza 0.9.1 on YARN 2.6 is the proved working solution. Best, -Yi On Thu, Aug 20, 2015 at 12:28 PM, Selina Tech wrote: > Hi, Yi: > If I use Samza0.9.1 and Yarn2.6.0, Will the system be failed? > > Sincerely, > Selina > > On Wed, Aug 19, 2015 at 1:58 PM, Yi Pan wrote: > > > H

Re: Review Request 34974: SAMZA-676: implement broadcast stream

2015-08-20 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34974/ --- (Updated Aug. 20, 2015, 8:13 p.m.) Review request for samza. Changes ---

Re: [Discuss/Vote] upgrade to Yarn 2.6.0

2015-08-20 Thread Selina Tech
Hi, Yi: If I use Samza0.9.1 and Yarn2.6.0, Will the system be failed? Sincerely, Selina On Wed, Aug 19, 2015 at 1:58 PM, Yi Pan wrote: > Hi, Roger, > > In LinkedIn we have already moved to YARN 2.6 and is moving to YARN 2.7 > now. I am not aware of any major issues in upgrading. I will let

Re: Review Request 37536: SAMZA-710 Update WebServlet and RestServlet to read coordinatorStream information

2015-08-20 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37536/#review95965 --- can you also tested this patch? It does not start the LatestConfigMa

Re: Review Request 37642: SAMZA-695 Update the StreamAppender doc

2015-08-20 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37642/#review95964 --- docs/learn/documentation/versioned/jobs/logging.md (line 100)

Review Request 37642: SAMZA-695 Update the StreamAppender doc

2015-08-20 Thread Aleksandar Pejakovic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37642/ --- Review request for samza. Repository: samza Description --- Added reques

Re: Review Request 37536: SAMZA-710 Update WebServlet and RestServlet to read coordinatorStream information

2015-08-20 Thread Aleksandar Bircakovic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37536/ --- (Updated Aug. 20, 2015, 9:19 a.m.) Review request for samza. Changes ---