Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/ --- (Updated July 22, 2015, 4:07 a.m.) Review request for samza. Repository: samz

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 21, 2015, 5:42 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala, > > lines 36-37 > > > > > > though it works, prefer to use the "def" here, not only because i

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

> On July 21, 2015, 5:42 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java, line 23 > > > > > > of the class "the" extends -> of the class "that" extends Thanks > On July

Re: Samza and sliding window

Hi, Shekar, I have strip down your use case just to the KV-store operation and have verified that it works fine. Please see the attached diff file. If you have any further questions, please let me know. -Yi On Mon, Jul 20, 2015 at 12:35 PM, Shekar Tippur wrote: > Yi, > > Here is the config: >

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/#review92227 --- Ideally, the job coordinator should act as the config manager. Since

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/#review92429 --- samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java

Review Request 36641: SAMZA-739 Change version of hello-samza in SAMZA tutorials/latest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36641/ --- Review request for samza. Repository: samza Description --- Changed vers