snoopdave opened a new pull request, #121:
URL: https://github.com/apache/roller/pull/121
This PR removes the Maven Plugin that was used to start/stop Derby and
re-introduces some old code that starts Derby via Java and creates the Roller
schema before tests run and stops Derby after they c
snoopdave merged PR #121:
URL: https://github.com/apache/roller/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
dependabot[bot] opened a new pull request, #122:
URL: https://github.com/apache/roller/pull/122
Bumps commons-text from 1.9 to 1.10.0.
[ . Seems a lot of
mbien commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1494635543
you are saying that struts 2.5.30+ is not compatible with the bootstrap
(plugin) version roller uses at the moment? I assumed it might have something
to do with the double evaluation fix which
gregh3269 commented on PR #124:
URL: https://github.com/apache/roller/pull/124#issuecomment-1495450849
Yes. The plugin needs some updates. If you compare branches you can see
what's needed. Relatively simple in comparison to redoing bootstrap.
--
This is an automated message from the
snoopdave merged PR #123:
URL: https://github.com/apache/roller/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
dependabot[bot] commented on PR #122:
URL: https://github.com/apache/roller/pull/122#issuecomment-1571139628
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me
mbien closed pull request #122: Bump commons-text from 1.9 to 1.10.0 in /app
URL: https://github.com/apache/roller/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dependabot[bot] opened a new pull request, #125:
URL: https://github.com/apache/roller/pull/125
Bumps [struts2-core](https://github.com/apache/struts) from 2.5.29 to 2.5.31.
Release notes
Sourced from https://github.com/apache/struts/releases";>struts2-core's
releases.
Strut
dependabot[bot] commented on PR #117:
URL: https://github.com/apache/roller/pull/117#issuecomment-1591925941
Superseded by #125.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
dependabot[bot] closed pull request #117: Bump struts2-core from 2.5.29 to
2.5.30 in /app
URL: https://github.com/apache/roller/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mbien opened a new pull request, #126:
URL: https://github.com/apache/roller/pull/126
Mostly minor dependency updates which should allow roller to run on the
upcoming JDK 21.
The only major update was guice, guice 6.x and 7.x are nearly identical
taken from doc:
> The Guice 6.
snoopdave commented on PR #127:
URL: https://github.com/apache/roller/pull/127#issuecomment-1616180051
Dang! I did not see this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
snoopdave opened a new pull request, #128:
URL: https://github.com/apache/roller/pull/128
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
snoopdave merged PR #127:
URL: https://github.com/apache/roller/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
mbien commented on PR #126:
URL: https://github.com/apache/roller/pull/126#issuecomment-1617021818
@snoopdave thanks for taking a look -> merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mbien merged PR #126:
URL: https://github.com/apache/roller/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org
snoopdave merged PR #128:
URL: https://github.com/apache/roller/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
snoopdave commented on PR #128:
URL: https://github.com/apache/roller/pull/128#issuecomment-1627611638
@mbien thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dependabot[bot] opened a new pull request, #129:
URL: https://github.com/apache/roller/pull/129
Bumps
[spring-security-config](https://github.com/spring-projects/spring-security)
from 5.8.3 to 5.8.5.
Release notes
Sourced from https://github.com/spring-projects/spring-security/rel
snoopdave opened a new pull request, #130:
URL: https://github.com/apache/roller/pull/130
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
snoopdave merged PR #130:
URL: https://github.com/apache/roller/pull/130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
snoopdave opened a new pull request, #131:
URL: https://github.com/apache/roller/pull/131
This PR fixes a regression caused by switching Roller from using the Maven
`btmatthews` `inmemdb` plugin and instead starting Derby by calling the
embedded Derby server API directly (which works when t
snoopdave merged PR #131:
URL: https://github.com/apache/roller/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
mbien commented on PR #131:
URL: https://github.com/apache/roller/pull/131#issuecomment-1741612770
unfortunately this breaks the integration tests :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
snoopdave commented on PR #131:
URL: https://github.com/apache/roller/pull/131#issuecomment-1741629661
Bummer. I'll take another look over the weekend. I thought I had fixed the
IT tests, except for the jdk21 run.
--
This is an automated message from the Apache Git Service.
To respond to
mbien commented on PR #131:
URL: https://github.com/apache/roller/pull/131#issuecomment-1741642924
@snoopdave oh you are right - I looked at the wrong workflow run! All good,
my mistake.
the jdk 21 run is easy to fix. its just the setup action requesting an early
access build - i can
mbien opened a new pull request, #132:
URL: https://github.com/apache/roller/pull/132
this should fix the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
mbien commented on PR #132:
URL: https://github.com/apache/roller/pull/132#issuecomment-1750360937
all green -> merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
mbien merged PR #132:
URL: https://github.com/apache/roller/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org
sig-hugues opened a new pull request, #133:
URL: https://github.com/apache/roller/pull/133
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
sig-hugues closed pull request #133: Feature
URL: https://github.com/apache/roller/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
snoopdave opened a new pull request, #134:
URL: https://github.com/apache/roller/pull/134
Add some input validations and prepare for next release which will be 6.1.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mbien opened a new pull request, #135:
URL: https://github.com/apache/roller/pull/135
- update project dependencies
- selenium tests don't need an external geckodriver anymore
- update setup-java, checkout and upload-artifact github actions
- fixed rawtype compiler warnings in tests
mbien commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477177509
##
app/pom.xml:
##
@@ -264,7 +267,7 @@ limitations under the License.
org.webjars
jquery
-3.6.4
+3.7.1
Review Co
mbien commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477177726
##
.github/workflows/main.yml:
##
@@ -59,7 +59,7 @@ jobs:
- name: Run Integration Tests
run: |
cd it-selenium
- mvn -V -ntp -Dwebdriver.g
snoopdave commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477439660
##
app/pom.xml:
##
@@ -264,7 +267,7 @@ limitations under the License.
org.webjars
jquery
-3.6.4
+3.7.1
Revie
snoopdave commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477439681
##
.github/workflows/main.yml:
##
@@ -59,7 +59,7 @@ jobs:
- name: Run Integration Tests
run: |
cd it-selenium
- mvn -V -ntp -Dwebdriv
mbien commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477447801
##
app/src/main/webapp/WEB-INF/jsps/tiles/head.jsp:
##
@@ -5,7 +5,7 @@ You can override it with your own file via WEB-INF/tiles-def.xml
<%@ include file="/WEB-INF/jsps/ta
mbien commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477447903
##
app/pom.xml:
##
@@ -264,7 +267,7 @@ limitations under the License.
org.webjars
jquery
-3.6.4
+3.7.1
Review Co
snoopdave commented on code in PR #135:
URL: https://github.com/apache/roller/pull/135#discussion_r1477473510
##
app/src/main/webapp/WEB-INF/jsps/tiles/head.jsp:
##
@@ -5,7 +5,7 @@ You can override it with your own file via WEB-INF/tiles-def.xml
<%@ include file="/WEB-INF/jsp
mbien merged PR #135:
URL: https://github.com/apache/roller/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org
mbien commented on code in PR #134:
URL: https://github.com/apache/roller/pull/134#discussion_r1477694217
##
app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java:
##
@@ -188,4 +189,9 @@ public List retrieveBookmarks() throws
WebloggerException {
snoopdave commented on code in PR #134:
URL: https://github.com/apache/roller/pull/134#discussion_r1479181862
##
app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java:
##
@@ -188,4 +189,9 @@ public List retrieveBookmarks() throws
WebloggerException {
snoopdave merged PR #134:
URL: https://github.com/apache/roller/pull/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
Chris9419 closed pull request #136: Your descriptive commit message
URL: https://github.com/apache/roller/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
Chris9419 closed pull request #137: Deployment Automation
URL: https://github.com/apache/roller/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Chris9419 opened a new pull request, #137:
URL: https://github.com/apache/roller/pull/137
### Summary
This pull request adds the following deployment scripts and configurations:
- `Vagrantfile` for setting up the development environment
- `Dockerfile` for containerizing the appli
Pingching55 closed pull request #139: Pingching
URL: https://github.com/apache/roller/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
snoopdave closed pull request #138: Build Automation Enhance
URL: https://github.com/apache/roller/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
mbien commented on code in PR #137:
URL: https://github.com/apache/roller/pull/137#discussion_r1749332782
##
.vagrant/machines/default/virtualbox/private_key:
##
@@ -0,0 +1,27 @@
+-BEGIN RSA PRIVATE KEY-
Review Comment:
agreed, private keys should not be in repos man
snoopdave opened a new pull request, #140:
URL: https://github.com/apache/roller/pull/140
Safer defaults for some Roller settings like trust-users and allow-file
uploads, plus corresponding docs changes.
--
This is an automated message from the Apache Git Service.
To respond to the messag
mbien commented on PR #140:
URL: https://github.com/apache/roller/pull/140#issuecomment-2350348689
@snoopdave I didn't have time to look into this yet, but it looks like the
tests don't like this change. I try to take a look this weekend.
--
This is an automated message from the Apache Gi
mbien commented on PR #140:
URL: https://github.com/apache/roller/pull/140#issuecomment-2350866488
@snoopdave this one property is all what is needed to make the tests happy
again:
```diff
diff --git
a/app/src/test/java/org/apache/roller/weblogger/business/MediaFileTest.java
b/ap
snoopdave commented on PR #140:
URL: https://github.com/apache/roller/pull/140#issuecomment-2351031545
I also made some changes with SaltCache so that we can associated salt's
with authenticated users.
--
This is an automated message from the Apache Git Service.
To respond to the message,
snoopdave closed pull request #137: Deployment Automation
URL: https://github.com/apache/roller/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snoopdave commented on PR #137:
URL: https://github.com/apache/roller/pull/137#issuecomment-2365318820
I don't think this is work that we want to merge into Roller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
snoopdave merged PR #140:
URL: https://github.com/apache/roller/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
snoopdave commented on PR #141:
URL: https://github.com/apache/roller/pull/141#issuecomment-2375396443
ChatGPT 4o summary based on the diff:
# app/pom.xml
asm.version: 9.6 -> 9.7
commons-validator.version: 1.8.0 -> 1.9.0
commons-codec.version: 1.16.0 -> 1.17.1
commons-text.
mbien merged PR #141:
URL: https://github.com/apache/roller/pull/141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org
mbien opened a new pull request, #141:
URL: https://github.com/apache/roller/pull/141
- asm, spring, lucene, logging, apache commons libs
- webjars: jquery and jquery-validation
- build: junit, selenium and other maven plugins
note: spring closed
[CVE-2024-38816](https://www.
nahsra closed pull request #144: Add another calendar tag
URL: https://github.com/apache/roller/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nahsra opened a new pull request, #144:
URL: https://github.com/apache/roller/pull/144
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nahsra closed pull request #143: Introduce-xss
URL: https://github.com/apache/roller/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
snoopdave commented on PR #149:
URL: https://github.com/apache/roller/pull/149#issuecomment-2646648031
@mbien are we good to merge this? I'd like to get it into 6.1.5 rc1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mbien commented on PR #149:
URL: https://github.com/apache/roller/pull/149#issuecomment-2646738311
@snoopdave Should be fine - although I haven't deployed it this time around
for manually testing. JQuery update is always a bit risky since it probably
doesn't have any test coverage. Rest sho
mbien merged PR #149:
URL: https://github.com/apache/roller/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org
mbien commented on PR #149:
URL: https://github.com/apache/roller/pull/149#issuecomment-2629341514
updated, everything passes on JDK 24 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mbien commented on PR #149:
URL: https://github.com/apache/roller/pull/149#issuecomment-2629290701
> I don't know what you mean about the Mokito thing: "this should resolve
itself automatically"?
Hi @snoopdave! At some point mockito will release a new version which will
bump its depe
mbien commented on PR #149:
URL: https://github.com/apache/roller/pull/149#issuecomment-2629292651
```
mvn eu.maveniverse.maven.plugins:toolbox:gav-tree
-Dgav=org.mockito:mockito-core:5.14.1
[INFO] --- toolbox:0.6.1:gav-tree (default-cli) @ standalone-pom ---
[INFO] org.mockito:mock
mbien opened a new pull request, #149:
URL: https://github.com/apache/roller/pull/149
- only point releases
- selenium tests pass on JDK 24
- unit tests would pass on JDK 24 if bytebuddy would be bumped (not done
since transitive mockito dependency, this should resolve itself automa
mbien commented on PR #149:
URL: https://github.com/apache/roller/pull/149#issuecomment-2629336436
@snoopdave oops i didn't realize that there is already a newer mockito
available - will update this PR
--
This is an automated message from the Apache Git Service.
To respond to the message,
snoopdave commented on PR #149:
URL: https://github.com/apache/roller/pull/149#issuecomment-2629123082
Thanks @mbien! This looks good. I don't know what you mean about the Mokito
thin: "this should resolve itself automatically"?
--
This is an automated message from the Apache Git Service.
snoopdave merged PR #148:
URL: https://github.com/apache/roller/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@roller.apache.o
loganaden opened a new pull request, #145:
URL: https://github.com/apache/roller/pull/145
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
snoopdave commented on PR #147:
URL: https://github.com/apache/roller/pull/147#issuecomment-2603132182
I think this PR has gotten too complicated at I should revert it back to the
first commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
snoopdave closed pull request #147: Roller session improvements
URL: https://github.com/apache/roller/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
snoopdave opened a new pull request, #148:
URL: https://github.com/apache/roller/pull/148
This PR enhances session security by properly invalidating user sessions
when administrators change user attributes.
Key Changes
* Added RollerSessionManager to track and invalidate sessions
snoopdave commented on PR #147:
URL: https://github.com/apache/roller/pull/147#issuecomment-2603268117
This PR works and might be considered an improvement, but I think this one
is a better fix because it involves less changes:
https://github.com/apache/roller/pull/148
--
This is an auto
snoopdave commented on code in PR #148:
URL: https://github.com/apache/roller/pull/148#discussion_r1929885587
##
app/src/main/java/org/apache/roller/weblogger/util/cache/CacheHandlerAdapter.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mbien commented on code in PR #148:
URL: https://github.com/apache/roller/pull/148#discussion_r1929879312
##
app/src/main/java/org/apache/roller/weblogger/util/cache/CacheHandlerAdapter.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
bd-hugues opened a new pull request, #146:
URL: https://github.com/apache/roller/pull/146
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
bd-hugues closed pull request #146: Bd hugues patch 1
URL: https://github.com/apache/roller/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev
mbien commented on code in PR #145:
URL: https://github.com/apache/roller/pull/145#discussion_r1910463976
##
app/pom.xml:
##
@@ -58,7 +58,7 @@ limitations under the License.
2.0.16
5.3.39
5.8.14
-2.5.29
+6.4.0
Review Comment:
the
1 - 100 of 104 matches
Mail list logo
