snoopdave commented on issue #24: bugfix ROL-2129
URL: https://github.com/apache/roller/pull/24#issuecomment-466706187
TIL you can change the base of somebody elses PR. Thanks for the
contribution @pdinc-oss
This is an autom
snoopdave merged pull request #24: bugfix ROL-2129
URL: https://github.com/apache/roller/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
shamshad95 commented on issue #14: [ROL-2123] make Roller build and run on Java
11
URL: https://github.com/apache/roller/pull/14#issuecomment-473611612
Update
This is an automated message from the Apache Git Service.
To resp
mbien commented on issue #14: [ROL-2123] make Roller build and run on Java 11
URL: https://github.com/apache/roller/pull/14#issuecomment-486876580
updated most* dependencies which didn't require code changes + added
explicit dependency to ASM to get better control of what version is used.
mbien commented on issue #14: [ROL-2123] make Roller build and run on Java 11
URL: https://github.com/apache/roller/pull/14#issuecomment-487250851
fixed the eclipselink dependency issue. Changed 'eclipselink' artifact to
'org.eclipse.persistence.jpa' + removed old 'javax.persistence' depend
snoopdave commented on issue #14: [ROL-2123] make Roller build and run on Java
11
URL: https://github.com/apache/roller/pull/14#issuecomment-487318276
@mbien awesome, thanks so much! I made the same changes locally and all
tests pass, plus Roller is up and running on Java 11.
Do y
mbien opened a new pull request #25: Java11
URL: https://github.com/apache/roller/pull/25
maven dependency updates for Java11(&12) support. No code changes. Details
in commit log.
This is an automated message from the Apache
mbien commented on issue #14: [ROL-2123] make Roller build and run on Java 11
URL: https://github.com/apache/roller/pull/14#issuecomment-487325097
@snoopdave done: https://github.com/apache/roller/pull/25
(btw I am running roller on a Raspberry Pi 3 on JDK 12 right now - works
great)
snoopdave merged pull request #25: Java11
URL: https://github.com/apache/roller/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kieptimem opened a new pull request #26: Update LICENSE.txt
URL: https://github.com/apache/roller/pull/26
Trần trương phi
kiepti...@gmail.com
This is an automated message from the Apache Git Service.
To respond to the messa
snoopdave opened a new pull request #27: [ROL-2137] Require setting
rememberme.key
URL: https://github.com/apache/roller/pull/27
if you're going to enable remember me then you must set a unqiue key; and
not the well known "springRocks" that was the previous default.
https://issues.a
snoopdave merged pull request #27: [ROL-2137] Require setting rememberme.key
URL: https://github.com/apache/roller/pull/27
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
snoopdave closed pull request #26: Update LICENSE.txt
URL: https://github.com/apache/roller/pull/26
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
snoopdave merged pull request #14: [ROL-2123] make Roller build and run on Java
11
URL: https://github.com/apache/roller/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log
adityasharma7 opened a new pull request #28: Improved: Editor should confirm
user before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/28
On the pages where editors are used, if the user has done some unsaved
changes. Before closing window/tab it should confirm the
snoopdave commented on issue #28: Improved: Editor should confirm user before
leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/28#issuecomment-500155169
Looks good to me.
This is an automated message fro
adityasharma7 commented on issue #28: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/28#issuecomment-500192800
Thanks @snoopdave for the review.
I was just wondering we are already working on bootstrap-ui where Xinha
e
snoopdave commented on issue #28: Improved: Editor should confirm user before
leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/28#issuecomment-500207668
@adityasharma7 good point. I think this change should be merged to the
roller-5.2.x branch so that it is included i
adityasharma7 opened a new pull request #29: Fixed: NOTICE file does not have
standard content (ROL-2138)
URL: https://github.com/apache/roller/pull/29
1. Rearranged the content as per the standard for Notice and License files
2. Removed credits from Notice file
adityasharma7 opened a new pull request #30: Improved: Editor should confirm
user before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/30
This is an automated message from the Apache Git Service.
To
adityasharma7 commented on issue #28: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/28#issuecomment-501543429
I have already created a separate PR for 5.2.x
https://github.com/apache/roller/pull/30 and will create a new o
adityasharma7 closed pull request #28: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/28
This is an automated message from the Apache Git Service.
To respon
adityasharma7 merged pull request #30: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/30
This is an automated message from the Apache Git Service.
To respon
snoopdave merged pull request #22: Struts Bootstrap based web UI
URL: https://github.com/apache/roller/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
snoopdave commented on issue #29: Fixed: NOTICE file does not have standard
content (ROL-2138)
URL: https://github.com/apache/roller/pull/29#issuecomment-502391411
Looks good to me. Please merge when ready.
This is an automat
adityasharma7 opened a new pull request #31: Fixed: NOTICE file does not have
standard content (ROL-2138)
URL: https://github.com/apache/roller/pull/31
This is an automated message from the Apache Git Service.
To respond to
adityasharma7 merged pull request #31: Fixed: NOTICE file does not have
standard content (ROL-2138)
URL: https://github.com/apache/roller/pull/31
This is an automated message from the Apache Git Service.
To respond to the me
adityasharma7 merged pull request #29: Fixed: NOTICE file does not have
standard content (ROL-2138)
URL: https://github.com/apache/roller/pull/29
This is an automated message from the Apache Git Service.
To respond to the me
adityasharma7 opened a new pull request #32: Revert "Improved: Editor should
confirm user before leaving the page (ROL-2136)"
URL: https://github.com/apache/roller/pull/32
Reverts apache/roller#30
This is an automated message
adityasharma7 merged pull request #32: Revert "Improved: Editor should confirm
user before leaving the page (ROL-2136)"
URL: https://github.com/apache/roller/pull/32
This is an automated message from the Apache Git Service.
fileme opened a new pull request #33: War file location fix
URL: https://github.com/apache/roller/pull/33
Fix for getting the war file from the right location.
Steps for validation:
```
git clone https://github.com/apache/roller.git
cd roller
docker build -t rollerdocker .
mbien opened a new pull request #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34
Hello!
updated apache lucene from 4.x to 8.1.x which required some code changes.
Since lucene can only read indexes which are not older than 1-2 major versions
(according to t
snoopdave commented on issue #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34#issuecomment-520183088
@mbien Wow this looks great. I will review and hope to merge this week.
This is an automated messa
snoopdave commented on issue #33: War file location fix
URL: https://github.com/apache/roller/pull/33#issuecomment-520183160
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please l
mbien commented on issue #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34#issuecomment-520226421
let me know if you need any changes or a rebase etc
This is an automated message from the Apache Git S
mbien edited a comment on issue #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34#issuecomment-520226421
let me know if you require any changes or a rebase etc
This is an automated message from the Ap
mbien edited a comment on issue #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34#issuecomment-520226421
let me know if you want any changes or a rebase etc
This is an automated message from the Apach
zorrofox opened a new pull request #35: fix global config jsp wrong tag
URL: https://github.com/apache/roller/pull/35
In the
[WEB-INF/jsps/admin/GlobalConfig.jsp](https://github.com/apache/roller/blob/83d8f8bb4ca12e1a1000fcd8e3422de3f046fcb3/app/src/main/webapp/WEB-INF/jsps/admin/GlobalConf
swapnilmmane opened a new pull request #1: [ROL-2148] Improved: Added the
expected links on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/1
Few specific links or text blocks are expected on the project website.
Fixed the issues [1] reported b
adityasharma7 commented on issue #1: [ROL-2148] Improved: Added the expected
links on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/1#issuecomment-521107884
Thanks @swapnilmmane :)
---
adityasharma7 merged pull request #1: [ROL-2148] Improved: Added the expected
links on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/1
This is an automated message from the Apach
swapnilmmane opened a new pull request #2: Improved: Added the expected links
on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/2
Few specific links or text blocks are expected on the project website.
Fixed the issues [1] reported by the Apach
adityasharma7 merged pull request #2: [ROL-2148] Improved: Added the expected
links on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/2
This is an automated message from the Apach
adityasharma7 merged pull request #3: Improved: Add meta description on Roller
website [ROL-2149]
URL: https://github.com/apache/roller-website/pull/3
This is an automated message from the Apache Git Service.
To respond to t
adityasharma7 opened a new pull request #3: Improved: Add meta description on
Roller website [ROL-2149]
URL: https://github.com/apache/roller-website/pull/3
Additional change:
Updated .gitgnore file with .idea/ files generated with intellij ide and
sources/target/ folder with generated
adityasharma7 merged pull request #4: Improved: Add meta description on Roller
website [ROL-2149]
URL: https://github.com/apache/roller-website/pull/4
This is an automated message from the Apache Git Service.
To respond to t
adityasharma7 opened a new pull request #4: Improved: Add meta description on
Roller website [ROL-2149]
URL: https://github.com/apache/roller-website/pull/4
Additional change:
Updated .gitgnore file with .idea/ files generated with intellij ide and
sources/target/ folder with generated
swapnilmmane opened a new pull request #5: [ROL-2148] Improved: Added the
expected Security link on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/5
Fixed the issues [1] reported by the Apache Whimsy's TLP Website Checks tool
on Roller website.
swapnilmmane opened a new pull request #6: [ROL-2148] Improved: Added the
expected Security link on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/6
Fixed the issues [1] reported by the Apache Whimsy's TLP Website Checks tool
on Roller website.
adityasharma7 merged pull request #5: [ROL-2148] Improved: Added the expected
Security link on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/5
This is an automated message from t
adityasharma7 merged pull request #6: [ROL-2148] Improved: Added the expected
Security link on the website as per the Apache guidelines
URL: https://github.com/apache/roller-website/pull/6
This is an automated message from t
zorrofox closed pull request #35: fix global config jsp wrong tag
URL: https://github.com/apache/roller/pull/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zorrofox commented on issue #35: fix global config jsp wrong tag
URL: https://github.com/apache/roller/pull/35#issuecomment-522201985
I found more bugs in this page, and will raise a new PR. Thanks!
This is an automated messag
zorrofox opened a new pull request #36: Fix global config jsp page bugs
URL: https://github.com/apache/roller/pull/36
1. Wrong tags in `site.frontpage.weblog.handle` select `listKey` and
`listValueKey`, this will cause the database store wrong value;
2. For `#pd.type` is `boolean` used w
swapnilmmane opened a new pull request #7: Added the iml file in Git ignore
URL: https://github.com/apache/roller-website/pull/7
Also done minor restructuring in file.
This is an automated message from the Apache Git Service.
swapnilmmane opened a new pull request #8: Added the iml file in Git ignore
URL: https://github.com/apache/roller-website/pull/8
Also done minor restructuring in file.
This is an automated message from the Apache Git Service.
adityasharma7 merged pull request #7: Added the iml file in Git ignore
URL: https://github.com/apache/roller-website/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
adityasharma7 commented on issue #7: Added the iml file in Git ignore
URL: https://github.com/apache/roller-website/pull/7#issuecomment-522243808
Thanks @swapnilmmane :)
This is an automated message from the Apache Git Service
asfgit merged pull request #8: Added the iml file in Git ignore
URL: https://github.com/apache/roller-website/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
snoopdave merged pull request #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
snoopdave commented on issue #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34#issuecomment-522324532
Thanks @mbien!
This is an automated message from the Apache Git Service.
To respond to the message
snoopdave merged pull request #33: War file location fix
URL: https://github.com/apache/roller/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
snoopdave merged pull request #36: Fix global config jsp page bugs
URL: https://github.com/apache/roller/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
adityasharma7 opened a new pull request #37: WIP: Upgrade jQuery to 3.4.1
ROL-2150
URL: https://github.com/apache/roller/pull/37
This is an automated message from the Apache Git Service.
To respond to the message, please lo
snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527117017
This a a good idea to update jQuery and the right way to do it is by
changing the Webjars dependency the Roller app's pom.xml file. This is what is
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527117017
This a a good idea to update jQuery and the right way to do it is by
changing the Webjars dependency the Roller app's `pom.xml` file. This is
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527117017
This a a good idea to update jQuery and the right way to do it is by
changing the Webjars dependency the Roller app's pom.xml file. This is wh
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527117017
This a a good idea to update jQuery and the right way to do it is by
changing the Webjars dependency the Roller app's pom.xml file. This is wh
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527117017
This a a good idea to update jQuery and the right way to do it is by
changing the Webjars dependency the Roller app's `pom.xml` file. This is
adityasharma7 commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527137717
Thanks @snoopdave for the heads up :)
I traced back, Js libraries import using webjars dependencies is available
in master[1] & roller 6[
snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527244134
Yes, I think it would be good to get those changes into 5.2.x as well and
I'd be willing to help out with another 5.2.x release when we're ready. It'
adityasharma7 commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-527431630
Sure Dave :)
This is an automated message from the Apache Git Service.
To respon
swapnilmmane opened a new pull request #38: Added the information for the
latest release
URL: https://github.com/apache/roller/pull/38
Also, fixed typo and done some formatting for properly line break while
rendering the content on https://projects.apache.org/project.html?roller
-
swapnilmmane merged pull request #38: Added the information for the latest
release
URL: https://github.com/apache/roller/pull/38
This is an automated message from the Apache Git Service.
To respond to the message, please log
swapnilmmane opened a new pull request #39: Added the AsciiDoc version of
'Install Guide' documentation
URL: https://github.com/apache/roller/pull/39
This is an automated message from the Apache Git Service.
To respond to th
swapnilmmane merged pull request #39: Added the AsciiDoc version of 'Install
Guide' documentation
URL: https://github.com/apache/roller/pull/39
This is an automated message from the Apache Git Service.
To respond to the mess
adityasharma7 commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37#issuecomment-540671595
Apologies for the delay. I got engaged with some unavoidable priorities.
Following MR contains the following changes:
1. Used web jars for i
adityasharma7 merged pull request #37: Upgrade jQuery to 3.4.1 ROL-2150
URL: https://github.com/apache/roller/pull/37
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
adityasharma7 opened a new pull request #40: Improve alert messages (ROL-2154)
URL: https://github.com/apache/roller/pull/40
1. Add close button
2. Remove bulleted text
3. Autoclose messages after 10 seconds
This is an a
adityasharma7 merged pull request #40: Improve alert messages (ROL-2154)
URL: https://github.com/apache/roller/pull/40
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
adityasharma7 opened a new pull request #41: Improve alert messages (ROL-2154)
URL: https://github.com/apache/roller/pull/41
1. Add close button
2. Remove bulleted text
3. Autoclose messages after 10 seconds
This is an a
adityasharma7 merged pull request #41: Improve alert messages (ROL-2154)
URL: https://github.com/apache/roller/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
adityasharma7 opened a new pull request #42: Improved: Editor should confirm
user before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/42
This is an automated message from the Apache Git Service.
To
adityasharma7 commented on issue #42: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/42#issuecomment-541410146
Need to implement a different solution for the master and 6.0 as it is
having Summernote editor
--
adityasharma7 merged pull request #42: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/42
This is an automated message from the Apache Git Service.
To respon
adityasharma7 opened a new pull request #43: Improved: Editor should confirm
user before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/43
Added custom code to add confimation box for text area which adds an event
handler to beforeunload event if the text area is ch
adityasharma7 merged pull request #43: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/43
This is an automated message from the Apache Git Service.
To respon
adityasharma7 opened a new pull request #44: Improved: Editor should confirm
user before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/44
Added custom code to add confimation box for text area which adds an event
handler to beforeunload event if the text area is ch
adityasharma7 merged pull request #44: Improved: Editor should confirm user
before leaving the page (ROL-2136)
URL: https://github.com/apache/roller/pull/44
This is an automated message from the Apache Git Service.
To respon
adityasharma7 opened a new pull request #45: Fixed: confirmation dialog should
not appear in case of submit button (ROL-2136)
URL: https://github.com/apache/roller/pull/45
This is an automated message from the Apache Git Ser
adityasharma7 merged pull request #45: Fixed: confirmation dialog should not
appear in case of submit button (ROL-2136)
URL: https://github.com/apache/roller/pull/45
This is an automated message from the Apache Git Service.
adityasharma7 opened a new pull request #46: Fixed: Variables should be
declared explicitly in Custom JS code (ROL-2157)
URL: https://github.com/apache/roller/pull/46
Pattern is identified and reported at sonacloud.io as Blocker
JavaScript variable scope can be particularly difficul
isdixit opened a new pull request #47: Improved: Replaced pom.basedir
deprecated property with project.basedir. (ROL-2158)
URL: https://github.com/apache/roller/pull/47
NOTE:
Deprecated features are those that have been retained temporarily for
backward compatibility, but which will eve
isdixit opened a new pull request #48: Improved: Replaced pom.basedir
deprecated property with project.basedir. (ROL-2158)
URL: https://github.com/apache/roller/pull/48
NOTE:
Deprecated features are those that have been retained temporarily for
backward compatibility, but which will eve
adityasharma7 commented on issue #48: Improved: Replaced pom.basedir deprecated
property with project.basedir. (ROL-2158)
URL: https://github.com/apache/roller/pull/48#issuecomment-552744164
Thanks @isdixit!
This is an automa
adityasharma7 merged pull request #48: Improved: Replaced pom.basedir
deprecated property with project.basedir. (ROL-2158)
URL: https://github.com/apache/roller/pull/48
This is an automated message from the Apache Git Servic
adityasharma7 merged pull request #47: Improved: Replaced pom.basedir
deprecated property with project.basedir. (ROL-2158)
URL: https://github.com/apache/roller/pull/47
This is an automated message from the Apache Git Servic
isdixit opened a new pull request #49: Added '@Override' should be used on
overriding and implementing methods.
URL: https://github.com/apache/roller/pull/49
This is an automated message from the Apache Git Service.
To respo
isdixit opened a new pull request #50: Added '@Override' should be used on
overriding and implementing methods.
URL: https://github.com/apache/roller/pull/50
This is an automated message from the Apache Git Service.
To respo
adityasharma7 merged pull request #50: Added '@Override' should be used on
overriding and implementing methods. (ROL-2159)
URL: https://github.com/apache/roller/pull/50
This is an automated message from the Apache Git Servic
1 - 100 of 377 matches
Mail list logo
