Re: [PR] Dependency updates and some compiler warning cleanup in tests [roller]

2024-02-04 Thread via GitHub
snoopdave commented on code in PR #135: URL: https://github.com/apache/roller/pull/135#discussion_r1477439660 ## app/pom.xml: ## @@ -264,7 +267,7 @@ limitations under the License. org.webjars jquery -3.6.4 +3.7.1 Revie

Re: [PR] Dependency updates and some compiler warning cleanup in tests [roller]

2024-02-04 Thread via GitHub
snoopdave commented on code in PR #135: URL: https://github.com/apache/roller/pull/135#discussion_r1477439681 ## .github/workflows/main.yml: ## @@ -59,7 +59,7 @@ jobs: - name: Run Integration Tests run: | cd it-selenium - mvn -V -ntp -Dwebdriv

Re: [PR] Dependency updates and some compiler warning cleanup in tests [roller]

2024-02-04 Thread via GitHub
mbien commented on code in PR #135: URL: https://github.com/apache/roller/pull/135#discussion_r1477447801 ## app/src/main/webapp/WEB-INF/jsps/tiles/head.jsp: ## @@ -5,7 +5,7 @@ You can override it with your own file via WEB-INF/tiles-def.xml <%@ include file="/WEB-INF/jsps/ta

Re: [PR] Dependency updates and some compiler warning cleanup in tests [roller]

2024-02-04 Thread via GitHub
mbien commented on code in PR #135: URL: https://github.com/apache/roller/pull/135#discussion_r1477447903 ## app/pom.xml: ## @@ -264,7 +267,7 @@ limitations under the License. org.webjars jquery -3.6.4 +3.7.1 Review Co

Re: [PR] Dependency updates and some compiler warning cleanup in tests [roller]

2024-02-04 Thread via GitHub
snoopdave commented on code in PR #135: URL: https://github.com/apache/roller/pull/135#discussion_r1477473510 ## app/src/main/webapp/WEB-INF/jsps/tiles/head.jsp: ## @@ -5,7 +5,7 @@ You can override it with your own file via WEB-INF/tiles-def.xml <%@ include file="/WEB-INF/jsp

Re: [PR] Dependency updates and some compiler warning cleanup in tests [roller]

2024-02-04 Thread via GitHub
mbien merged PR #135: URL: https://github.com/apache/roller/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

Re: [PR] Validate tz [roller]

2024-02-04 Thread via GitHub
mbien commented on code in PR #134: URL: https://github.com/apache/roller/pull/134#discussion_r1477694217 ## app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java: ## @@ -188,4 +189,9 @@ public List retrieveBookmarks() throws WebloggerException {