[GitHub] [roller] mbien commented on a change in pull request #84: Improve input validation

2021-06-06 Thread GitBox
mbien commented on a change in pull request #84: URL: https://github.com/apache/roller/pull/84#discussion_r646140410 ## File path: app/src/main/java/org/apache/roller/weblogger/webservices/tagdata/TagDataServlet.java ## @@ -70,36 +72,56 @@ public void doGet( HttpS

[GitHub] [roller] snoopdave commented on pull request #90: Parse referrer URL instead of using string value directly.

2021-06-06 Thread GitBox
snoopdave commented on pull request #90: URL: https://github.com/apache/roller/pull/90#issuecomment-855408372 > LGTM, small remark for your consideration: > > org.apache.commons.validator.routines.UrlValidator might be better since it does not rely on the exception in the program flo

[GitHub] [roller] mbien commented on pull request #90: Parse referrer URL instead of using string value directly.

2021-06-06 Thread GitBox
mbien commented on pull request #90: URL: https://github.com/apache/roller/pull/90#issuecomment-855409962 @snoopdave excellent. LGTM. (the fixed test looks good too, I was wondering if it was only failing on my machine) -- This is an automated message from the Apache Git Service. To resp