[GitHub] [roller] ymaheshwari1 opened a new pull request #89: Improved: tooltip content on the registration form

2021-05-21 Thread GitBox
ymaheshwari1 opened a new pull request #89: URL: https://github.com/apache/roller/pull/89 1. Improved the tooltip content for the screen name in the registration form -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [roller] mbien merged pull request #88: Small performance improvements

2021-05-21 Thread GitBox
mbien merged pull request #88: URL: https://github.com/apache/roller/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contac

[GitHub] [roller] nuzayats commented on pull request #75: Ipbanlist fixes

2021-05-21 Thread GitBox
nuzayats commented on pull request #75: URL: https://github.com/apache/roller/pull/75#issuecomment-846311708 > i don't feel that it adds enough benefits in this particular case, to justify a new test dependency (just for one small junit test). For this one at least it adds some benef

[GitHub] [roller] nuzayats edited a comment on pull request #75: Ipbanlist fixes

2021-05-21 Thread GitBox
nuzayats edited a comment on pull request #75: URL: https://github.com/apache/roller/pull/75#issuecomment-846311708 > i don't feel that it adds enough benefits in this particular case, to justify a new test dependency (just for one small junit test). For this one at least it adds som

[GitHub] [roller] mbien commented on pull request #75: Ipbanlist fixes

2021-05-21 Thread GitBox
mbien commented on pull request #75: URL: https://github.com/apache/roller/pull/75#issuecomment-846322119 > > i don't feel that it adds enough benefits in this particular case, to justify a new test dependency (just for one small junit test). > > For this one at least it adds some be

[GitHub] [roller] nuzayats commented on pull request #75: Ipbanlist fixes

2021-05-21 Thread GitBox
nuzayats commented on pull request #75: URL: https://github.com/apache/roller/pull/75#issuecomment-846327275 Removed AssertJ at 9dca2da . But it sounds like I will have to stick with the basic or outdated assertion APIs in Roller development unless there is a chance to write substant

[GitHub] [roller] mbien commented on pull request #75: Ipbanlist fixes

2021-05-21 Thread GitBox
mbien commented on pull request #75: URL: https://github.com/apache/roller/pull/75#issuecomment-846333744 thanks for understanding. I am not opposed to AssertJ, if we have extensive collection based tests in future we can still add it so we get some proper use out of it. But maybe not for

[GitHub] [roller] mbien merged pull request #75: Ipbanlist fixes

2021-05-21 Thread GitBox
mbien merged pull request #75: URL: https://github.com/apache/roller/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contac