[GitHub] [qpid-proton] ssorj commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

ssorj commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r333151881 ## File path: python/proton/_message.py ## @@ -430,6 +430,31 @@ def _set_reply_to_group_id(s

[GitHub] [qpid-proton] ssorj commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

ssorj commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r333153614 ## File path: python/proton/_message.py ## @@ -440,8 +465,8 @@ def _set_annotations(self, an

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #584: DISPATCH-1443: use python unittest library, fail back to unittest2

kgiusti opened a new pull request #584: DISPATCH-1443: use python unittest library, fail back to unittest2 URL: https://github.com/apache/qpid-dispatch/pull/584 unittest is part of the standard library for Python. unittest in versions of Python prior to 2.7 does not have all the feature

[GitHub] [qpid-dispatch] kgiusti commented on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2

kgiusti commented on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2 URL: https://github.com/apache/qpid-dispatch/pull/584#issuecomment-540119274 WORK IN PROGRESS Do not merge yet. This i

[GitHub] [qpid-jms] gemmellr commented on issue #32: QPIDJMS-441: add proxy support

gemmellr commented on issue #32: QPIDJMS-441: add proxy support URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-540529031 We wouldn't want the JMS layer APIs to be directly dependent on fixed Netty types if we were to add this. There is as general setExtension method on the fa

[GitHub] [qpid-jms] stsiano commented on issue #32: QPIDJMS-441: add proxy support

stsiano commented on issue #32: QPIDJMS-441: add proxy support URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-540538542 Your approach is of course also fine, but it makes using the interface a bit awkward. Furthermore the proxy is not optional with your implementation as you

[GitHub] [qpid-jms] gemmellr commented on issue #32: QPIDJMS-441: add proxy support

gemmellr commented on issue #32: QPIDJMS-441: add proxy support URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-540543820 The ProxyHandler class is not required at runtime with what I did, unless you are using the extension, in which you you need to provide it. I left it using

[GitHub] [qpid-jms] gemmellr edited a comment on issue #32: QPIDJMS-441: add proxy support

gemmellr edited a comment on issue #32: QPIDJMS-441: add proxy support URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-540543820 The ProxyHandler class is not required at runtime with what I did, unless you are using the extension, in which case you need to provide it. I left i

[GitHub] [qpid-dispatch] asfgit closed pull request #583: DISPATCH-1446 - Modified get_test_log in system_tests__qdmanage to no…

asfgit closed pull request #583: DISPATCH-1446 - Modified get_test_log in system_tests__qdmanage to no… URL: https://github.com/apache/qpid-dispatch/pull/583 This is an automated message from the Apache Git Service. To respo

[GitHub] [qpid-dispatch] kgiusti commented on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2

kgiusti commented on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2 URL: https://github.com/apache/qpid-dispatch/pull/584#issuecomment-540697063 Ready for merge This is an automated message fro

[GitHub] [qpid-dispatch] codecov-io commented on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2

codecov-io commented on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2 URL: https://github.com/apache/qpid-dispatch/pull/584#issuecomment-540704624 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/584?src=pr&el=h1) Report > Merging [#584](htt

[GitHub] [qpid-dispatch] asfgit merged pull request #584: DISPATCH-1443: use python unittest library, fail back to unittest2

asfgit merged pull request #584: DISPATCH-1443: use python unittest library, fail back to unittest2 URL: https://github.com/apache/qpid-dispatch/pull/584 This is an automated message from the Apache Git Service. To respond t

[GitHub] [qpid-dispatch] asfgit closed pull request #584: DISPATCH-1443: use python unittest library, fail back to unittest2

asfgit closed pull request #584: DISPATCH-1443: use python unittest library, fail back to unittest2 URL: https://github.com/apache/qpid-dispatch/pull/584 This is an automated message from the Apache Git Service. To respond t

[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2

codecov-io edited a comment on issue #584: DISPATCH-1443: use python unittest library, fail back to unittest2 URL: https://github.com/apache/qpid-dispatch/pull/584#issuecomment-540704624 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/584?src=pr&el=h1) Report > Merging [#5

[GitHub] [qpid-dispatch] nicob87 commented on issue #576: DISPATCH-1441: optparse to argparse migration

nicob87 commented on issue #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-540781042 Thanks Ken, I will work on your comment. This is an automated message

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #585: NO-JIRA: [Doc] Update dir structure and remove obsolete files from qpid user guide

bhardesty opened a new pull request #585: NO-JIRA: [Doc] Update dir structure and remove obsolete files from qpid user guide URL: https://github.com/apache/qpid-dispatch/pull/585 - Rearrange the docs/books/ directory and its subdirectories to make future doc work more efficient - Remove

[GitHub] [qpid-proton] astitcher commented on a change in pull request #194: PROTON-2114:[CMake] Fixing an issue with cmake not compiling c++11 e…

astitcher commented on a change in pull request #194: PROTON-2114:[CMake] Fixing an issue with cmake not compiling c++11 e… URL: https://github.com/apache/qpid-proton/pull/194#discussion_r333759956 ## File path: cpp/examples/CMakeLists.txt ## @@ -56,6 +56,18 @@ if (DEFINED

[GitHub] [qpid-proton] astitcher commented on issue #194: PROTON-2114:[CMake] Fixing an issue with cmake not compiling c++11 e…

astitcher commented on issue #194: PROTON-2114:[CMake] Fixing an issue with cmake not compiling c++11 e… URL: https://github.com/apache/qpid-proton/pull/194#issuecomment-540823827 Please also make sure that you have only a single squashed commit to rebase onto master.

[GitHub] [qpid-proton] jdanekrh opened a new pull request #195: ENTMQCL-1756 fix connect_config parsing tests when jsoncpp < 1.7.0

jdanekrh opened a new pull request #195: ENTMQCL-1756 fix connect_config parsing tests when jsoncpp < 1.7.0 URL: https://github.com/apache/qpid-proton/pull/195 This is an automated message from the Apache Git Service. To res

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #576: DISPATCH-1441: optparse to argparse migration

kgiusti commented on a change in pull request #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#discussion_r333996867 ## File path: tests/CMakeLists.txt ## @@ -75,6 +75,7 @@ add_test(unit_tests${TEST_WRAP}

[GitHub] [qpid-dispatch] kgiusti commented on issue #576: DISPATCH-1441: optparse to argparse migration

kgiusti commented on issue #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-541071743 One other thing: Can you update the top-level README where it describes installing dependencies: https://github.com/apache/qpid

[GitHub] [qpid-proton] astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334040232 ## File path: python/proton/_message.py ## @@ -430,6 +430,31 @@ def _set_reply_to_group_

[GitHub] [qpid-dispatch] ChugR commented on issue #571: DISPATCH-1422: Create global policy denial count

ChugR commented on issue #571: DISPATCH-1422: Create global policy denial count URL: https://github.com/apache/qpid-dispatch/pull/571#issuecomment-541140702 Fixed at commit 69868bf This is an automated message from the Apache

[GitHub] [qpid-dispatch] ChugR closed pull request #571: DISPATCH-1422: Create global policy denial count

ChugR closed pull request #571: DISPATCH-1422: Create global policy denial count URL: https://github.com/apache/qpid-dispatch/pull/571 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [qpid-proton] astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334083036 ## File path: python/proton/_endpoints.py ## @@ -500,6 +500,79 @@ def free(self):

[GitHub] [qpid-proton] astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334080636 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334078205 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334082424 ## File path: python/proton/_endpoints.py ## @@ -500,6 +500,79 @@ def free(self):

[GitHub] [qpid-proton] astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334081186 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

astitcher commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334083559 ## File path: python/proton/_endpoints.py ## @@ -500,6 +500,79 @@ def free(self):

[GitHub] [qpid-proton] astitcher commented on issue #195: PROTON-2118 fix connect_config parsing tests when jsoncpp < 1.7.0

astitcher commented on issue #195: PROTON-2118 fix connect_config parsing tests when jsoncpp < 1.7.0 URL: https://github.com/apache/qpid-proton/pull/195#issuecomment-541146308 Looks good to me. This is an automated message fr

[GitHub] [qpid-proton] astitcher merged pull request #195: PROTON-2118 fix connect_config parsing tests when jsoncpp < 1.7.0

astitcher merged pull request #195: PROTON-2118 fix connect_config parsing tests when jsoncpp < 1.7.0 URL: https://github.com/apache/qpid-proton/pull/195 This is an automated message from the Apache Git Service. To respond t

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

ganeshmurthy opened a new pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586 …stat This is an automated message from the Apache Git

[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

ganeshmurthy commented on issue #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#issuecomment-541184768 Added time in UTC and router id to qdstat options. Earlier, only qdstat --all-entities or qdstat --all-e

[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration

codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1) Report > Merging [#576](https://codecov.i

[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration

codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1) Report > Merging [#576](https://codecov.i

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334489552 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334494101 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334494848 ## File path: python/proton/_endpoints.py ## @@ -500,6 +500,79 @@ def free(self): "

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

gemmellr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334544063 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334645362 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334645165 ## File path: python/proton/_data.py ## @@ -308,6 +308,222 @@ def __eq__(self, o):

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334663626 ## File path: python/proton/_message.py ## @@ -430,6 +430,31 @@ def _set_reply_to_group_id(s

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334663744 ## File path: python/proton/_message.py ## @@ -440,8 +465,8 @@ def _set_annotations(self, an

[GitHub] [qpid-proton] kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo…

kpvdr commented on a change in pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334664152 ## File path: python/proton/_endpoints.py ## @@ -500,6 +500,79 @@ def free(self): "

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335039137 ## File path: tools/qdstat.in ## @@ -667,14 +723,27 @@ class BusManager(No

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335039861 ## File path: tools/qdstat.in ## @@ -687,49 +756,59 @@ class BusManager(No

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335038785 ## File path: tools/qdstat.in ## @@ -602,6 +644,17 @@ class BusManager(Nod

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335038593 ## File path: tools/qdstat.in ## @@ -574,6 +607,14 @@ class BusManager(Nod

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335039472 ## File path: tools/qdstat.in ## @@ -667,14 +723,27 @@ class BusManager(No

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335038195 ## File path: tools/qdstat.in ## @@ -155,7 +155,19 @@ class BusManager(Nod

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335038884 ## File path: tools/qdstat.in ## @@ -602,6 +644,17 @@ class BusManager(Nod

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335039762 ## File path: tools/qdstat.in ## @@ -687,49 +756,59 @@ class BusManager(No

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335038697 ## File path: tools/qdstat.in ## @@ -574,6 +607,14 @@ class BusManager(Nod

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335038294 ## File path: tools/qdstat.in ## @@ -155,7 +155,19 @@ class BusManager(Nod

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335039040 ## File path: tools/qdstat.in ## @@ -667,14 +723,27 @@ class BusManager(No

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

kgiusti commented on a change in pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586#discussion_r335039588 ## File path: tools/qdstat.in ## @@ -687,49 +756,59 @@ class BusManager(No

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …

ganeshmurthy opened a new pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587 …sslProfile's password field This is an automated messa

[GitHub] [qpid-dispatch] codecov-io commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …

codecov-io commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#issuecomment-542705429 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=h1) Report > Merging [#587]

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

ganeshmurthy closed pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586 This is an automated message from the Apache Git Service. To

[GitHub] [qpid-dispatch] asfgit merged pull request #576: DISPATCH-1441: optparse to argparse migration

asfgit merged pull request #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration

codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1) Report > Merging [#576](https://codecov.i

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …

kgiusti commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335551241 ## File path: tests/system_tests_sasl_plain.py ## @@ -22,15 +22,31 @@ fro

[GitHub] [qpid-dispatch] nicob87 closed pull request #588: Pipeline hello world

nicob87 closed pull request #588: Pipeline hello world URL: https://github.com/apache/qpid-dispatch/pull/588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [qpid-dispatch] nicob87 opened a new pull request #588: Pipeline hello world

nicob87 opened a new pull request #588: Pipeline hello world URL: https://github.com/apache/qpid-dispatch/pull/588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

ganeshmurthy opened a new pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589 …stat This is an automated message from the Apache Git

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #566: DISPATCH-1419 - Added connectionStatus and connectionMsg fields to th…

ganeshmurthy closed pull request #566: DISPATCH-1419 - Added connectionStatus and connectionMsg fields to th… URL: https://github.com/apache/qpid-dispatch/pull/566 This is an automated message from the Apache Git Service. To

[GitHub] [qpid-dispatch] codecov-io commented on issue #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

codecov-io commented on issue #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589#issuecomment-542821238 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=h1) Report > Merging [#589]

[GitHub] [qpid-dispatch] ChugR closed pull request #572: DISPATCH-1416: Add policy denial counts to connection close log

ChugR closed pull request #572: DISPATCH-1416: Add policy denial counts to connection close log URL: https://github.com/apache/qpid-dispatch/pull/572 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [qpid-dispatch] ChugR commented on issue #572: DISPATCH-1416: Add policy denial counts to connection close log

ChugR commented on issue #572: DISPATCH-1416: Add policy denial counts to connection close log URL: https://github.com/apache/qpid-dispatch/pull/572#issuecomment-542828692 Merged at commit ff82055e This is an automated messag

[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …

bhardesty commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335640689 ## File path: python/qpid_dispatch/management/qdrouter.json ## @@ -1008,

[GitHub] [qpid-dispatch] bhardesty commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …

bhardesty commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#issuecomment-542833785 In ../docs/books/user-guide/modules/connecting-using-username-password-authentication.adoc, we show an exa

[GitHub] [qpid-proton] kpvdr closed pull request #192: Changed Python API to better handle strings where symbo…

kpvdr closed pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [qpid-proton] kpvdr commented on issue #192: Changed Python API to better handle strings where symbo…

kpvdr commented on issue #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#issuecomment-542843937 Changes squashed and merged. This is an automated message from

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…

ganeshmurthy closed pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589 This is an automated message from the Apache Git Service. To

[GitHub] [qpid-dispatch] jdanekrh commented on issue #459: DISPATCH-1282 - Support for building on macOS

jdanekrh commented on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-542911343 @RoddieKieley I spent some time with the build issues: python interpreter and libs detection, qpid proton python on macos, and unittes

[GitHub] [qpid-dispatch] jdanekrh merged pull request #459: DISPATCH-1282 - Support for building on macOS

jdanekrh merged pull request #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [qpid-dispatch] RoddieKieley commented on issue #459: DISPATCH-1282 - Support for building on macOS

RoddieKieley commented on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-542941865 @jdanekrh Sounds like it's about as good as it can be for the moment. I think the unittest2 issue resolution via a virtual enviro

[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #590: DISPATCH-1384 - fix unit_tests test

jdanekrh opened a new pull request #590: DISPATCH-1384 - fix unit_tests test URL: https://github.com/apache/qpid-dispatch/pull/590 The inlining is not happening on Linux anyways, so disabling it should affect only macOS. I could not think of other way to make tests pass with the inlining,

[GitHub] [qpid-dispatch] jdanekrh commented on issue #590: DISPATCH-1384 - fix unit_tests test

jdanekrh commented on issue #590: DISPATCH-1384 - fix unit_tests test URL: https://github.com/apache/qpid-dispatch/pull/590#issuecomment-543049810 The `-Wl,-flat_namespace` is not in conflict with sanitizers, e.g. the following is running the sanitizer just fine. $ cmake .. -DCMA

[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration

jdanekrh opened a new pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591 The expected Linux error is 2019-10-17 10:14:09.319632 +0200 SERVER (info) [C1] Connection to unresolvable.host.name:amqp f

[GitHub] [qpid-dispatch] jdanekrh commented on issue #590: DISPATCH-1384 - Fix unit_tests

jdanekrh commented on issue #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#issuecomment-543075142 "**79% tests passed**, 13 tests failed out of 61" This is an automated message from

[GitHub] [qpid-dispatch] jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration

jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591#issuecomment-543076154 "**79% tests passed**, 13 tests failed out of 61" Thi

[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build

jdanekrh opened a new pull request #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592 Now easier to do when the `matrix` key is in place in `.travis.yml`. Doing this also fixes the duplicated top leve

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests

kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336044898 ## File path: CMakeLists.txt ## @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang") add_compile_optio

[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests

jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336064713 ## File path: CMakeLists.txt ## @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang") add_compile_opti

[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path

bhardesty commented on a change in pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550#discussion_r336069549 ## File path: python/qpid_dispatch/management/qdrouter.json ##

[GitHub] [qpid-dispatch] jdanekrh commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path

jdanekrh commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550#issuecomment-543229008 @ErnieAllen [~eallen] Afaik updating the doc is last step for DISPATCH-1300 and it can be closed

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests

kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336079605 ## File path: CMakeLists.txt ## @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang") add_compile_optio

[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path

ganeshmurthy commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550#issuecomment-543261498 @jdanekrh please squash the commits into one commit and merge that commit to master. Thanks.

[GitHub] [qpid-dispatch] jdanekrh merged pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path

jdanekrh merged pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550 This is an automated message from the Apache Git Serv

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …

ganeshmurthy closed pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587 This is an automated message from the Apache Git Service. To

[GitHub] [qpid-dispatch] jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build

jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543300086 @ganeshmurthy Is this what you've had in mind? -

[GitHub] [qpid-dispatch] jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration

jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591#issuecomment-543301645 There should not be anything "controversial" about this, and I've checked that the test is capable of failing (always

[GitHub] [qpid-dispatch] jdanekrh merged pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration

jdanekrh merged pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build

ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543328646 @jdanekrh can you please rebase this PR with master and simply add a file with no license so that th

[GitHub] [qpid-dispatch] jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build

jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-54990 Here, https://travis-ci.org/jdanekrh/qpid-dispatch/builds/599323593

[GitHub] [qpid-dispatch] jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build

jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543334656 Ahd the PR here https://github.com/apache/qpid-dispatch/pull/593 ---

[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #593: I am an unlicenced file

jdanekrh opened a new pull request #593: I am an unlicenced file URL: https://github.com/apache/qpid-dispatch/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [qpid-dispatch] jdanekrh edited a comment on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build

jdanekrh edited a comment on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543334656 And the PR here https://github.com/apache/qpid-dispatch/pull/593

<    1   2   3   4   5   6   7   8   9   10   >