[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946138#comment-17946138 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

[jira] [Created] (PROTON-2886) Netty deprecated calls in JDK 24

2025-04-21 Thread Ryan Livingston (Jira)
Ryan Livingston created PROTON-2886: --- Summary: Netty deprecated calls in JDK 24 Key: PROTON-2886 URL: https://issues.apache.org/jira/browse/PROTON-2886 Project: Qpid Proton Issue Type: Bug

[jira] [Updated] (PROTON-2886) Netty deprecated calls in JDK 24

2025-04-21 Thread Ryan Livingston (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Livingston updated PROTON-2886: Description: When running _protonj2-1.0.0-M23_ on JDK 24 the below can be observed. {code:

[jira] [Updated] (PROTON-2886) Netty deprecated calls in JDK 24

2025-04-21 Thread Ryan Livingston (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Livingston updated PROTON-2886: Description: When running _protonj2-1.0.0-M23_ on JDK 24 the below can be observed. {code:

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-21 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2052363669 ## cpp/include/proton/container.hpp: ## @@ -326,6 +326,7 @@ class PN_CPP_CLASS_EXTERN container { friend class receiver_options; friend class sender_options;

[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946118#comment-17946118 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-21 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2052365621 ## cpp/include/proton/fwd.hpp: ## @@ -52,9 +52,12 @@ class sender_options; class session; class session_options; class source_options; +class coordinator_option

[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946126#comment-17946126 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-21 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2052373958 ## cpp/include/proton/fwd.hpp: ## @@ -52,9 +52,12 @@ class sender_options; class session; class session_options; class source_options; +class coordinator_option

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-21 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2052374986 ## cpp/include/proton/sender_options.hpp: ## @@ -94,6 +94,9 @@ class sender_options { /// Options for the receiver node of the receiver. PN_CPP_EXTERN se

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-21 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2052391616 ## cpp/src/proton_bits.hpp: ## @@ -111,6 +119,9 @@ template <> struct wrapper { typedef connection type; }; template <> struct wrapper { typedef session type; };

[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946131#comment-17946131 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946130#comment-17946130 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-21 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2052391377 ## cpp/src/proton_bits.hpp: ## @@ -98,11 +102,15 @@ template <> struct wrapped { typedef pn_link_t type; }; template <> struct wrapped { typedef pn_link_t type;

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-21 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2052420969 ## cpp/examples/tx_send.cpp: ## @@ -0,0 +1,172 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

[jira] [Updated] (PROTON-2886) Netty deprecated calls in JDK 24

2025-04-21 Thread Ryan Livingston (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Livingston updated PROTON-2886: Description: When running _protonj2-1.0.0-M23_ on JDK 24 the below can be observed. Looks

[jira] [Closed] (PROTON-2886) Netty deprecated calls in JDK 24

2025-04-21 Thread Timothy A. Bish (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish closed PROTON-2886. --- Resolution: Not A Bug This is a netty issue outside the control of protonj2.  Normal updates