[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946036#comment-17946036 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-20 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2051952096 ## cpp/include/proton/sender_options.hpp: ## @@ -94,6 +94,9 @@ class sender_options { /// Options for the receiver node of the receiver. PN_CPP_EXTERN se

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-20 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2051966114 ## cpp/include/proton/terminus.hpp: ## @@ -122,6 +122,7 @@ class terminus { friend class internal::factory; friend class source; friend class target; + f

[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946038#comment-17946038 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946044#comment-17946044 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-20 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2051975943 ## cpp/src/node_options.cpp: ## @@ -175,6 +176,9 @@ class target_options::impl { get(dynamic_properties.value, target_map); value(pn_term

Re: [PR] PROTON-1442: [Cpp] Support for local transactions [qpid-proton]

2025-04-20 Thread via GitHub
DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2051975814 ## cpp/src/node_options.cpp: ## @@ -162,6 +162,7 @@ class target_options::impl { option expiry_policy; option > capabilities; option dynamic_propert

[jira] [Commented] (PROTON-1442) [c++] Support for transactions

2025-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946043#comment-17946043 ] ASF GitHub Bot commented on PROTON-1442: DreamPearl commented on code in PR #437