Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-06 Thread via GitHub
cliffjansen commented on code in PR #427: URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1591273502 ## c/src/proactor/epoll.c: ## @@ -1139,6 +1141,21 @@ static pn_event_batch_t *pconnection_process(pconnection_t *pc, uint32_t events, } if (sched_ready) sc

[jira] [Commented] (PROTON-2818) Move epoll proctor connection logic to a task thread

2024-05-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843788#comment-17843788 ] ASF GitHub Bot commented on PROTON-2818: cliffjansen commented on code in PR #42

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-06 Thread via GitHub
cliffjansen commented on code in PR #427: URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1591276038 ## c/src/proactor/epoll_raw_connection.c: ## @@ -413,6 +422,19 @@ pn_event_batch_t *pni_raw_connection_process(task_t *t, uint32_t io_events, bool } if

[jira] [Commented] (PROTON-2818) Move epoll proctor connection logic to a task thread

2024-05-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843789#comment-17843789 ] ASF GitHub Bot commented on PROTON-2818: cliffjansen commented on code in PR #42

Re: [PR] PROTON-2818: Move epoll proctor connection logic to a task thread. [qpid-proton]

2024-05-06 Thread via GitHub
astitcher commented on PR #427: URL: https://github.com/apache/qpid-proton/pull/427#issuecomment-2096662896 @cliffjansen Thanks for these changes - this is definitely clearer than the original change. I'd still love a clearer lifecycle state machine but this will do for now. -- This is

[jira] [Commented] (PROTON-2818) Move epoll proctor connection logic to a task thread

2024-05-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843828#comment-17843828 ] ASF GitHub Bot commented on PROTON-2818: astitcher commented on PR #427: URL: ht