Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563846762 ## python/proton/_events.py: ## @@ -57,7 +57,6 @@ def more(self) -> bool: return pn_collector_more(self._impl) def pop(self) -> None: -ev =

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836781#comment-17836781 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563849367 ## python/proton/_handlers.py: ## @@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable: Selectable, now: float) -> None: try:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563849060 ## python/proton/_handlers.py: ## @@ -1305,15 +1305,15 @@ def update(transport: Transport, selectable: Selectable, now: float) -> None: try:

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836782#comment-17836782 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836783#comment-17836783 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on PR #423: URL: https://github.com/apache/qpid-proton/pull/423#issuecomment-2053603777 Tried a Python compatibility check in IntelliJ, and got ![image](https://github.com/apache/qpid-proton/assets/442720/70d2f412-142e-46a4-95ba-9682a95c0d5c) https://github

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836799#comment-17836799 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on PR #423: URL: ht

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836801#comment-17836801 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563936489 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the li

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836802#comment-17836802 ] ASF GitHub Bot commented on PROTON-2322: jiridanek commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
jiridanek commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1563938118 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the li

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
astitcher commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1564414072 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the li

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836875#comment-17836875 ] ASF GitHub Bot commented on PROTON-2322: astitcher commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
astitcher commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1564414963 ## python/setup.cfg: ## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the li

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836877#comment-17836877 ] ASF GitHub Bot commented on PROTON-2322: astitcher commented on code in PR #423:

Re: [PR] PROTON-2322/PROTON-2813: [Python] Finish PEP8 sanitization [qpid-proton]

2024-04-13 Thread via GitHub
astitcher commented on PR #423: URL: https://github.com/apache/qpid-proton/pull/423#issuecomment-2053879215 > python 3.13 will be removing the `cgi` module from the standard library, so it needs to be removed from proton examples eventually > > https://docs.python.org/3.13/whatsnew/3.

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

2024-04-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836878#comment-17836878 ] ASF GitHub Bot commented on PROTON-2322: astitcher commented on PR #423: URL: ht