[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124696188 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124696188 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124696118 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124696118 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124693703 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124691897 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124693703 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124691897 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,78 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

Podling Report Reminder - July 2017

2017-06-28 Thread johndament
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 19 July 2017, 10:30 am PDT. The report for your podling will form a

[GitHub] incubator-pulsar pull request #539: C++ unit tests in less than a minute

2017-06-28 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/539#discussion_r124690695 --- Diff: pulsar-client-cpp/tests/BasicEndToEndTest.cc --- @@ -578,8 +578,13 @@ TEST(BasicEndToEndTest, testSinglePartitionRoutingPolicy)

[GitHub] incubator-pulsar pull request #539: C++ unit tests in less than a minute

2017-06-28 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/539#discussion_r124690695 --- Diff: pulsar-client-cpp/tests/BasicEndToEndTest.cc --- @@ -578,8 +578,13 @@ TEST(BasicEndToEndTest, testSinglePartitionRoutingPolicy)

[GitHub] incubator-pulsar pull request #539: C++ unit tests in less than a minute

2017-06-28 Thread jai1
GitHub user jai1 opened a pull request: https://github.com/apache/incubator-pulsar/pull/539 C++ unit tests in less than a minute #537 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jai1/pulsar gtest-parallel Alternati

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124685805 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124685805 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #476: Make broker configurable to own non-pers...

2017-06-28 Thread rdhabalia
Github user rdhabalia closed the pull request at: https://github.com/apache/incubator-pulsar/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-pulsar pull request #476: Make broker configurable to own non-pers...

2017-06-28 Thread rdhabalia
Github user rdhabalia closed the pull request at: https://github.com/apache/incubator-pulsar/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-pulsar issue #476: Make broker configurable to own non-persistent ...

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/476 Created a new PR #538 so, closing this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] incubator-pulsar issue #476: Make broker configurable to own non-persistent ...

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/476 Created a new PR #538 so, closing this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] incubator-pulsar pull request #538: Make broker configurable to own non-pers...

2017-06-28 Thread rdhabalia
GitHub user rdhabalia opened a pull request: https://github.com/apache/incubator-pulsar/pull/538 Make broker configurable to own non-persistent topic ### Motivation Replacing #476 (due to rebase conflicts and namespace-configuration implementation) , and creating this PR on

[GitHub] incubator-pulsar pull request #534: Validate msg size after compressing the ...

2017-06-28 Thread rdhabalia
Github user rdhabalia closed the pull request at: https://github.com/apache/incubator-pulsar/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 I will create a separate PR to address C++ change. So, we can merge this one for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-pulsar pull request #534: Validate msg size after compressing the ...

2017-06-28 Thread rdhabalia
Github user rdhabalia closed the pull request at: https://github.com/apache/incubator-pulsar/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 I will create a separate PR to address C++ change. So, we can merge this one for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-28 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 @rdhabalia Are you going to make the C++ change in this PR or in a different one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-28 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 @rdhabalia Are you going to make the C++ change in this PR or in a different one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-pulsar pull request #485: CPP Client - Added Stats

2017-06-28 Thread jai1
Github user jai1 closed the pull request at: https://github.com/apache/incubator-pulsar/pull/485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pulsar pull request #485: CPP Client - Added Stats

2017-06-28 Thread jai1
Github user jai1 closed the pull request at: https://github.com/apache/incubator-pulsar/pull/485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pulsar issue #537: Speed up CPP Unit Tests

2017-06-28 Thread jai1
GitHub user jai1 opened an issue: https://github.com/apache/incubator-pulsar/issues/537 Speed up CPP Unit Tests Currently, CPP Unit Tests take around 7 minutes to complete. By using gtest-parallel I see that we can complete the tests in 55 seconds, which 7 times faster. On

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-28 Thread jai1
Github user jai1 commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @merlimat - The fix is related to my change since I had added stats checks to these tests. Because of the compiler issue (#529) - yesterday was the first time I realized that these tests were

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-28 Thread jai1
Github user jai1 commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @merlimat - The fix is related to my change since I had added stats checks to these tests. Because of the compiler issue (#529) - yesterday was the first time I realized that these tests were

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-28 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @jai1 Is the last commit related to the change or just an unrelated test fix? Should it go on its own? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-28 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @jai1 Is the last commit related to the change or just an unrelated test fix? Should it go on its own? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124611313 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,91 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124611313 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,91 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread saandrews
Github user saandrews commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124604292 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,91 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread saandrews
Github user saandrews commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124604292 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,91 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread saandrews
Github user saandrews commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124601435 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-28 Thread saandrews
Github user saandrews commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124601435 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p