[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124464192 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124464192 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-27 Thread jai1
Github user jai1 commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @merlimat - Yes, after merging with master the build should pass. I will merge it by end of day today. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-27 Thread jai1
Github user jai1 commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @merlimat - Yes, after merging with master the build should pass. I will merge it by end of day today. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-27 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @jai1 This should be ready to merge now, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] incubator-pulsar issue #485: CPP Client - Added Stats

2017-06-27 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/485 @jai1 This should be ready to merge now, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] incubator-pulsar pull request #536: Added CMake build file and instructions ...

2017-06-27 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/incubator-pulsar/pull/536 Added CMake build file and instructions for Pulsar Wireshark dissector ### Motivation Pulsar Wireshark dissector was missing build file You can merge this pull request into a Git

[GitHub] incubator-pulsar pull request #535: Enable TLS Client Authentication on WebS...

2017-06-27 Thread nkurihar
GitHub user nkurihar opened a pull request: https://github.com/apache/incubator-pulsar/pull/535 Enable TLS Client Authentication on WebSocketProxy and DiscoveryService ### Motivation * `tlsTrustCertsFilePath` in `ProxyServer` is not configurable * `tlsTrustCertsFilePath

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 > Can you also make this change in C++ client to be uniform? Yes, I will make it. --- If your project is set up for it, you can reply to this email and have your reply appear on

Podling Report Reminder - July 2017

2017-06-27 Thread johndament
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 19 July 2017, 10:30 am PDT. The report for your podling will form a

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 > Can you also make this change in C++ client to be uniform? Yes, I will make it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-pulsar pull request #534: Validate msg size after compressing the ...

2017-06-27 Thread jai1
Github user jai1 commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/534#discussion_r124423118 --- Diff: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java --- @@ -196,13 +198,27 @@ public void sendAsync(Message message,

[GitHub] incubator-pulsar pull request #534: Validate msg size after compressing the ...

2017-06-27 Thread jai1
Github user jai1 commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/534#discussion_r124423118 --- Diff: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java --- @@ -196,13 +198,27 @@ public void sendAsync(Message message,

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 @merlimat : [Yahoo-BK](https://github.com/yahoo/bookkeeper/blob/yahoo-4.3/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java#L113) allows maxFrame

[GitHub] incubator-pulsar issue #534: Validate msg size after compressing the msg whi...

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/534 @merlimat : [Yahoo-BK](https://github.com/yahoo/bookkeeper/blob/yahoo-4.3/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java#L113) allows maxFrame

[GitHub] incubator-pulsar pull request #534: Validate msg size after compressing the ...

2017-06-27 Thread rdhabalia
GitHub user rdhabalia opened a pull request: https://github.com/apache/incubator-pulsar/pull/534 Validate msg size after compressing the msg while sending msg ### Motivation As per discussion at #523 : add msg-size validation after compressing the message for non-batch mess

[GitHub] incubator-pulsar pull request #533: exclude license for athenz-test-conf fil...

2017-06-27 Thread rdhabalia
Github user rdhabalia closed the pull request at: https://github.com/apache/incubator-pulsar/pull/533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-pulsar pull request #533: exclude license for athenz-test-conf fil...

2017-06-27 Thread rdhabalia
Github user rdhabalia closed the pull request at: https://github.com/apache/incubator-pulsar/pull/533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-pulsar pull request #529: C++ Client - Changed compiler to default...

2017-06-27 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar pull request #529: C++ Client - Changed compiler to default...

2017-06-27 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar pull request #530: Support wildcard in permitted role name

2017-06-27 Thread yush1ga
Github user yush1ga commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/530#discussion_r124403361 --- Diff: conf/broker.conf --- @@ -140,6 +140,10 @@ authenticationProviders= # Enforce authorization authorizationEnabled=false

[GitHub] incubator-pulsar pull request #530: Support wildcard in permitted role name

2017-06-27 Thread yush1ga
Github user yush1ga commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/530#discussion_r124403361 --- Diff: conf/broker.conf --- @@ -140,6 +140,10 @@ authenticationProviders= # Enforce authorization authorizationEnabled=false

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124395612 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124395612 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124394515 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124394515 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #533: exclude license for athenz-test-conf fil...

2017-06-27 Thread rdhabalia
GitHub user rdhabalia opened a pull request: https://github.com/apache/incubator-pulsar/pull/533 exclude license for athenz-test-conf file ### Motivation Athenz-test was failing due to invalid test-conf file under test-resource. Adding license was making file invalid for pa

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124392598 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124392598 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124391454 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124391454 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #530: Support wildcard in permitted role name

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/530#discussion_r124366536 --- Diff: conf/broker.conf --- @@ -140,6 +140,10 @@ authenticationProviders= # Enforce authorization authorizationEnabled=false

[GitHub] incubator-pulsar pull request #530: Support wildcard in permitted role name

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/530#discussion_r124366536 --- Diff: conf/broker.conf --- @@ -140,6 +140,10 @@ authenticationProviders= # Enforce authorization authorizationEnabled=false

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124366298 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124366298 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124362085 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124362085 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-p

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124329926 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124329548 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124329548 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar pull request #532: add non-persistent topic documentation

2017-06-27 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/532#discussion_r124329926 --- Diff: docs/NonPersistentTopic.md --- @@ -0,0 +1,96 @@ + +# Non-persistent topic + + + +- [Topic](#topic) +- [Non-pe

[GitHub] incubator-pulsar issue #523: Max Payload size is validated before compressio...

2017-06-27 Thread sschepens
Github user sschepens commented on the issue: https://github.com/apache/incubator-pulsar/issues/523 Isn't Bookkeeper max entry size 5mb? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] incubator-pulsar issue #523: Max Payload size is validated before compressio...

2017-06-27 Thread sschepens
Github user sschepens commented on the issue: https://github.com/apache/incubator-pulsar/issues/523 Isn't Bookkeeper max entry size 5mb? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f