[Discuss] remove oauth2/go.mod from pulsar-client-go

2022-07-07 Thread Paul Gier
Hi Everyone! While working on some dependency improvements to pulsar-client-go, I noticed that the oauth2 sub-directory is defined as a go sub-module instead of just a normal sub-directory. This just means it has its own go.mod and go.sum, and it's dependencies are separately managed from the mai

Re: [DISCUSS] Changed pulsar-go-client minimum Go SDK version from 1.15 to 1.16

2022-09-29 Thread Paul Gier
+1 Passing the git ID and other version information via ldflags would be better in my opinion than embedding a file. It can be automated in the Makefile, and the values can go directly into a variable, so you don't have to do any string parsing. The feature has been around a long time, so we woul

Re: [DISCUSS] Changed pulsar-go-client minimum Go SDK version from 1.15 to 1.16

2022-09-30 Thread Paul Gier
the build. It only depends on the build using go modules, which hopefully most users should be doing at this point. Here is the PR, all feedback is appreciated! https://github.com/apache/pulsar-client-go/pull/856 On Thu, Sep 29, 2022 at 8:57 AM Paul Gier wrote: > +1 > Passing the git ID