[GitHub] [pulsar-client-node] massakam removed a comment on pull request #200: convert worker threads to async functions

2022-03-31 Thread GitBox
massakam removed a comment on pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1084389096 What about this comment? https://github.com/apache/pulsar-client-node/pull/200/files#issuecomment-1066336745 -- This is an automated message from the Ap

[GitHub] [pulsar-client-node] massakam edited a comment on pull request #200: convert worker threads to async functions

2022-03-31 Thread GitBox
massakam edited a comment on pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1084389095 What about this comment? https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1066336745 -- This is an automated message from the Apache Git

[GitHub] [pulsar-client-node] Matt-Esch commented on pull request #200: convert worker threads to async functions

2022-03-31 Thread GitBox
Matt-Esch commented on pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1084522750 > Is this line no longer needed? > > https://github.com/apache/pulsar-client-node/blob/571aa7a5b9598b317400e5a2bfc797cd9120342d/src/Client.h#L40 Yes th

[GitHub] [pulsar-site] DaveDuggins opened a new pull request #42: Added docs and supporting images

2022-03-31 Thread GitBox
DaveDuggins opened a new pull request #42: URL: https://github.com/apache/pulsar-site/pull/42 Added Core concepts and Core concepts API design topics to /docs. Added related images to static/assets. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar-site] DaveDuggins commented on pull request #42: Added docs and supporting images

2022-03-31 Thread GitBox
DaveDuggins commented on pull request #42: URL: https://github.com/apache/pulsar-site/pull/42#issuecomment-1084721738 @Anonymitaet Could you please review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-site] Paul-TT opened a new pull request #43: Fixing broken styles

2022-03-31 Thread GitBox
Paul-TT opened a new pull request #43: URL: https://github.com/apache/pulsar-site/pull/43 Wrapping classes have been moved to the html element. The style sheet needed to be updated to reflect that change. This pull request fixes the various layout issues that appeared recently. -- Thi

[GitHub] [pulsar-adapters] rdhabalia merged pull request #28: Auto update partition for pulsar kafka producer

2022-03-31 Thread GitBox
rdhabalia merged pull request #28: URL: https://github.com/apache/pulsar-adapters/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

[GitHub] [pulsar-site] Anonymitaet commented on pull request #42: Added docs and supporting images

2022-03-31 Thread GitBox
Anonymitaet commented on pull request #42: URL: https://github.com/apache/pulsar-site/pull/42#issuecomment-1085285904 Hi @DaveDuggins our convention is: before sending a PR, we run a local preview and then attach the preview screenshots in the PR description, so that others know your chang

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-31 Thread GitBox
massakam commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r840192801 ## File path: src/Client.cc ## @@ -40,14 +41,43 @@ static const std::string CFG_TLS_ALLOW_INSECURE = "tlsAllowInsecureConnection"; static cons

[GitHub] [pulsar-site] urfreespace opened a new pull request #44: feat: build script optimize

2022-03-31 Thread GitBox
urfreespace opened a new pull request #44: URL: https://github.com/apache/pulsar-site/pull/44 Signed-off-by: Li Li -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar-site] urfreespace merged pull request #43: Fixing broken styles

2022-03-31 Thread GitBox
urfreespace merged pull request #43: URL: https://github.com/apache/pulsar-site/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [pulsar-site] urfreespace merged pull request #42: Added docs and supporting images

2022-03-31 Thread GitBox
urfreespace merged pull request #42: URL: https://github.com/apache/pulsar-site/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [pulsar-site] urfreespace closed pull request #21: Update reporting a vulnerability documentation

2022-03-31 Thread GitBox
urfreespace closed pull request #21: URL: https://github.com/apache/pulsar-site/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [pulsar-site] urfreespace merged pull request #44: feat: build script optimize

2022-03-31 Thread GitBox
urfreespace merged pull request #44: URL: https://github.com/apache/pulsar-site/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [pulsar-site] urfreespace opened a new pull request #45: feat: add docs of 2.1.1-incubating and 2.1.0-incubating

2022-04-01 Thread GitBox
urfreespace opened a new pull request #45: URL: https://github.com/apache/pulsar-site/pull/45 Signed-off-by: Li Li -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar-site] urfreespace merged pull request #45: feat: add docs of 2.1.1-incubating and 2.1.0-incubating

2022-04-01 Thread GitBox
urfreespace merged pull request #45: URL: https://github.com/apache/pulsar-site/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [pulsar-site] dave2wave commented on pull request #21: Update reporting a vulnerability documentation

2022-04-01 Thread GitBox
dave2wave commented on pull request #21: URL: https://github.com/apache/pulsar-site/pull/21#issuecomment-1085943990 Make the names of the list links to the archives. (https://lists.apache.org/list.html?dev@pulsar.apache.org) On the mailing lists page there is a subscribe button. It w

[GitHub] [pulsar-site] Paul-TT opened a new pull request #46: adding pagination to carousel

2022-04-01 Thread GitBox
Paul-TT opened a new pull request #46: URL: https://github.com/apache/pulsar-site/pull/46 Refactoring image carousel. Added pagination as requested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar-site] urfreespace merged pull request #46: adding pagination to carousel

2022-04-01 Thread GitBox
urfreespace merged pull request #46: URL: https://github.com/apache/pulsar-site/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [pulsar-helm-chart] adminnz opened a new issue #254: Pulsar Manager Username/Password does not work with examples/values-minikube.yaml

2022-04-01 Thread GitBox
adminnz opened a new issue #254: URL: https://github.com/apache/pulsar-helm-chart/issues/254 **Describe the bug** When installing the Helm chart with examples/values-minikube.yaml with a modification make it install pulsar_manager. The puslar manager pod is started along with the serv

[GitHub] [pulsar-helm-chart] adminnz commented on issue #254: Pulsar Manager Username/Password does not work with examples/values-minikube.yaml

2022-04-02 Thread GitBox
adminnz commented on issue #254: URL: https://github.com/apache/pulsar-helm-chart/issues/254#issuecomment-1086584791 I've manged to login by creating a super user using the[ following steps.](https://github.com/apache/pulsar-manager/blob/994ad84ee3b1a73f978e1e31950c961ce4a69cf6/README.md#a

[GitHub] [pulsar-dotpulsar] adminnz commented on pull request #83: feat: #46 support nack delay and ack timeouts

2022-04-02 Thread GitBox
adminnz commented on pull request #83: URL: https://github.com/apache/pulsar-dotpulsar/pull/83#issuecomment-1086600728 Is there a reason this has not been merged? NegativeAcknowledge is an important part of the messaging capabilities of Pulsar. -- This is an automated message from the

[GitHub] [pulsar-dotpulsar] blankensteiner closed issue #101: `AuthenticateUsingToken(Func> tokenFactory)` is not a part of 2.3.0

2022-04-02 Thread GitBox
blankensteiner closed issue #101: URL: https://github.com/apache/pulsar-dotpulsar/issues/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

[GitHub] [pulsar-site] momo-jun commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-02 Thread GitBox
momo-jun commented on pull request #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1086640649 @urfreespace @Anonymitaet can you pls review this PR? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pulsar-client-node] jskorlol commented on issue #161: Looks like the pulsar-client-node can not run with the current pulsar master code

2022-04-02 Thread GitBox
jskorlol commented on issue #161: URL: https://github.com/apache/pulsar-client-node/issues/161#issuecomment-1086659703 I have the same problem. Unable to install from linux docker. How can I solve this ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-node] jskorlol edited a comment on issue #161: Looks like the pulsar-client-node can not run with the current pulsar master code

2022-04-02 Thread GitBox
jskorlol edited a comment on issue #161: URL: https://github.com/apache/pulsar-client-node/issues/161#issuecomment-1086659703 I have the same problem. Unable to install from linux docker. How can I solve this ? I got the same error whether I installed apache-pulsar-client-dev.d

[GitHub] [pulsar-client-node] jskorlol commented on issue #134: Getting error while installing

2022-04-02 Thread GitBox
jskorlol commented on issue #134: URL: https://github.com/apache/pulsar-client-node/issues/134#issuecomment-1086673265 I'm also trying to install it inside a docker container, but it doesn't work. Any solution ? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [pulsar-site] Anonymitaet commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-02 Thread GitBox
Anonymitaet commented on pull request #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1086760027 @momo-jun why not update docs earlier than 2.7.2? Don't we need to update docs for all versions otherwise users do not have restapi doc entrance? -- This is an automated

[GitHub] [pulsar-dotpulsar] VisualBean commented on issue #101: `AuthenticateUsingToken(Func> tokenFactory)` is not a part of 2.3.0

2022-04-03 Thread GitBox
VisualBean commented on issue #101: URL: https://github.com/apache/pulsar-dotpulsar/issues/101#issuecomment-1086892520 I never found it, but ended up overriding iauthentication instead - which worked great for OAuth using MSAL. -- This is an automated message from the Apache Git Servic

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15015: [enh][transaction] Optimize to reuse transaction buffer snapshot writer

2022-04-03 Thread GitBox
Technoboy- commented on code in PR #15015: URL: https://github.com/apache/pulsar/pull/15015#discussion_r841313610 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBaseTxnBufferSnapshotService.java: ## @@ -18,69 +18,168 @@ */ package org.apache.pulsar

[GitHub] [pulsar-site] momo-jun commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-03 Thread GitBox
momo-jun commented on PR #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1087050743 > @momo-jun why not update docs earlier than 2.7.2? Don't we need to update docs for all versions otherwise users do not have restapi doc entrance? I understand the maintenance rul

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15017: [fix][transaction] Fix transaction REST API redirect issue.

2022-04-03 Thread GitBox
Jason918 commented on code in PR #15017: URL: https://github.com/apache/pulsar/pull/15017#discussion_r841339916 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java: ## @@ -67,216 +67,144 @@ protected void internalGetCoordinatorStats(As

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #14985: Add a cache eviction policy:Evicting cache data by the slowest markDeletedPosition

2022-04-03 Thread GitBox
lordcheng10 commented on code in PR #14985: URL: https://github.com/apache/pulsar/pull/14985#discussion_r84115 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -291,6 +291,185 @@ public void acknowledge1() throws Exception {

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

2022-04-03 Thread GitBox
kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841390236 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java: ## @@ -439,11 +451,65 @@ ClientConfigurationData createClientConfiguration() throws

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

2022-04-03 Thread GitBox
kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841398032 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java: ## @@ -240,16 +253,23 @@ public void channelActive(ChannelHandlerContext ctx) throws Exce

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

2022-04-03 Thread GitBox
kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841398032 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java: ## @@ -240,16 +253,23 @@ public void channelActive(ChannelHandlerContext ctx) throws Exce

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

2022-04-03 Thread GitBox
kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841401389 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java: ## @@ -20,43 +20,93 @@ import io.netty.buffer.ByteBuf; import io.netty.channel.Ev

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

2022-04-03 Thread GitBox
kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841402861 ## pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithJwtAuthorizationTest.java: ## @@ -363,6 +374,72 @@ public void testProxyAuthorizationWithPrefixS

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #15011: [improve][transaction] support configurable ``transactionBufferClientOperationTimeoutInMills``

2022-04-04 Thread GitBox
mattisonchao commented on code in PR #15011: URL: https://github.com/apache/pulsar/pull/15011#discussion_r841480571 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -2475,6 +2475,12 @@ ) private int transactionBufferClient

[GitHub] [pulsar-client-node] Matt-Esch commented on a diff in pull request #200: convert worker threads to async functions

2022-04-04 Thread GitBox
Matt-Esch commented on code in PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r841559559 ## src/Client.cc: ## @@ -40,14 +41,43 @@ static const std::string CFG_TLS_ALLOW_INSECURE = "tlsAllowInsecureConnection"; static const std::string CFG_STATS_

[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #200: convert worker threads to async functions

2022-04-04 Thread GitBox
massakam commented on code in PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r841573203 ## src/Client.cc: ## @@ -40,14 +41,43 @@ static const std::string CFG_TLS_ALLOW_INSECURE = "tlsAllowInsecureConnection"; static const std::string CFG_STATS_I

[GitHub] [pulsar-client-node] equanz commented on a diff in pull request #200: convert worker threads to async functions

2022-04-04 Thread GitBox
equanz commented on code in PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r842345647 ## src/Consumer.cc: ## @@ -243,160 +235,225 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise::Deferred deferred; - puls

[GitHub] [pulsar-site] Anonymitaet commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-05 Thread GitBox
Anonymitaet commented on PR #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1089575626 @momo-jun this doc update is different from other normal doc updates. We've removed "REST API" from top navigation, so users do not have a entrance to this doc https://user-imag

[GitHub] [pulsar-site] momo-jun commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-05 Thread GitBox
momo-jun commented on PR #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1089584573 @Anonymitaet OK. I will do that for all versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar-site] Anonymitaet commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-05 Thread GitBox
Anonymitaet commented on PR #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1089613027 @momo-jun have you checked the preview for all versions on your local machine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar-client-node] massakam merged pull request #200: convert worker threads to async functions

2022-04-05 Thread GitBox
massakam merged PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@puls

[GitHub] [pulsar-site] urfreespace opened a new pull request, #47: feat: local preview script

2022-04-05 Thread GitBox
urfreespace opened a new pull request, #47: URL: https://github.com/apache/pulsar-site/pull/47 Signed-off-by: Li Li -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar-site] urfreespace merged pull request #47: feat: local preview script

2022-04-05 Thread GitBox
urfreespace merged PR #47: URL: https://github.com/apache/pulsar-site/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-site] momo-jun commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-05 Thread GitBox
momo-jun commented on PR #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1089703186 @Anonymitaet Thanks for your reminder. I only previewed the latest version several days ago. Just figured out how to preview versioned ones with the help from @urfreespace. Now it's

[GitHub] [pulsar-client-node] Matt-Esch commented on pull request #200: convert worker threads to async functions

2022-04-05 Thread GitBox
Matt-Esch commented on PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1089772061 When will this be versioned and published to npm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-node] massakam commented on pull request #200: convert worker threads to async functions

2022-04-05 Thread GitBox
massakam commented on PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1089809975 The last release was done last month, so I think the next version will be released around June. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-node] cjfff commented on issue #87: npm install fails on MacOS

2022-04-06 Thread GitBox
cjfff commented on issue #87: URL: https://github.com/apache/pulsar-client-node/issues/87#issuecomment-1089897914 don't forget to do this step... when I forget to run the step 2, I got the same issue... ![image](https://user-images.githubusercontent.com/20502762/161915162-f499

[GitHub] [pulsar-site] Anonymitaet merged pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

2022-04-06 Thread GitBox
Anonymitaet merged PR #36: URL: https://github.com/apache/pulsar-site/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-client-node] kimula commented on issue #207: About cmake pulsar-client-cpp

2022-04-06 Thread GitBox
kimula commented on issue #207: URL: https://github.com/apache/pulsar-client-node/issues/207#issuecomment-1091119354 @liutt1312 it seems to be a problem with the C++ client rather than the Node.js client. please re-create an issue here https://github.com/apache/pulsar . -- This is

[GitHub] [pulsar-helm-chart] gaoran10 opened a new pull request, #255: Bump version to `2.9.2`

2022-04-06 Thread GitBox
gaoran10 opened a new pull request, #255: URL: https://github.com/apache/pulsar-helm-chart/pull/255 ### Motivation The docker image Pulsar `2.9.2` is available, bump the chart version to `2.9.2`. ### Modifications Bump the Pulsar image version and app version to `2.9.2`

[GitHub] [pulsar-test-infra] nodece opened a new pull request, #28: fix: fix get failured checks

2022-04-07 Thread GitBox
nodece opened a new pull request, #28: URL: https://github.com/apache/pulsar-test-infra/pull/28 Signed-off-by: Zixuan Liu ### Motivation I tried to rerun the failed test, but the failed test cannot be rerun. I checked the https://github.com/apache/pulsar/runs/5869256539?check

[GitHub] [pulsar-test-infra] nodece commented on pull request #27: Use the new GitHub API to re-run failed jobs

2022-04-07 Thread GitBox
nodece commented on PR #27: URL: https://github.com/apache/pulsar-test-infra/pull/27#issuecomment-1091988110 @lhotari @michaeljmarshall @codelipenghui This PR breaks the `/pulsarbot rerun-failure-checks` feature, I submitted #28 to fix this, could you review this PR? Thanks for your time.

[GitHub] [pulsar-test-infra] lhotari closed pull request #28: fix: fix get failured checks

2022-04-07 Thread GitBox
lhotari closed pull request #28: fix: fix get failured checks URL: https://github.com/apache/pulsar-test-infra/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [pulsar-test-infra] lhotari commented on pull request #28: fix: fix get failured checks

2022-04-07 Thread GitBox
lhotari commented on PR #28: URL: https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1092079756 I explained some of the changes in https://lists.apache.org/thread/n05xp17krb4f3cc0jjkh65ytqk1w6130 . You can also provide feedback on the mailing list. -- This is an a

[GitHub] [pulsar-test-infra] lhotari commented on pull request #27: Use the new GitHub API to re-run failed jobs

2022-04-07 Thread GitBox
lhotari commented on PR #27: URL: https://github.com/apache/pulsar-test-infra/pull/27#issuecomment-1092081886 > @lhotari @michaeljmarshall @codelipenghui This PR breaks the `/pulsarbot rerun-failure-checks` feature, I submitted #28 to fix this, could you review this PR? Thanks for your tim

[GitHub] [pulsar-test-infra] lhotari commented on pull request #28: fix: fix get failured checks

2022-04-07 Thread GitBox
lhotari commented on PR #28: URL: https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1092083499 With the new CI there's another case where you see a red mark. It's when flaky tests fail, but later pass in a retry, the failed test result will get recorded to a test report. That

[GitHub] [pulsar-test-infra] lhotari commented on pull request #28: fix: fix get failured checks

2022-04-07 Thread GitBox
lhotari commented on PR #28: URL: https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1092086661 In your case, it's the flaky tests report: https://github.com/apache/pulsar/pull/15065/checks?check_run_id=5867398812 . -- This is an automated message from the Apache Git Servic

[GitHub] [pulsar-test-infra] nodece commented on pull request #28: fix: fix get failured checks

2022-04-07 Thread GitBox
nodece commented on PR #28: URL: https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1092396641 @lhotari Thanks for your explanation! > There's a misunderstanding. The new CI requires using the new API for re-running just failed jobs and not the complete workflow. Pleas

[GitHub] [pulsar-test-infra] lhotari commented on pull request #28: fix: fix get failured checks

2022-04-07 Thread GitBox
lhotari commented on PR #28: URL: https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1092402909 > I have a question about the `get_runs failure` don't seem to get the correct data, this data includes the `conclusion: success` item. Do you notice this? Yes. That happens

[GitHub] [pulsar-site] urfreespace opened a new pull request, #48: fix: migrate algolia to new credencials

2022-04-07 Thread GitBox
urfreespace opened a new pull request, #48: URL: https://github.com/apache/pulsar-site/pull/48 Signed-off-by: Li Li -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar-test-infra] nodece commented on pull request #27: Use the new GitHub API to re-run failed jobs

2022-04-07 Thread GitBox
nodece commented on PR #27: URL: https://github.com/apache/pulsar-test-infra/pull/27#issuecomment-1092412534 This PR is working, thanks for the @lhotari explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-node] nkurihar commented on issue #14: Implement Asynchronous Processing Using C Async Function

2022-04-08 Thread GitBox
nkurihar commented on issue #14: URL: https://github.com/apache/pulsar-client-node/issues/14#issuecomment-1092566482 Now AsyncWorker is replaced with async functions: https://github.com/apache/pulsar-client-node/pull/200 -- This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar-client-node] nkurihar closed issue #14: Implement Asynchronous Processing Using C Async Function

2022-04-08 Thread GitBox
nkurihar closed issue #14: Implement Asynchronous Processing Using C Async Function URL: https://github.com/apache/pulsar-client-node/issues/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar-helm-chart] ckdarby commented on pull request #205: Tiered Storage config

2022-04-08 Thread GitBox
ckdarby commented on PR #205: URL: https://github.com/apache/pulsar-helm-chart/pull/205#issuecomment-1093005135 @sijie Can you assign over to someone else to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar-client-node] hrsakai opened a new pull request, #208: Add a pulsar nodejs client document link to package.json/README

2022-04-10 Thread GitBox
hrsakai opened a new pull request, #208: URL: https://github.com/apache/pulsar-client-node/pull/208 Currently, users can't find https://pulsar.apache.org/docs/en/client-libraries-node on [github](https://github.com/apache/pulsar-client-node) and [npmjs](https://www.npmjs.com/package/pulsar

[GitHub] [pulsar-helm-chart] codelipenghui merged pull request #255: Bump version to `2.9.2`

2022-04-11 Thread GitBox
codelipenghui merged PR #255: URL: https://github.com/apache/pulsar-helm-chart/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [pulsar-client-node] nkurihar merged pull request #208: Add a pulsar nodejs client document link to package.json/README

2022-04-11 Thread GitBox
nkurihar merged PR #208: URL: https://github.com/apache/pulsar-client-node/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@puls

[GitHub] [pulsar-helm-chart] jaggerwang opened a new issue, #256: Cannot use the default admin username and password to login manager.

2022-04-11 Thread GitBox
jaggerwang opened a new issue, #256: URL: https://github.com/apache/pulsar-helm-chart/issues/256 **Describe the bug** When tried to login manager, it always shows "The username or password is incorrect". ![image](https://user-images.githubusercontent.com/1255011/162713833-85b0882e-28a

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #205: Tiered Storage config

2022-04-11 Thread GitBox
michaeljmarshall commented on PR #205: URL: https://github.com/apache/pulsar-helm-chart/pull/205#issuecomment-1095662863 @pellicano @ckdarby - are you able to rebase and then take a look at the failing status checks? Once that happens, I think we can merge this. Thanks! -- This is an aut

[GitHub] [pulsar-manager] tuteng merged pull request #448: fix: node engines limit and ignore eslint

2022-04-11 Thread GitBox
tuteng merged PR #448: URL: https://github.com/apache/pulsar-manager/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-manager] tuteng merged pull request #444: Simplified classpath

2022-04-11 Thread GitBox
tuteng merged PR #444: URL: https://github.com/apache/pulsar-manager/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-manager] tuteng closed issue #443: Simplify the classpath in the bin/pulsar-manager script

2022-04-11 Thread GitBox
tuteng closed issue #443: Simplify the classpath in the bin/pulsar-manager script URL: https://github.com/apache/pulsar-manager/issues/443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar-helm-chart] LoveEachDay opened a new issue, #257: podMonitor name conflicts for multiple releases in the same namespace

2022-04-12 Thread GitBox
LoveEachDay opened a new issue, #257: URL: https://github.com/apache/pulsar-helm-chart/issues/257 **Describe the bug** Install two releases of pulsar cluster with podMonitor enabled in the same namespace will fail. **To Reproduce** Steps to reproduce the behavior: 1. inst

[GitHub] [pulsar-helm-chart] LoveEachDay commented on issue #257: podMonitor name conflicts for multiple releases in the same namespace

2022-04-12 Thread GitBox
LoveEachDay commented on issue #257: URL: https://github.com/apache/pulsar-helm-chart/issues/257#issuecomment-1096560953 /assign @LoveEachDay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-helm-chart] LoveEachDay opened a new pull request, #258: Fix PodMonitor name conflicts for multiple releases in same namespace

2022-04-12 Thread GitBox
LoveEachDay opened a new pull request, #258: URL: https://github.com/apache/pulsar-helm-chart/pull/258 Signed-off-by: Edward Zeng Fixes #257 ### Motivation Fix PodMonitor name conflicts for multiple releases in same namespace ### Modifications Use release n

[GitHub] [pulsar-manager] tuteng opened a new pull request, #456: Code cleanup for roles, github login, etc.

2022-04-12 Thread GitBox
tuteng opened a new pull request, #456: URL: https://github.com/apache/pulsar-manager/pull/456 Remove github social login Disable cluster page *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please a

[GitHub] [pulsar-helm-chart] LoveEachDay commented on pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace

2022-04-12 Thread GitBox
LoveEachDay commented on PR #258: URL: https://github.com/apache/pulsar-helm-chart/pull/258#issuecomment-1096573551 /cc @tuteng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [pulsar-manager] tuteng closed issue #445: feat: add support for Casdoor authentication

2022-04-12 Thread GitBox
tuteng closed issue #445: feat: add support for Casdoor authentication URL: https://github.com/apache/pulsar-manager/issues/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar-manager] tuteng merged pull request #446: Add support for casdoor

2022-04-12 Thread GitBox
tuteng merged PR #446: URL: https://github.com/apache/pulsar-manager/pull/446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-manager] tuteng commented on pull request #446: Add support for casdoor

2022-04-12 Thread GitBox
tuteng commented on PR #446: URL: https://github.com/apache/pulsar-manager/pull/446#issuecomment-1097533095 @hsluoyz @fabian4 Can you add a document for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-manager] tuteng merged pull request #456: Code cleanup for roles, github login, etc.

2022-04-13 Thread GitBox
tuteng merged PR #456: URL: https://github.com/apache/pulsar-manager/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-test-infra] lhotari commented on pull request #28: fix: fix get failured checks

2022-04-14 Thread GitBox
lhotari commented on PR #28: URL: https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1098935588 There's more details in https://lists.apache.org/thread/60x7sqg2p4mlssj5jtow6zwq3jksf6w3 . Currently there's an issue with GitHub Actions that the workflow run search doesn't

[GitHub] [pulsar-helm-chart] LvLs9 commented on pull request #251: make proxy httpNumThreads configurable

2022-04-14 Thread GitBox
LvLs9 commented on PR #251: URL: https://github.com/apache/pulsar-helm-chart/pull/251#issuecomment-1099086763 Please merge that awesome PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar-manager] john1337 commented on issue #429: Bug: default user pulsar/pulsar does not have permission to create a new environment

2022-04-14 Thread GitBox
john1337 commented on issue #429: URL: https://github.com/apache/pulsar-manager/issues/429#issuecomment-1099088156 one year passed,still no body fixed it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-manager] eolivelli commented on issue #429: Bug: default user pulsar/pulsar does not have permission to create a new environment

2022-04-14 Thread GitBox
eolivelli commented on issue #429: URL: https://github.com/apache/pulsar-manager/issues/429#issuecomment-1099095246 @john1337 would you have time to send a fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request, #259: [Proxy] Increase httpNumThreads from 8 to 16

2022-04-14 Thread GitBox
lhotari opened a new pull request, #259: URL: https://github.com/apache/pulsar-helm-chart/pull/259 - after the recent changes in Pulsar Proxy, the proxy won't start if httpNumThreads is set to 8 and there are >= cores assigned to the pod Error message is ``` Caused by: jav

[GitHub] [pulsar-site] urfreespace merged pull request #49: nav styling and community carousel updates

2022-04-14 Thread GitBox
urfreespace merged PR #49: URL: https://github.com/apache/pulsar-site/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #29: Bump minimist from 1.2.0 to 1.2.6 in /paths-filter

2022-04-14 Thread GitBox
dependabot[bot] opened a new pull request, #29: URL: https://github.com/apache/pulsar-test-infra/pull/29 Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846";>7ef

[GitHub] [pulsar-site] urfreespace opened a new pull request, #50: fix: sidebar missing docker and helm in next version

2022-04-14 Thread GitBox
urfreespace opened a new pull request, #50: URL: https://github.com/apache/pulsar-site/pull/50 Signed-off-by: Li Li -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar-site] urfreespace merged pull request #50: fix: sidebar missing docker and helm in next version

2022-04-14 Thread GitBox
urfreespace merged PR #50: URL: https://github.com/apache/pulsar-site/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #30: Bump minimist from 1.2.5 to 1.2.6 in /doc-label-check

2022-04-16 Thread GitBox
dependabot[bot] opened a new pull request, #30: URL: https://github.com/apache/pulsar-test-infra/pull/30 Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846";>7ef

[GitHub] [pulsar-site] urfreespace merged pull request #51: feat: auto sync releases.json

2022-04-16 Thread GitBox
urfreespace merged PR #51: URL: https://github.com/apache/pulsar-site/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-manager] urfreespace opened a new pull request, #457: fix: dependencies fix for webpack and npm version limit

2022-04-18 Thread GitBox
urfreespace opened a new pull request, #457: URL: https://github.com/apache/pulsar-manager/pull/457 *(If this PR fixes a github issue, please add `Fixes #`.)* fix: dependencies fix for webpack and npm version limit *(or if this PR is one task of a github issue, please add `Maste

[GitHub] [pulsar-manager] urfreespace merged pull request #457: fix: dependencies fix for webpack and npm version limit

2022-04-18 Thread GitBox
urfreespace merged PR #457: URL: https://github.com/apache/pulsar-manager/pull/457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsa

[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #31: Bump minimist from 1.2.5 to 1.2.6 in /test-reporter/reports/jest

2022-04-18 Thread GitBox
dependabot[bot] opened a new pull request, #31: URL: https://github.com/apache/pulsar-test-infra/pull/31 Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846";>7ef

<    3   4   5   6   7   8   9   10   11   12   >