Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-21 Thread 太上玄元道君
Hi Jie, I suggest you don't modify the parameters order. Change ``` void sendComplete(OpSendMsgStats stats, Exception e); ``` to ``` void sendComplete(Exception e, OpSendMsgStats stats); ``` Thanks, Tao Jiuming Jie crossover 于2024年6月21日周五 14:05写道: > Hi Jiuming, > You are right, because the da

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-21 Thread Jie crossover
Hi Jiuming, Good suggestion, done. -- Best Regards! crossoverJie 太上玄元道君 于2024年6月21日周五 17:34写道: > Hi Jie, > > I suggest you don't modify the parameters order. > > Change > ``` > void sendComplete(OpSendMsgStats stats, Exception e); > ``` > to > ``` > void sendComplete(Exception e, OpSendMsgSta

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-21 Thread 太上玄元道君
Hi Jie, Thanks, so we don't need to fix Skywalking, for OpenTelemetry-javaagent, I'll create a PR to fix this. Jie crossover 于2024年6月21日周五 17:52写道: > Hi Jiuming, > > Good suggestion, done. > -- > Best Regards! > crossoverJie > > > 太上玄元道君 于2024年6月21日周五 17:34写道: > > > Hi Jie, > > > > I suggest y

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

2024-06-21 Thread Jie crossover
Hi Jiuming, Thank you for fixing this. -- Best Regards! crossoverJie 太上玄元道君 于2024年6月21日周五 17:55写道: > Hi Jie, > > Thanks, so we don't need to fix Skywalking, for OpenTelemetry-javaagent, > I'll create a PR to fix this. > > Jie crossover 于2024年6月21日周五 17:52写道: > > > Hi Jiuming, > > > > Good su

Re: [DISCUSS] PIP-361: Support URI, DNS, RID, IP based Token building from client's X.509 Certificate SAN Extensions

2024-06-21 Thread naresh
Hi Liu, Only 2 new properties are added. I have already implemented code extending AuthenticationProviderTls I have gone through older tickets which asked for this feature https://github.com/apache/pulsar/issues/4696 Environments like SPIFFE would get out-of-the-box support from pulsar with this