Hi Jie,
I suggest you don't modify the parameters order.
Change
```
void sendComplete(OpSendMsgStats stats, Exception e);
```
to
```
void sendComplete(Exception e, OpSendMsgStats stats);
```
Thanks,
Tao Jiuming
Jie crossover 于2024年6月21日周五 14:05写道:
> Hi Jiuming,
> You are right, because the da
Hi Jiuming,
Good suggestion, done.
--
Best Regards!
crossoverJie
太上玄元道君 于2024年6月21日周五 17:34写道:
> Hi Jie,
>
> I suggest you don't modify the parameters order.
>
> Change
> ```
> void sendComplete(OpSendMsgStats stats, Exception e);
> ```
> to
> ```
> void sendComplete(Exception e, OpSendMsgSta
Hi Jie,
Thanks, so we don't need to fix Skywalking, for OpenTelemetry-javaagent,
I'll create a PR to fix this.
Jie crossover 于2024年6月21日周五 17:52写道:
> Hi Jiuming,
>
> Good suggestion, done.
> --
> Best Regards!
> crossoverJie
>
>
> 太上玄元道君 于2024年6月21日周五 17:34写道:
>
> > Hi Jie,
> >
> > I suggest y
Hi Jiuming,
Thank you for fixing this.
--
Best Regards!
crossoverJie
太上玄元道君 于2024年6月21日周五 17:55写道:
> Hi Jie,
>
> Thanks, so we don't need to fix Skywalking, for OpenTelemetry-javaagent,
> I'll create a PR to fix this.
>
> Jie crossover 于2024年6月21日周五 17:52写道:
>
> > Hi Jiuming,
> >
> > Good su
Hi Liu,
Only 2 new properties are added. I have already implemented code extending
AuthenticationProviderTls
I have gone through older tickets which asked for this feature
https://github.com/apache/pulsar/issues/4696
Environments like SPIFFE would get out-of-the-box support from pulsar with
this