Re: Reporting and tooling to detect thread leaks in Pulsar tests

2023-10-29 Thread Asaf Mesika
Larry, I know there is a way to add like a Job summary, so we can write it there - do you think this can increase visibility? On Sun, Oct 29, 2023 at 4:53 AM Lari Hotari wrote: > Hi all, > > I have submitted a PR (https://github.com/apache/pulsar/pull/21450) which > includes changes to add repor

Re: [VOTE] Pulsar Client Go Release 0.11.1 Candidate 1

2023-10-29 Thread PengHui Li
+1 (binding) - Verified the signatures - Build from the source - Run the test on Pulsar 3.1.1 (make test PULSAR_VERSION=3.1.1) - Run the test on Pulsar 3.0.1 (make test PULSAR_VERSION=3.0.1) Regards, Penghui On Fri, Oct 20, 2023 at 4:46 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum

Re: [DISCUSS] PIP-313 Support force unsubscribe using consumer api

2023-10-29 Thread PengHui Li
Hi Rajan, The proposal looks good to me. The context and the goal are clear. I have 2 comments here 1. The change will not only affect the shared subscription, but it will also affect the Failover and Key_Shared subscriptions. 2. We should also mention the behavior of other consumers when one co

Re: [VOTE] PIP-307: Support subscribing multi-topics for WebSocket

2023-10-29 Thread guo jiwei
Thanks @Tison Close this vote first and then I will change the pip num. Regards Jiwei Guo (Tboy) On Wed, Oct 25, 2023 at 3:02 AM tison wrote: > PIP number conflicts. > > May we keep using pip-xxx instead of pip_xxx so that Git can help detect > number conflict.. > > Best, > tison. > > > 太上玄元道

Re: [VOTE] Pulsar Release 3.0.2 Candidate 2

2023-10-29 Thread Yubiao Feng
Update: blocked by https://github.com/apache/pulsar/pull/21445 I will do a new candidate later Thanks Yubiao Feng On Fri, Oct 27, 2023 at 10:50 PM Yubiao Feng wrote: > This is the first release candidate for Apache Pulsar version 3.0.2. > > It fixes the following issues: > > https://github.co

Re: Reporting and tooling to detect thread leaks in Pulsar tests

2023-10-29 Thread Lari Hotari
Hi Asaf, Yes, the visibility aspect is already solved by using warnings in the summary view. Please check the example https://github.com/apache/pulsar/actions/runs/6680066364?pr=21450 . Job summaries could also be used, but they have less visibility in the summary view, as you can see from the