[VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread guo jiwei
Hi dev, This thread is to start a vote for PIP-277: Add `current` option in the Clusters list cmd Discuss thread : https://lists.apache.org/thread/800r6ld5wg7bttbywmk38m1qx12hs6nl PIP: https://github.com/apache/pulsar/pull/20614 Regards Jiwei Guo (Tboy)

Re: [DISCUSS] Replace Customized Map with ConcurrentHashMap

2023-09-06 Thread Yunze Xu
I support replacing it with JDK's ConcurrentHashMap. Maintaining a customized concurrent hash map whose algorithm is essentially the same with the implementation of a very old version of JDK is painful. The PROs listed like no boxing and linear probing have not proved to be better by any benchmark.

Re: [VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-06 Thread Zike Yang
Thank you all. Close this vote by 3 binding +1s: - Enrico - Penghui Li - Mattison And 1 non-binding +1: Baodi Shi Thanks, ZIke Yang On Tue, Sep 5, 2023 at 9:25 AM wrote: > > +1 (binding) > > Best, > Mattison > On 5 Sep 2023 at 09:07 +0800, PengHui Li , wrote: > > +1 (binding) > > > > Thanks, >

Re: [DISCUSS] Replace Customized Map with ConcurrentHashMap

2023-09-06 Thread PengHui Li
I also support the idea. For the execution. I think we can have a branch to apply the changes and then we can built a distribution for the benchmark. After we get the result, then we can decide if it's fine to go to the new solution. The change should also be applied to bookkeeper. And I can help

Re: [DISCUSS] Replace Customized Map with ConcurrentHashMap

2023-09-06 Thread mattison chao
Hi, Guys. IMO, It's a data structure difference. We can give the benchmark of two structures in different situations (pulsar using situations). > we can built a distribution for the benchmark. After we get the result, > then we can decide if it's fine to go to the new solution. The change should

Re: [DISCUSS] Replace Customized Map with ConcurrentHashMap

2023-09-06 Thread PengHui Li
Hi Qiang, Lastly, it would be beneficial to conduct a test on the distributions as the ConcurrentHashMap has demonstrated improved efficiency. However, a drawback is the potential increase in JVM GC overhead. If we can assess the final outcome of the Pulsar benchmark, the findings would be more pe

Re: [VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread PengHui Li
+1 (binding) The proposal just added a new option to show which cluster is the current cluster accessed. It will not break any existing behavior. Regards, Penghui On Wed, Sep 6, 2023 at 4:21 PM guo jiwei wrote: > Hi dev, >This thread is to start a vote for PIP-277: Add `current` option in

Re: [DISCUSS] Replace Customized Map with ConcurrentHashMap

2023-09-06 Thread mattison chao
> Moreover, this process should not consume excessive time. Simply initiate > the script, await the deployment, and execute the test. I have personally > performed this procedure numerous times with success. :) That will be cool. Looking forward to it. btw, I am not sure if I remember correctly. D

Re: [VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread mattison chao
+1 (binding) Best, Mattison On 6 Sep 2023 at 22:37 +0800, PengHui Li , wrote: > +1 (binding) > > The proposal just added a new option to show which cluster is the current > cluster accessed. It will not break any existing behavior. > > Regards, > Penghui > > On Wed, Sep 6, 2023 at 4:21 PM guo jiwe

Re: [VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread tison
+1 (binding) Trivial with low risk. Best, tison. mattison chao 于2023年9月6日周三 22:50写道： > +1 (binding) > > Best, > Mattison > On 6 Sep 2023 at 22:37 +0800, PengHui Li , wrote: > > +1 (binding) > > > > The proposal just added a new option to show which cluster is the current > > cluster accessed.

Re: [VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread Zike Yang
+1 (non-binding) BR, Zike Yang On Wed, Sep 6, 2023 at 11:47 PM tison wrote: > > +1 (binding) > > Trivial with low risk. > > Best, > tison. > > > mattison chao 于2023年9月6日周三 22:50写道： > > > +1 (binding) > > > > Best, > > Mattison > > On 6 Sep 2023 at 22:37 +0800, PengHui Li , wrote: > > > +1 (bind

Re: [VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread Zixuan Liu
+1 (non-binding) Best, Zixuan Zike Yang 于2023年9月6日周三 23:56写道： > > +1 (non-binding) > > BR, > Zike Yang > > On Wed, Sep 6, 2023 at 11:47 PM tison wrote: > > > > +1 (binding) > > > > Trivial with low risk. > > > > Best, > > tison. > > > > > > mattison chao 于2023年9月6日周三 22:50写道： > > > > > +1 (bin

Pulsar Helm Chart: Add HPA scaleUp/scaleDown behavior support

2023-09-06 Thread Frank Kelly
Hello Pulsar Family, When folks get a chance I would appreciate some feedback on this proposed enhancement for Broker and Proxy autoscaling. https://github.com/apache/pulsar-helm-chart/pull/391 Thanks in advance Frank Kelly -- *Frank Kelly | Principal Engineer, Core Platform Team* www.cogit

RE: [VOTE] Pulsar DotPulsar Release 3.0.0 Candidate 1

2023-09-06 Thread David Jensen
Thanks for helping to bring this release forward, Tison :) +1 (non-binding) Greetings David Jensen On 2023/09/03 03:47:18 tison wrote: > Hi everyone, > > This is the first release candidate for Apache DotPulsar, version 3.0.0. > > It fixes the following issues: > https://github.com/apache/pulsa

Re: [VOTE] PIP-277: Add `current` option in the Clusters list cmd

2023-09-06 Thread guo jiwei
Thanks. Close the vote with 3+ (binding): Penghui Mattison tison 2+(non-binding): Zike Zixuan Regards Jiwei Guo (Tboy) On Thu, Sep 7, 2023 at 12:48 AM Zixuan Liu wrote: > +1 (non-binding) > > Best, > Zixuan > > Zike Yang 于2023年9月6日周三 23:56写道： > > > > +1 (non-binding) > > > > BR, > > Zike Yan