Re: [DISCUSS] New label type: category/*

2023-08-21 Thread Hang Chen
+1 for adding the above three labels. Regards, Hang tison 于2023年8月22日周二 00:18写道: > > You may update the label strategy page simultaneously - > https://pulsar.apache.org/contribute/develop-labels/ > > Best, > tison. > > > PengHui Li 于2023年8月21日周一 23:41写道: > > > I will add the labels, and if ther

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

2023-08-21 Thread PengHui Li
+1(binding) - The motivation looks good to me. The proposal will provide a real e2e encryption solution for the WebSocket proxy - The solution looks good to me. It will not introduce break changes and will use public APIs as much as possible. And it will not introduce any extra configuration. The

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

2023-08-21 Thread mattisonchao
+1 (binding) This proposal looks great to me. But I've got several concerns which will not affect this PIP voting. 1. You mixed compression and E2E encryption support in one proposal. I am unsure if we should split them into two parts(compression & E2E) to help make the proposal not too comple

Re: [DISCUSS] New label type: category/*

2023-08-21 Thread PengHui Li
The PR is available for review https://github.com/apache/pulsar-site/pull/678 Regards, Penghui On Tue, Aug 22, 2023 at 10:02 AM Hang Chen wrote: > +1 for adding the above three labels. > > Regards, > Hang > > tison 于2023年8月22日周二 00:18写道: > > > > You may update the label strategy page simultan

Re: [DISCUSS] PIP-281: Optimize Bundle Unload(Transfer) Protocol for ExtensibleLoadManager

2023-08-21 Thread PengHui Li
> Actually, this is incorrect. Currently, the leader broker globally triggers unloading. When the leader crahshes, the new leader broker will delay unloading until it collects sufficient broker load data and bundle load data. Ok, good to know. How long will it take to collect sufficient broker loa

Re: [DISCUSS] New label type: category/*

2023-08-21 Thread PengHui Li
> These tags are clear. Is there any existing document for what the labels represent? If not, we'd better create one. I think no, maybe we can have a page for Committers under the Community tab [image: image.png] Regards, Penghui On Mon, Aug 21, 2023 at 2:29 PM Yubiao Feng wrote: > @Penghui >

[VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

2023-08-21 Thread Yubiao Feng
Hello, Guys Since there are no concerns in the discussion mail, I'd like to start voting for this PIP. The PIP link: https://github.com/apache/pulsar/pull/ 20923 Thanks Yubiao Feng

Re: [VOTE] PIP-294: Filter Low Throughput Bundles For Report

2023-08-21 Thread PengHui Li
Thanks for driving the improvement to the load balancer. I have left some comments in the PIP's PR for improving the readability of the proposal Please take a look. Regards, Penghui On Sat, Aug 19, 2023 at 4:28 PM fwz wrote: > Hi Pulsar Community,  > This is the vote thread for PIP-294: > http

Re: [VOTE] PIP-284 Replace reader with table view in the topic policy service

2023-08-21 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Mon, Aug 21, 2023 at 1:34 PM Yunze Xu wrote: > +1 (binding) > > The only question I have is that do we need a PIP for such a change? > > Thanks, > Yunze > > On Sun, Aug 20, 2023 at 10:14 AM wrote: > > > > Hello, Guys > > > > Since there are no concern

Re: [DISCUSS] PIP-264: Enhanced OTel-based metric system

2023-08-21 Thread Hang Chen
Hi Asaf, Thanks for bring up the great proposal. After reading this proposal, I have the following questions. 1. This proposal will introduce a big break change in Pulsar, especially in code perspective. I’m interested in how to support both old and new implementation at the same time step by

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

2023-08-21 Thread Yubiao Feng
Sorry, the PR link in the last email is ambiguous, https://github.com/apache/pulsar/pull/20923 is the correct one. Thanks Yubiao Feng On Mon, Aug 21, 2023 at 4:07 PM Yubiao Feng wrote: > Hello, Guys > > Since there are no concerns in the discussion mail, I'd like to start > voting for this PIP.

Re: [VOTE] PIP-294: Filter Low Throughput Bundles For Report

2023-08-21 Thread Hang Chen
Hi fwz, Thanks for driving this proposal. I left some comments in the PIP's PR, and please help take a look at it. Regards, Hang PengHui Li 于2023年8月21日周一 16:15写道: > > Thanks for driving the improvement to the load balancer. > > I have left some comments in the PIP's PR for improving the read

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-08-21 Thread mattisonchao
Hi, I agree with this change to improve the stability of the pulsar cluster. Just one concern. it's better to move this discussion to a new PIP. because you wanna introduce a new broker configuration. `brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute` FYI: https://github.com/apache/puls

Re: [DISCUSS] PIP-281: Optimize Bundle Unload(Transfer) Protocol for ExtensibleLoadManager

2023-08-21 Thread PengHui Li
> However, with this optional field approach, we don't need to introduce a new protocol version, which could be arguably beneficial. I will leave the decision to the community. Let me know if I have to use new commands and increase the protocolVersion for this change. I don't see any drawbacks of

Re: [VOTE] PIP-284 Replace reader with table view in the topic policy service

2023-08-21 Thread Hang Chen
+1 (binding) Thanks, Hang guo jiwei 于2023年8月21日周一 16:24写道: > > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Mon, Aug 21, 2023 at 1:34 PM Yunze Xu wrote: > > > +1 (binding) > > > > The only question I have is that do we need a PIP for such a change? > > > > Thanks, > > Yunze > > > > On

Re: [VOTE] Pulsar Client Python Release 3.3.0 Candidate 1

2023-08-21 Thread Yunze Xu
+1 (binding) - Verified signature and checksums - Build the wheel from source and run examples - Run examples with the following wheels: - Python 3.11 on macOS m1 - Python 3.10 on Ubuntu 22.04 arm64 Thanks, Yunze On Fri, Aug 18, 2023 at 10:25 AM Baodi Shi wrote: > > This is the Nth release

Re: [DISCUSS] New label type: category/*

2023-08-21 Thread mattisonchao
+1. Quality and performance are now the most essential parts of Apache Pulsar. Adding a clear label to help manage and measure would be great. Best, Mattison On 21 Aug 2023 at 15:30 +0800, PengHui Li , wrote: > > These tags are clear. Is there any existing document for what the > labels represe

Re: [DISCUSS] New label type: category/*

2023-08-21 Thread PengHui Li
I will add the labels, and if there are any objections, I will revert it back. Regards, Penghui On Mon, Aug 21, 2023 at 10:36 PM wrote: > +1. > > > Quality and performance are now the most essential parts of Apache Pulsar. > Adding a clear label to help manage and measure would be great. > > Be

Re: [DISCUSS] New label type: category/*

2023-08-21 Thread tison
You may update the label strategy page simultaneously - https://pulsar.apache.org/contribute/develop-labels/ Best, tison. PengHui Li 于2023年8月21日周一 23:41写道: > I will add the labels, and if there are any objections, I will revert it > back. > > Regards, > Penghui > > On Mon, Aug 21, 2023 at 10:3

Re: [DISCUSS] PIP-281: Optimize Bundle Unload(Transfer) Protocol for ExtensibleLoadManager

2023-08-21 Thread Heesung Sohn
Hi Penghui, I added one comment below. On Mon, Aug 21, 2023 at 6:12 AM PengHui Li wrote: > > However, with this optional field approach, we don't need to introduce a > new protocol version, which could be arguably beneficial. > I will leave the decision to the community. Let me know if I have t