Re: [VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-20 Thread Hang Chen
+1 (binding) Thanks, Hang 于2023年8月18日周五 06:33写道: > > +1 (binding) > > > Best, > Mattison > On 15 Aug 2023 at 16:24 +0800, guo jiwei , wrote: > > Hi dev, > > There is a config in ServiceConfiguration called > > `disableBrokerInterceptors` introduced by #8157 > >

Re: [VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-20 Thread guo jiwei
Thanks. Close the vote with 3(binding) + 1(non-binding). Regards Jiwei Guo (Tboy) On Mon, Aug 21, 2023 at 9:32 AM Hang Chen wrote: > +1 (binding) > > Thanks, > Hang > > 于2023年8月18日周五 06:33写道: > > > > +1 (binding) > > > > > > Best, > > Mattison > > On 15 Aug 2023 at 16:24 +0800, guo jiwei ,

[DISCUSS] New label type: category/*

2023-08-20 Thread PengHui Li
Hi all, I would like to start a discussion about adding a new label type category/* There are three labels are supposed to be added - category/functionality - category/reliability - category/performance It could be a good improvement to the labeling system that Pulsar has today. Now, Pulsar main

Re: [DISCUSS] New label type: category/*

2023-08-20 Thread PengHui Li
Sorry, accidentally clicked send button :), please ignore the previous email. Hi all, I would like to start a discussion about adding a new label type category/* There are three labels are supposed to be added - category/functionality - category/reliability - category/performance It could be a

Re: [VOTE] PIP-284 Replace reader with table view in the topic policy service

2023-08-20 Thread Yunze Xu
+1 (binding) The only question I have is that do we need a PIP for such a change? Thanks, Yunze On Sun, Aug 20, 2023 at 10:14 AM wrote: > > Hello, Guys > > Since there are no concerns in the discussion mail, I'd like to start voting > for this PIP. > > The PIP link: https://github.com/apache/p

Re: [DISCUSS] New label type: category/*

2023-08-20 Thread Yunze Xu
These tags are clear. Is there any existing document for what the labels represent? If not, we'd better create one. Thanks, Yunze On Mon, Aug 21, 2023 at 12:28 PM PengHui Li wrote: > > Sorry, accidentally clicked send button :), please ignore the previous > email. > > Hi all, > > I would like to

Re: [DISCUSS] New label type: category/*

2023-08-20 Thread Yubiao Feng
@Penghui It feels great, and it's really helpful for the community to sift through highlighting PRs Thanks Yubiao On Mon, Aug 21, 2023 at 12:28 PM PengHui Li wrote: > Sorry, accidentally clicked send button :), please ignore the previous > email. > > Hi all, > > I would like to start a discu