[VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-06-15 Thread guo jiwei
Hi, community: The metrics are all started with `pulsar_`, so that both users and operators can quickly find the metrics of the entire system through this prefix. However, due to some other reasons, it was found that `topic_load_times` was missing the prefix, so want to get it right. In the

Re: [DISCUSS] PIP-264: Enhanced OTel-based metric system

2023-06-15 Thread Matteo Merli
> Proposing a large breaking change (even if it's crucial) is the single fastest way to motivate your users to migrate to a different platform. I wish it wasn't the case, but it's the cold reality. If you read the proposal, there is no real breaking change. There will be a switch to choose the exi

Re: [VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-06-15 Thread Asaf Mesika
-1 (non-binding) I'm perfectly ok with the idea; just please fix the document. It looks too messy. Even 1 paragraph changes can look neat and clean. I left notes in the draft PR you opened for the pip. I'll change my non-binding vote once that's done. On Thu, Jun 15, 2023 at 11:07 AM guo jiwei